From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id EC68D20BD for ; Wed, 9 Aug 2017 11:15:57 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 09 Aug 2017 02:15:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,346,1498546800"; d="scan'208";a="138132167" Received: from dpdk-test32.sh.intel.com (HELO [10.67.119.120]) ([10.67.119.120]) by fmsmga006.fm.intel.com with ESMTP; 09 Aug 2017 02:15:55 -0700 Message-ID: <598B4DB3.2080106@intel.com> Date: Thu, 10 Aug 2017 02:00:19 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Herbert Guan , dts@dpdk.org References: <1502099866-4795-1-git-send-email-herbert.guan@arm.com> In-Reply-To: <1502099866-4795-1-git-send-email-herbert.guan@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH] tests/short_live: fix issues in wating for link status up X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Aug 2017 09:15:58 -0000 Thanks Herbert. Applied. By now waiting few seconds for link stability is the most appropriate way for different kinds of NICs. On 08/07/2017 05:57 PM, Herbert Guan wrote: > fixes: 78212a000d ("tests/short_live: fixes the result parsing issue") > For fiber links, no "LSC event" is expected. So "testpmd>" is the > correct string to check. > Change to use sleep(5) for non-fiber links to wait for the links up. > > Signed-off-by: Herbert Guan