From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] fix hotplug failed case
Date: Fri, 25 Aug 2017 19:39:18 +0800 [thread overview]
Message-ID: <59A00C66.5050805@intel.com> (raw)
In-Reply-To: <1503628064-89166-1-git-send-email-huilongx.xu@intel.com>
Huilong, one comment below.
On 08/25/2017 10:27 AM, xu,huilong wrote:
> def send_packet(self, port):
> """
> Send a packet to port
> """
> - self.dmac = self.dut.get_mac_address(self.dut_ports[0])
> - txport = self.tester.get_local_port(self.dut_ports[0])
> + self.dmac = self.dut.get_mac_address(self.port)
> + txport = self.tester.get_local_port(self.port)
> self.txItf = self.tester.get_interface(txport)
> pkt = Packet(pkt_type='UDP')
Argument "port" is not used in the function, please remove it if it is
useless.
prev parent reply other threads:[~2017-08-25 2:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 2:27 xu,huilong
2017-08-25 11:39 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59A00C66.5050805@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=huilongx.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).