From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8AA687D13 for ; Fri, 25 Aug 2017 04:55:44 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Aug 2017 19:55:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,423,1498546800"; d="scan'208";a="143720767" Received: from dpdk-test32.sh.intel.com (HELO [10.67.119.120]) ([10.67.119.120]) by fmsmga005.fm.intel.com with ESMTP; 24 Aug 2017 19:55:43 -0700 Message-ID: <59A00C66.5050805@intel.com> Date: Fri, 25 Aug 2017 19:39:18 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "xu,huilong" , dts@dpdk.org References: <1503628064-89166-1-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1503628064-89166-1-git-send-email-huilongx.xu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V1] fix hotplug failed case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 02:55:45 -0000 Huilong, one comment below. On 08/25/2017 10:27 AM, xu,huilong wrote: > def send_packet(self, port): > """ > Send a packet to port > """ > - self.dmac = self.dut.get_mac_address(self.dut_ports[0]) > - txport = self.tester.get_local_port(self.dut_ports[0]) > + self.dmac = self.dut.get_mac_address(self.port) > + txport = self.tester.get_local_port(self.port) > self.txItf = self.tester.get_interface(txport) > pkt = Packet(pkt_type='UDP') Argument "port" is not used in the function, please remove it if it is useless.