From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] fix ipfrag failed on FreeBSD
Date: Wed, 30 Aug 2017 01:45:39 +0800 [thread overview]
Message-ID: <59A5A843.5030507@intel.com> (raw)
In-Reply-To: <1503993854-99839-1-git-send-email-gangx.xu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
Gang,
This tar file may not existed on tester and zipped filename can be
changed by dts parameter.
Please do not assume that tester has the source code.
Just from your patch, you have handled the difference of FreeBSD. Why
not just do it on DUT?
Please also check other suites whether they may also facing the same issue.
Thanks,
Marvin
On 08/29/2017 04:04 PM, xu,gang wrote:
> - self.dut.send_expect(r"sed -i '/l3fwd_ipv6_route_array\[\].*{/,/^\}\;/c\\%s' examples/ip_fragmentation/main.c" % lpmStr_ipv6, "# ")
> +
> + if self.dut.get_os_type() == 'freebsd':
> + self.tester.send_expect("tar zxf dep/dpdk.tar.gz -C/tmp/", "# ")
> + self.tester.send_expect(
> + r"sed -i '/l3fwd_ipv4_route_array\[\].*{/,/^\}\;/c\\%s' /tmp/dpdk/examples/ip_fragmentation/main.c" % lpmStr_ipv4, "# ")
> + self.tester.send_expect(
> + r"sed -i '/l3fwd_ipv6_route_array\[\].*{/,/^\}\;/c\\%s' /tmp/dpdk/examples/ip_fragmentation/main.c" % lpmStr_ipv6, "# ")
> + self.dut.session.copy_file_to(
> + '/tmp/dpdk/examples/ip_fragmentation/main.c', '/root/dpdk')
> + self.dut.send_expect("mv main.c examples/ip_fragmentation/", "# ")
> +
> + else:
> + self.dut.send_expect(
> + r"sed -i '/l3fwd_ipv4_route_array\[\].*{/,/^\}\;/c\\%s' examples/ip_fragmentation/main.c" % lpmStr_ipv4, "# ")
> + self.dut.send_expect(
> + r"sed -i '/l3fwd_ipv6_route_array\[\].*{/,/^\}\;/c\\%s' examples/ip_fragmentation/main.c" % lpmStr_ipv6, "# ")
> +
[-- Attachment #2: Type: text/html, Size: 2129 bytes --]
prev parent reply other threads:[~2017-08-29 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 8:04 xu,gang
2017-08-29 17:45 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59A5A843.5030507@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=gangx.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).