test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/skeleton: fix case failed when ports were not ready.
@ 2017-09-13  1:18 Phil Yang
  2017-09-14  6:15 ` Jianbo Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Phil Yang @ 2017-09-13  1:18 UTC (permalink / raw)
  To: dts; +Cc: nd, Phil Yang

Sometime tests/skeleton will fail in capturing packets of the target
RJ45 port while the connection is establishing.
Add a delay to waiting for the connection ready.

Signed-off-by: Phil Yang <phil.yang@arm.com>
---
 tests/TestSuite_skeleton.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_skeleton.py b/tests/TestSuite_skeleton.py
index a5cc591..77f95e1 100644
--- a/tests/TestSuite_skeleton.py
+++ b/tests/TestSuite_skeleton.py
@@ -75,6 +75,8 @@ class TestSkeleton(TestCase):
         cmd = self.path + " -c %s -n %d " % (self.coremask,self.dut.get_memory_channels())
         self.dut.send_expect(cmd,"forwarding packets",60)
          
+        time.sleep(5)
+
         self.iface_port0 = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
         self.iface_port1 = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1]))
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] tests/skeleton: fix case failed when ports were not ready.
  2017-09-13  1:18 [dts] [PATCH] tests/skeleton: fix case failed when ports were not ready Phil Yang
@ 2017-09-14  6:15 ` Jianbo Liu
  2017-09-14 15:02   ` Liu, Yong
  0 siblings, 1 reply; 3+ messages in thread
From: Jianbo Liu @ 2017-09-14  6:15 UTC (permalink / raw)
  To: Phil Yang; +Cc: dts, nd

On 13 September 2017 at 09:18, Phil Yang <phil.yang@arm.com> wrote:
> Sometime tests/skeleton will fail in capturing packets of the target
> RJ45 port while the connection is establishing.
> Add a delay to waiting for the connection ready.
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> ---
>  tests/TestSuite_skeleton.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/TestSuite_skeleton.py b/tests/TestSuite_skeleton.py
> index a5cc591..77f95e1 100644
> --- a/tests/TestSuite_skeleton.py
> +++ b/tests/TestSuite_skeleton.py
> @@ -75,6 +75,8 @@ class TestSkeleton(TestCase):
>          cmd = self.path + " -c %s -n %d " % (self.coremask,self.dut.get_memory_channels())
>          self.dut.send_expect(cmd,"forwarding packets",60)
>
> +        time.sleep(5)
> +
>          self.iface_port0 = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
>          self.iface_port1 = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1]))
>
> --
> 2.7.4
>

Acked-by: Jianbo Liu <jianbo.liu@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] tests/skeleton: fix case failed when ports were not ready.
  2017-09-14  6:15 ` Jianbo Liu
@ 2017-09-14 15:02   ` Liu, Yong
  0 siblings, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2017-09-14 15:02 UTC (permalink / raw)
  To: Jianbo Liu, Phil Yang; +Cc: dts, nd

Thanks all, applied in.

On 09/14/2017 02:15 PM, Jianbo Liu wrote:
> On 13 September 2017 at 09:18, Phil Yang <phil.yang@arm.com> wrote:
>> Sometime tests/skeleton will fail in capturing packets of the target
>> RJ45 port while the connection is establishing.
>> Add a delay to waiting for the connection ready.
>>
>> Signed-off-by: Phil Yang <phil.yang@arm.com>
>> ---
>>   tests/TestSuite_skeleton.py | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/TestSuite_skeleton.py b/tests/TestSuite_skeleton.py
>> index a5cc591..77f95e1 100644
>> --- a/tests/TestSuite_skeleton.py
>> +++ b/tests/TestSuite_skeleton.py
>> @@ -75,6 +75,8 @@ class TestSkeleton(TestCase):
>>           cmd = self.path + " -c %s -n %d " % (self.coremask,self.dut.get_memory_channels())
>>           self.dut.send_expect(cmd,"forwarding packets",60)
>>
>> +        time.sleep(5)
>> +
>>           self.iface_port0 = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
>>           self.iface_port1 = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1]))
>>
>> --
>> 2.7.4
>>
> Acked-by: Jianbo Liu <jianbo.liu@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-09-14  6:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-13  1:18 [dts] [PATCH] tests/skeleton: fix case failed when ports were not ready Phil Yang
2017-09-14  6:15 ` Jianbo Liu
2017-09-14 15:02   ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).