test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] fix vlan filter test failed
@ 2017-09-22  5:41 xu,huilong
  2017-09-25 13:51 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,huilong @ 2017-09-22  5:41 UTC (permalink / raw)
  To: dts; +Cc: xu,huilong

when use packet model send packet, packet model will set default dst mac is broadcast mac,
if we not set packet dst mac. But when send vlan packet, if dst mac is broadcast, the vlan filter
will not work, fortville nic will received all boradcast packet.

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index bf3f8e6..a901a47 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -419,6 +419,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         self.dut.send_expect(self.cmd, "EthApp>", 60)
         for index in range(len(self.ports)):
             port = self.ports[index]
+            dst_mac =  self.dut.get_mac_address(port)
             # generate random vlan
             vlan = random.randrange(0, 4095)
             # add vlan on port, record original statistic
@@ -427,6 +428,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
 
             # send correct vlan packet to port
             pkt = Packet(pkt_type='VLAN_UDP')
+            pkt.config_layer('ether', {'dst': dst_mac})
             pkt.config_layer('vlan', {'vlan': vlan})
             tester_port = self.tester.get_local_port(port)
             intf = self.tester.get_interface(tester_port)
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] fix vlan filter test failed
  2017-09-22  5:41 [dts] [PATCH V1] fix vlan filter test failed xu,huilong
@ 2017-09-25 13:51 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-09-25 13:51 UTC (permalink / raw)
  To: xu,huilong, dts

Huilong, thanks for detail information. Applied.

On 09/22/2017 01:41 PM, xu,huilong wrote:
> when use packet model send packet, packet model will set default dst mac is broadcast mac,
> if we not set packet dst mac. But when send vlan packet, if dst mac is broadcast, the vlan filter
> will not work, fortville nic will received all boradcast packet.
>
> Signed-off-by: xu,huilong<huilongx.xu@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-25  5:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-22  5:41 [dts] [PATCH V1] fix vlan filter test failed xu,huilong
2017-09-25 13:51 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).