test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,huilong" <huilongx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] fix update_system case failed
Date: Sat, 30 Sep 2017 19:56:16 +0800	[thread overview]
Message-ID: <59CF8660.9060001@intel.com> (raw)
In-Reply-To: <1506503265-29342-4-git-send-email-huilongx.xu@intel.com>

Huilong,
One comment below.

Thanks,
Marvin

On 09/27/2017 05:07 PM, xu,huilong wrote:
> some times, when use data cmdline get dut systerm time, after kill ptpclent example.
> the output will include "[1]+  Terminated              ./examples/ptpclient/build/ptpclient -c f -n 3 -- -T 1 -p 0x1"
> so should get systerm time again.
This output is not expected. You can work around this by using 
alternative session self.dut.alt_session.
But anyway, ptpclient should not be killed.  Please check where 
ptpclient was killed.

> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_ptpclient.py | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/TestSuite_ptpclient.py b/tests/TestSuite_ptpclient.py
> index 2f5e004..99c2619 100644
> --- a/tests/TestSuite_ptpclient.py
> +++ b/tests/TestSuite_ptpclient.py
> @@ -148,6 +148,8 @@ class TestPtpClient(TestCase):
>   
>           tester_out = self.tester.send_expect("date -u '+%Y-%m-%d %H:%M'", "# ")
>           dut_out = self.dut.send_expect("date -u '+%Y-%m-%d %H:%M'", "# ")
> +        if len(dut_out) != len(tester_out):
> +            dut_out = self.dut.send_expect("date -u '+%Y-%m-%d %H:%M'", "# ")
>   
>           self.verify(tester_out == dut_out, "the DUT time synchronous error")
>   

  reply	other threads:[~2017-09-30  3:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  9:07 [dts] [PATCH V1] fix fortville_25g dual vlan failed case xu,huilong
2017-09-27  9:07 ` [dts] [PATCH V1] fix rss key size case failed xu,huilong
2017-09-30 10:42   ` Liu, Yong
2017-09-30 11:03   ` Liu, Yong
2017-09-27  9:07 ` [dts] [PATCH V1] fix skeleton test " xu,huilong
2017-09-30 11:39   ` Liu, Yong
2017-09-27  9:07 ` [dts] [PATCH V1] fix update_system " xu,huilong
2017-09-30 11:56   ` Liu, Yong [this message]
2017-09-27  9:07 ` [dts] [PATCH V1] remove repeating check nic type xu,huilong
2017-09-30 11:45   ` Liu, Yong
2017-09-27  9:07 ` [dts] [PATCH V1] update fortville_25g check case list xu,huilong
2017-09-30 12:13   ` Liu, Yong
2017-09-30 10:35 ` [dts] [PATCH V1] fix fortville_25g dual vlan failed case Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59CF8660.9060001@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).