test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/sriov_kvm: update negative input commands
@ 2017-10-24  8:16 Fangfang Wei
  2017-10-30  9:23 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Fangfang Wei @ 2017-10-24  8:16 UTC (permalink / raw)
  To: dts; +Cc: Fangfangx Wei

From: Fangfangx Wei <fangfangx.wei@intel.com>

DPDK-3807: developer said the rule-id can be any value which is set by user.
So setting the invalid rule-id as 256 to test negative input commands.
Because in dpdk the mirror rule-id is uint8_t.

Remove command "set port 0 mirror-rule 2 vlan-mirror 9 dst-pool 1 on".
It's not a invalid command for vlan-mirror is supported now.

Signed-off-by: Fangfangx Wei <fangfangx.wei@intel.com>
---
 tests/TestSuite_sriov_kvm.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
index 8424b22..440306c 100644
--- a/tests/TestSuite_sriov_kvm.py
+++ b/tests/TestSuite_sriov_kvm.py
@@ -1263,8 +1263,7 @@ class TestSriovKvm(TestCase):
                         "set port 0 vf 34 rxmode ROPE on",
                         "mac_addr add port 0 vf 65 00:55:44:33:22:11",
                         "mac_addr add port 5 vf 0 00:55:44:88:22:11",
-                        "set port 0 mirror-rule 0xf uplink-mirror dst-pool 1 on",
-                        "set port 0 mirror-rule 2 vlan-mirror 9 dst-pool 1 on",
+                        "set port 0 mirror-rule 256 uplink-mirror dst-pool 1 on",
                         "set port 0 mirror-rule 0 downlink-mirror 0xf dst-pool 2 off",
                         "reset port 0 mirror-rule 4",
                         "reset port 0xff mirror-rule 0"]:
-- 
2.7.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/sriov_kvm: update negative input commands
  2017-10-24  8:16 [dts] [PATCH V1] tests/sriov_kvm: update negative input commands Fangfang Wei
@ 2017-10-30  9:23 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-10-30  9:23 UTC (permalink / raw)
  To: Fangfang Wei, dts

Thanks fangfang, applied.

On 10/24/2017 04:16 PM, Fangfang Wei wrote:
> From: Fangfangx Wei<fangfangx.wei@intel.com>
>
> DPDK-3807: developer said the rule-id can be any value which is set by user.
> So setting the invalid rule-id as 256 to test negative input commands.
> Because in dpdk the mirror rule-id is uint8_t.
>
> Remove command "set port 0 mirror-rule 2 vlan-mirror 9 dst-pool 1 on".
> It's not a invalid command for vlan-mirror is supported now.
>
> Signed-off-by: Fangfangx Wei<fangfangx.wei@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-30  1:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-24  8:16 [dts] [PATCH V1] tests/sriov_kvm: update negative input commands Fangfang Wei
2017-10-30  9:23 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).