test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vf_vlan: Remove useless codes
@ 2017-11-06  3:03 Fangfang Wei
  2017-11-13  9:23 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Fangfang Wei @ 2017-11-06  3:03 UTC (permalink / raw)
  To: dts; +Cc: Fangfangx Wei

From: Fangfangx Wei <fangfangx.wei@intel.com>

Reference to DPDK-4036: VF vlan strip is supported from i40e kernel driver
2.1.26.
So remove useless codes.

Signed-off-by: Fangfangx Wei <fangfangx.wei@intel.com>
---
 tests/TestSuite_vf_vlan.py | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index ab64a15..aae3b6d 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -393,14 +393,8 @@ class TestVfVlan(TestCase):
             out = self.send_and_getout(vlan=rx_vlan, pkt_type="VLAN_UDP")
             self.verify(
                 "received 1 packets" in out, "Not received vlan packet as expected!!!")
-            nic_type = self.vm_dut_0.ports_info[0]['type']
-            nic_name = get_nic_name(nic_type)
-            if nic_name in ['fvl10g_vf', 'fortpark_TLV_vf']:
-                self.verify("VLAN tci=%s" %
-                            vlan_hex in out, "Failed to disable strip vlan!!!")
-            else:
-                self.verify(
-                    "PKT_RX_VLAN_STRIPPED" not in out, "Failed to disable strip vlan!!!")
+            self.verify(
+                "PKT_RX_VLAN_STRIPPED" not in out, "Failed to disable strip vlan!!!")
 
         self.vm0_testpmd.quit()
 
-- 
2.7.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_vlan: Remove useless codes
  2017-11-06  3:03 [dts] [PATCH V1] tests/vf_vlan: Remove useless codes Fangfang Wei
@ 2017-11-13  9:23 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-11-13  9:23 UTC (permalink / raw)
  To: Fangfang Wei, dts

Thanks, Fangfang. Applied.

On 11/06/2017 11:03 AM, Fangfang Wei wrote:
> From: Fangfangx Wei<fangfangx.wei@intel.com>
>
> Reference to DPDK-4036: VF vlan strip is supported from i40e kernel driver
> 2.1.26.
> So remove useless codes.
>
> Signed-off-by: Fangfangx Wei<fangfangx.wei@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-13  1:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06  3:03 [dts] [PATCH V1] tests/vf_vlan: Remove useless codes Fangfang Wei
2017-11-13  9:23 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).