test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Zhang, Yuwei1" <yuwei1.zhang@intel.com>,  "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] modprobe vfio-pci driver in vf related test suite.
Date: Mon, 13 Nov 2017 17:29:35 +0800	[thread overview]
Message-ID: <5A0965FF.7010902@intel.com> (raw)
In-Reply-To: <EC241D52C34C9A4BA57BFACAB76C70A43163167D@SHSMSX101.ccr.corp.intel.com>

Got it, patch applied in.

On 11/10/2017 01:24 PM, Zhang, Yuwei1 wrote:
> Dts will parse the config file to determine the vf_driver and bind to the VF, code is in last patch. Thanks.
>
> -----Original Message-----
> From: Liu, Yong
> Sent: Friday, November 10, 2017 1:21 PM
> To: Zhang, Yuwei1 <yuwei1.zhang@intel.com>; dts@dpdk.org
> Cc: Zhang, Yuwei1 <yuwei1.zhang@intel.com>
> Subject: RE: [dts] [PATCH V1] modprobe vfio-pci driver in vf related test suite.
>
> Hi Yuwei,
> I can't see any bind action in your patch, is there any code can make sure VF device was bound to vfio-pci?
>
>
> Thanks,
> Marvin
>
>> -----Original Message-----
>> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yuwei Zhang
>> Sent: Wednesday, November 01, 2017 2:12 PM
>> To: dts@dpdk.org
>> Cc: Zhang, Yuwei1 <yuwei1.zhang@intel.com>
>> Subject: [dts] [PATCH V1] modprobe vfio-pci driver in vf related test
>> suite.
>>
>> Signed-off-by: Yuwei Zhang <yuwei1.zhang@intel.com>
>> ---
>>   tests/TestSuite_vf_jumboframe.py       | 1 +
>>   tests/TestSuite_vf_macfilter.py        | 2 +-
>>   tests/TestSuite_vf_offload.py          | 2 +-
>>   tests/TestSuite_vf_packet_rxtx.py      | 1 +
>>   tests/TestSuite_vf_port_start_stop.py  | 2 +-
>> tests/TestSuite_vf_to_vf_nic_bridge.py | 1 +
>>   tests/TestSuite_vf_vlan.py             | 1 +
>>   7 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/TestSuite_vf_jumboframe.py
>> b/tests/TestSuite_vf_jumboframe.py
>> index 7a62a50..fc4971b 100644
>> --- a/tests/TestSuite_vf_jumboframe.py
>> +++ b/tests/TestSuite_vf_jumboframe.py
>> @@ -43,6 +43,7 @@ class TestVfJumboFrame(TestCase):
>>               self.vf_assign_method = 'pci-assign'
>>           else:
>>               self.vf_assign_method = 'vfio-pci'
>> +            self.dut.send_expect('modprobe vfio-pci', '#')
>>
>>           # enable tester mtu
>>           tester_port = self.tester.get_local_port(self.port)
>> diff --git a/tests/TestSuite_vf_macfilter.py
>> b/tests/TestSuite_vf_macfilter.py index ec290a7..23105a4 100644
>> --- a/tests/TestSuite_vf_macfilter.py
>> +++ b/tests/TestSuite_vf_macfilter.py
>> @@ -30,7 +30,7 @@ class TestVfMacFilter(TestCase):
>>               self.vf_assign_method = 'pci-assign'
>>           else:
>>               self.vf_assign_method = 'vfio-pci'
>> -            self.tester.send_expect('modprobe vfio-pci', '#')
>> +            self.dut.send_expect('modprobe vfio-pci', '#')
>>
>>       def set_up(self):
>>
>> diff --git a/tests/TestSuite_vf_offload.py
>> b/tests/TestSuite_vf_offload.py index 2cb402b..61ef453 100644
>> --- a/tests/TestSuite_vf_offload.py
>> +++ b/tests/TestSuite_vf_offload.py
>> @@ -32,7 +32,7 @@ class TestVfOffload(TestCase):
>>               self.vf_assign_method = 'pci-assign'
>>           else:
>>               self.vf_assign_method = 'vfio-pci'
>> -            self.tester.send_expect('modprobe vfio-pci', '#')
>> +            self.dut.send_expect('modprobe vfio-pci', '#')
>>
>>           self.setup_2pf_2vf_1vm_env_flag = 0
>>           self.setup_2pf_2vf_1vm_env(driver='')
>> diff --git a/tests/TestSuite_vf_packet_rxtx.py
>> b/tests/TestSuite_vf_packet_rxtx.py
>> index 56d618c..83ccf1e 100644
>> --- a/tests/TestSuite_vf_packet_rxtx.py
>> +++ b/tests/TestSuite_vf_packet_rxtx.py
>> @@ -30,6 +30,7 @@ class TestVfPacketRxtx(TestCase):
>>               self.vf_assign_method = 'pci-assign'
>>           else:
>>               self.vf_assign_method = 'vfio-pci'
>> +            self.tester.send_expect('modprobe vfio-pci', '#')
>>
>>
>>
>> diff --git a/tests/TestSuite_vf_port_start_stop.py
>> b/tests/TestSuite_vf_port_start_stop.py
>> index 5629f8c..3ebee73 100644
>> --- a/tests/TestSuite_vf_port_start_stop.py
>> +++ b/tests/TestSuite_vf_port_start_stop.py
>> @@ -32,7 +32,7 @@ class TestVfPortStartStop(TestCase):
>>               self.vf_assign_method = 'pci-assign'
>>           else:
>>               self.vf_assign_method = 'vfio-pci'
>> -            self.tester.send_expect('modprobe vfio-pci', '#')
>> +            self.dut.send_expect('modprobe vfio-pci', '#')
>>
>>       def set_up(self):
>>
>> diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py
>> b/tests/TestSuite_vf_to_vf_nic_bridge.py
>> index c5b1cb6..a85cab5 100644
>> --- a/tests/TestSuite_vf_to_vf_nic_bridge.py
>> +++ b/tests/TestSuite_vf_to_vf_nic_bridge.py
>> @@ -66,6 +66,7 @@ class TestVF2VFBridge(TestCase):
>>               self.vf_assign_method = 'pci-assign'
>>           else:
>>               self.vf_assign_method = 'vfio-pci'
>> +            self.dut.send_expect('modprobe vfio-pci', '#')
>>
>>
>>       def set_up(self):
>> diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
>> index ab64a15..f087011 100644
>> --- a/tests/TestSuite_vf_vlan.py
>> +++ b/tests/TestSuite_vf_vlan.py
>> @@ -34,6 +34,7 @@ class TestVfVlan(TestCase):
>>               self.vf_assign_method = 'pci-assign'
>>           else:
>>               self.vf_assign_method = 'vfio-pci'
>> +            self.dut.send_expect('modprobe vfio-pci', '#')
>>
>>
>>       def set_up(self):
>> --
>> 2.14.1.windows.1

      reply	other threads:[~2017-11-13  1:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01  6:12 Yuwei Zhang
2017-11-10  5:21 ` Liu, Yong
2017-11-10  5:24   ` Zhang, Yuwei1
2017-11-13  9:29     ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A0965FF.7010902@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yuwei1.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).