From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DB9A81B2D8 for ; Mon, 13 Nov 2017 02:36:03 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2017 17:36:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,386,1505804400"; d="scan'208";a="175464340" Received: from dpdk-test32.sh.intel.com (HELO [10.67.118.217]) ([10.67.118.217]) by fmsmga006.fm.intel.com with ESMTP; 12 Nov 2017 17:36:01 -0800 Message-ID: <5A0965FF.7010902@intel.com> Date: Mon, 13 Nov 2017 17:29:35 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Zhang, Yuwei1" , "dts@dpdk.org" References: <20171101061227.14812-1-yuwei1.zhang@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62F14694@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V1] modprobe vfio-pci driver in vf related test suite. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 01:36:04 -0000 Got it, patch applied in. On 11/10/2017 01:24 PM, Zhang, Yuwei1 wrote: > Dts will parse the config file to determine the vf_driver and bind to the VF, code is in last patch. Thanks. > > -----Original Message----- > From: Liu, Yong > Sent: Friday, November 10, 2017 1:21 PM > To: Zhang, Yuwei1 ; dts@dpdk.org > Cc: Zhang, Yuwei1 > Subject: RE: [dts] [PATCH V1] modprobe vfio-pci driver in vf related test suite. > > Hi Yuwei, > I can't see any bind action in your patch, is there any code can make sure VF device was bound to vfio-pci? > > > Thanks, > Marvin > >> -----Original Message----- >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yuwei Zhang >> Sent: Wednesday, November 01, 2017 2:12 PM >> To: dts@dpdk.org >> Cc: Zhang, Yuwei1 >> Subject: [dts] [PATCH V1] modprobe vfio-pci driver in vf related test >> suite. >> >> Signed-off-by: Yuwei Zhang >> --- >> tests/TestSuite_vf_jumboframe.py | 1 + >> tests/TestSuite_vf_macfilter.py | 2 +- >> tests/TestSuite_vf_offload.py | 2 +- >> tests/TestSuite_vf_packet_rxtx.py | 1 + >> tests/TestSuite_vf_port_start_stop.py | 2 +- >> tests/TestSuite_vf_to_vf_nic_bridge.py | 1 + >> tests/TestSuite_vf_vlan.py | 1 + >> 7 files changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/tests/TestSuite_vf_jumboframe.py >> b/tests/TestSuite_vf_jumboframe.py >> index 7a62a50..fc4971b 100644 >> --- a/tests/TestSuite_vf_jumboframe.py >> +++ b/tests/TestSuite_vf_jumboframe.py >> @@ -43,6 +43,7 @@ class TestVfJumboFrame(TestCase): >> self.vf_assign_method = 'pci-assign' >> else: >> self.vf_assign_method = 'vfio-pci' >> + self.dut.send_expect('modprobe vfio-pci', '#') >> >> # enable tester mtu >> tester_port = self.tester.get_local_port(self.port) >> diff --git a/tests/TestSuite_vf_macfilter.py >> b/tests/TestSuite_vf_macfilter.py index ec290a7..23105a4 100644 >> --- a/tests/TestSuite_vf_macfilter.py >> +++ b/tests/TestSuite_vf_macfilter.py >> @@ -30,7 +30,7 @@ class TestVfMacFilter(TestCase): >> self.vf_assign_method = 'pci-assign' >> else: >> self.vf_assign_method = 'vfio-pci' >> - self.tester.send_expect('modprobe vfio-pci', '#') >> + self.dut.send_expect('modprobe vfio-pci', '#') >> >> def set_up(self): >> >> diff --git a/tests/TestSuite_vf_offload.py >> b/tests/TestSuite_vf_offload.py index 2cb402b..61ef453 100644 >> --- a/tests/TestSuite_vf_offload.py >> +++ b/tests/TestSuite_vf_offload.py >> @@ -32,7 +32,7 @@ class TestVfOffload(TestCase): >> self.vf_assign_method = 'pci-assign' >> else: >> self.vf_assign_method = 'vfio-pci' >> - self.tester.send_expect('modprobe vfio-pci', '#') >> + self.dut.send_expect('modprobe vfio-pci', '#') >> >> self.setup_2pf_2vf_1vm_env_flag = 0 >> self.setup_2pf_2vf_1vm_env(driver='') >> diff --git a/tests/TestSuite_vf_packet_rxtx.py >> b/tests/TestSuite_vf_packet_rxtx.py >> index 56d618c..83ccf1e 100644 >> --- a/tests/TestSuite_vf_packet_rxtx.py >> +++ b/tests/TestSuite_vf_packet_rxtx.py >> @@ -30,6 +30,7 @@ class TestVfPacketRxtx(TestCase): >> self.vf_assign_method = 'pci-assign' >> else: >> self.vf_assign_method = 'vfio-pci' >> + self.tester.send_expect('modprobe vfio-pci', '#') >> >> >> >> diff --git a/tests/TestSuite_vf_port_start_stop.py >> b/tests/TestSuite_vf_port_start_stop.py >> index 5629f8c..3ebee73 100644 >> --- a/tests/TestSuite_vf_port_start_stop.py >> +++ b/tests/TestSuite_vf_port_start_stop.py >> @@ -32,7 +32,7 @@ class TestVfPortStartStop(TestCase): >> self.vf_assign_method = 'pci-assign' >> else: >> self.vf_assign_method = 'vfio-pci' >> - self.tester.send_expect('modprobe vfio-pci', '#') >> + self.dut.send_expect('modprobe vfio-pci', '#') >> >> def set_up(self): >> >> diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py >> b/tests/TestSuite_vf_to_vf_nic_bridge.py >> index c5b1cb6..a85cab5 100644 >> --- a/tests/TestSuite_vf_to_vf_nic_bridge.py >> +++ b/tests/TestSuite_vf_to_vf_nic_bridge.py >> @@ -66,6 +66,7 @@ class TestVF2VFBridge(TestCase): >> self.vf_assign_method = 'pci-assign' >> else: >> self.vf_assign_method = 'vfio-pci' >> + self.dut.send_expect('modprobe vfio-pci', '#') >> >> >> def set_up(self): >> diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py >> index ab64a15..f087011 100644 >> --- a/tests/TestSuite_vf_vlan.py >> +++ b/tests/TestSuite_vf_vlan.py >> @@ -34,6 +34,7 @@ class TestVfVlan(TestCase): >> self.vf_assign_method = 'pci-assign' >> else: >> self.vf_assign_method = 'vfio-pci' >> + self.dut.send_expect('modprobe vfio-pci', '#') >> >> >> def set_up(self): >> -- >> 2.14.1.windows.1