test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [dpdk-dts] [PATCH] framework/etgen: fix incorrect number of arguments
@ 2017-12-04 14:40 Jogarao Nartu
  2017-12-05 10:03 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Jogarao Nartu @ 2017-12-04 14:40 UTC (permalink / raw)
  To: yong.liu; +Cc: dts, jerin.jacob, Jogarao Nartu

SSHConnection used in IxiaPacketGenerator takes 4 arguments i.e. host,
session_name, username and password.Currently only 3 arguments are being
passed while ssh object is being initilized in IxiaPacketGenerator.
Pass the missing username agrument by including self.tester.get_username().

Fixes: 4792d001d5b5 ("framework: Add login password support")

Signed-off-by: Jogarao Nartu <njogarao@caviumnetworks.com>
---
 framework/etgen.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/etgen.py b/framework/etgen.py
index 1114453..4c0b6e2 100644
--- a/framework/etgen.py
+++ b/framework/etgen.py
@@ -140,7 +140,7 @@ class IxiaPacketGenerator(SSHConnection):
         self.NAME = 'ixia'
         self.logger = getLogger(self.NAME)
         super(IxiaPacketGenerator, self).__init__(self.get_ip_address(),
-                                                  self.NAME,
+                                                  self.NAME, self.tester.get_username(),
                                                   self.get_password())
         super(IxiaPacketGenerator, self).init_log(self.logger)
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [dpdk-dts] [PATCH] framework/etgen: fix incorrect number of arguments
  2017-12-04 14:40 [dts] [dpdk-dts] [PATCH] framework/etgen: fix incorrect number of arguments Jogarao Nartu
@ 2017-12-05 10:03 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-12-05 10:03 UTC (permalink / raw)
  To: Jogarao Nartu; +Cc: dts, jerin.jacob

Nartu, thanks for noted this issue. Applied in.

On 12/04/2017 10:40 PM, Jogarao Nartu wrote:
> SSHConnection used in IxiaPacketGenerator takes 4 arguments i.e. host,
> session_name, username and password.Currently only 3 arguments are being
> passed while ssh object is being initilized in IxiaPacketGenerator.
> Pass the missing username agrument by including self.tester.get_username().
>
> Fixes: 4792d001d5b5 ("framework: Add login password support")
>
> Signed-off-by: Jogarao Nartu<njogarao@caviumnetworks.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-05  2:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-04 14:40 [dts] [dpdk-dts] [PATCH] framework/etgen: fix incorrect number of arguments Jogarao Nartu
2017-12-05 10:03 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).