* [dts] [PATCH] framwork/qemu_kvm: Fix add_vm_disk single field parameter support.
@ 2018-01-05 10:28 Phil Yang
2018-01-09 13:06 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: Phil Yang @ 2018-01-05 10:28 UTC (permalink / raw)
To: dts; +Cc: nd, phil.yang, yong.liu
Fix add_vm_disk: Should allow single field parameter configuration for disk.
Signed-off-by: Phil Yang <phil.yang@arm.com>
---
framework/qemu_kvm.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py
index 84f961b..5671de8 100644
--- a/framework/qemu_kvm.py
+++ b/framework/qemu_kvm.py
@@ -362,6 +362,9 @@ class QEMUKvm(VirtBase):
if 'file' in options.keys() and \
options['file']:
disk_boot_line = '-drive file=%s' % options['file']
+ else:
+ return False
+
if 'opt_format' in options.keys() and \
options['opt_format']:
disk_boot_line += separator + 'format=%s' % options['opt_format']
@@ -375,8 +378,7 @@ class QEMUKvm(VirtBase):
options['opt_media']:
disk_boot_line += separator + 'media=%s' % options['opt_media']
- if self.__string_has_multi_fields(disk_boot_line, separator):
- self.__add_boot_line(disk_boot_line)
+ self.__add_boot_line(disk_boot_line)
def add_vm_pflash(self, **options):
"""
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH] framwork/qemu_kvm: Fix add_vm_disk single field parameter support.
2018-01-05 10:28 [dts] [PATCH] framwork/qemu_kvm: Fix add_vm_disk single field parameter support Phil Yang
@ 2018-01-09 13:06 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-01-09 13:06 UTC (permalink / raw)
To: Phil Yang, dts; +Cc: nd
Thanks, Phil. Applied.
On 01/05/2018 06:28 PM, Phil Yang wrote:
> Fix add_vm_disk: Should allow single field parameter configuration for disk.
>
> Signed-off-by: Phil Yang<phil.yang@arm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-09 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-05 10:28 [dts] [PATCH] framwork/qemu_kvm: Fix add_vm_disk single field parameter support Phil Yang
2018-01-09 13:06 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).