From: "Liu, Yong" <yong.liu@intel.com>
To: Phil Yang <phil.yang@arm.com>, dts@dpdk.org
Cc: nd@arm.com
Subject: Re: [dts] [PATCH] tests/vhost_user_live_migration: Optimize for multi-platform.
Date: Tue, 09 Jan 2018 21:10:25 +0800 [thread overview]
Message-ID: <5A54BF41.9010203@intel.com> (raw)
In-Reply-To: <1515148140-28422-1-git-send-email-phil.yang@arm.com>
Phil,
There's one comment as below.
On 01/05/2018 06:29 PM, Phil Yang wrote:
> +
> + dirct_pat = re.compile(r"(\s+)\[ (\S+) in\|out\|inout \]")
> + vm_dut.send_expect("tcpdump -h", "# ")
> + out = vm_dut.get_session_output(timeout=1)
> + m = dirct_pat.search(out)
> + if m:
> + dirct_para = "-" + m.group(2)[1] + " in"
> + else:
> + dirct_para = ""
> +
Please change variable name to more meaning full name "direct_param".
Thanks,
Marvin
next prev parent reply other threads:[~2018-01-09 5:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 10:29 Phil Yang
2018-01-09 6:14 ` [dts] [PATCH v2] " Phil Yang
2018-01-09 14:32 ` Liu, Yong
2018-01-09 13:10 ` Liu, Yong [this message]
2018-01-09 6:15 ` [dts] [PATCH] " Phil Yang
2018-01-09 6:43 ` Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A54BF41.9010203@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=nd@arm.com \
--cc=phil.yang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).