From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 01C8D7D19 for ; Tue, 9 Jan 2018 06:19:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 21:19:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,334,1511856000"; d="scan'208";a="8922252" Received: from dpdk-test32.sh.intel.com (HELO [10.67.119.109]) ([10.67.119.109]) by orsmga007.jf.intel.com with ESMTP; 08 Jan 2018 21:19:08 -0800 Message-ID: <5A54BF41.9010203@intel.com> Date: Tue, 09 Jan 2018 21:10:25 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Phil Yang , dts@dpdk.org CC: nd@arm.com References: <1515148140-28422-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1515148140-28422-1-git-send-email-phil.yang@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH] tests/vhost_user_live_migration: Optimize for multi-platform. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 05:19:11 -0000 Phil, There's one comment as below. On 01/05/2018 06:29 PM, Phil Yang wrote: > + > + dirct_pat = re.compile(r"(\s+)\[ (\S+) in\|out\|inout \]") > + vm_dut.send_expect("tcpdump -h", "# ") > + out = vm_dut.get_session_output(timeout=1) > + m = dirct_pat.search(out) > + if m: > + dirct_para = "-" + m.group(2)[1] + " in" > + else: > + dirct_para = "" > + Please change variable name to more meaning full name "direct_param". Thanks, Marvin