From: "Liu, Yong" <yong.liu@intel.com>
To: "zhao,meijuan" <meijuanx.zhao@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/vf_kernel:change regex about packet statistic
Date: Tue, 09 Jan 2018 21:21:52 +0800 [thread overview]
Message-ID: <5A54C1F0.1060508@intel.com> (raw)
In-Reply-To: <1515119919-4605-1-git-send-email-meijuanx.zhao@intel.com>
Meijuan,
Please also add one sample output in the commit log. Others can have
clear mind about what's your change for based on the sample.
Thanks,
Marvin
On 01/05/2018 10:38 AM, zhao,meijuan wrote:
> regex match packet statistic fail
>
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
> tests/TestSuite_vf_kernel.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
> index 204467d..ed680e2 100644
> --- a/tests/TestSuite_vf_kernel.py
> +++ b/tests/TestSuite_vf_kernel.py
> @@ -447,7 +447,7 @@ class TestVfKernel(TestCase):
> """
> time.sleep(10)
> out = self.vm0_dut.send_expect("ethtool -S %s" % self.vm0_intf0, "#")
> - rx_packets_before = re.findall("\s*rx.*packets:\s*(\d*)", out)
> + rx_packets_before = re.findall("\s*rx.*\d+.*packets:\s*(\d*)", out)
> nb_rx_pkts_before = 0
> for i in range(len(rx_packets_before)):
> nb_rx_pkts_before += int(rx_packets_before[i])
> @@ -457,7 +457,7 @@ class TestVfKernel(TestCase):
> vm0_vf0_mac, num=10), "VM reveive packet failed")
>
> out = self.vm0_dut.send_expect("ethtool -S %s" % self.vm0_intf0, "#")
> - rx_packets_after = re.findall("\s*rx.*packets:\s*(\d*)", out)
> + rx_packets_after = re.findall("\s*rx.*\d+.*packets:\s*(\d*)", out)
> nb_rx_pkts_after = 0
> for i in range(len(rx_packets_after)):
> nb_rx_pkts_after += int(rx_packets_after[i])
next prev parent reply other threads:[~2018-01-09 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 2:38 zhao,meijuan
2018-01-09 13:21 ` Liu, Yong [this message]
2018-01-09 7:16 [dts] [PATCH V1] tests/vf_kernel: change " zhao,meijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A54C1F0.1060508@intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=meijuanx.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).