test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] fix vf_kernel alt_session as false
@ 2018-01-15  2:05 zhao,meijuan
  2018-01-16 15:06 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: zhao,meijuan @ 2018-01-15  2:05 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

in test_zdpf_2kvf_2dvf_2vm,test_dpf_kvf_dvf,testpmd session and host session are in a session because of alt_session is false

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_kernel.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
index 204467d..987ee19 100644
--- a/tests/TestSuite_vf_kernel.py
+++ b/tests/TestSuite_vf_kernel.py
@@ -688,6 +688,8 @@ class TestVfKernel(TestCase):
         self.vm0_dut.send_expect("ifconfig %s up " % self.vm0_intf0, "#")
         self.vm0_dut.send_expect("ifconfig %s up " % self.vm0_intf1, "#")
         self.vm0_dut.ports_info[1]['port'].bind_driver('igb_uio')
+   
+        vm0_vf0_mac = self.vm0_dut.ports_info[0]['port'].get_mac_addr()
 
         self.vm0_testpmd.start_testpmd("Default")
         self.vm0_testpmd.execute_cmd('set promisc all on')
@@ -695,7 +697,6 @@ class TestVfKernel(TestCase):
         self.vm0_testpmd.execute_cmd('set verbose 1')
         self.vm0_testpmd.execute_cmd('start')
 
-        vm0_vf0_mac = self.vm0_dut.ports_info[0]['port'].get_mac_addr()
         vm0_vf1_mac = self.vm0_testpmd.get_port_mac(0)
 
         macs = [vm0_vf0_mac, vm0_vf1_mac]
@@ -775,6 +776,10 @@ class TestVfKernel(TestCase):
         self.vm0_dut.ports_info[1]['port'].bind_driver('igb_uio')
         self.vm1_dut.ports_info[0]['port'].bind_driver('igb_uio')
 
+        vm0_vf2_mac = self.vm0_dut.ports_info[2]['port'].get_mac_addr()
+        vm0_vf3_mac = self.vm0_dut.ports_info[3]['port'].get_mac_addr()
+        vm1_vf1_mac = self.vm1_dut.ports_info[1]['port'].get_mac_addr()
+
         # Start DPDK VF0, VF1 in VM0 and VF4 in VM1, enable promisc mode
         self.vm0_testpmd.start_testpmd("Default")
         self.vm0_testpmd.execute_cmd('set promisc all on')
@@ -790,10 +795,7 @@ class TestVfKernel(TestCase):
 
         vm0_vf0_mac = self.vm0_testpmd.get_port_mac(0)
         vm0_vf1_mac = self.vm0_testpmd.get_port_mac(1)
-        vm0_vf2_mac = self.vm0_dut.ports_info[2]['port'].get_mac_addr()
-        vm0_vf3_mac = self.vm0_dut.ports_info[3]['port'].get_mac_addr()
         vm1_vf0_mac = self.vm1_testpmd.get_port_mac(0)
-        vm1_vf1_mac = self.vm1_dut.ports_info[1]['port'].get_mac_addr()
         pf0_mac = self.dut_testpmd.get_port_mac(0)
         pf1_mac = self.dut_testpmd.get_port_mac(1)
 
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] fix vf_kernel alt_session as false
  2018-01-15  2:05 [dts] [PATCH V1] fix vf_kernel alt_session as false zhao,meijuan
@ 2018-01-16 15:06 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-01-16 15:06 UTC (permalink / raw)
  To: zhao,meijuan, dts

Hi Meijuan,
Please also add one line comment in the code as the reminder for others.

Thanks,
Marvin

On 01/15/2018 10:05 AM, zhao,meijuan wrote:
> in test_zdpf_2kvf_2dvf_2vm,test_dpf_kvf_dvf,testpmd session and host session are in a session because of alt_session is false
>
> Signed-off-by: zhao,meijuan<meijuanx.zhao@intel.com>
> ---
>   tests/TestSuite_vf_kernel.py | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
> index 204467d..987ee19 100644
> --- a/tests/TestSuite_vf_kernel.py
> +++ b/tests/TestSuite_vf_kernel.py
> @@ -688,6 +688,8 @@ class TestVfKernel(TestCase):
>           self.vm0_dut.send_expect("ifconfig %s up " % self.vm0_intf0, "#")
>           self.vm0_dut.send_expect("ifconfig %s up " % self.vm0_intf1, "#")
>           self.vm0_dut.ports_info[1]['port'].bind_driver('igb_uio')
> +
> +        vm0_vf0_mac = self.vm0_dut.ports_info[0]['port'].get_mac_addr()
>   

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-16  7:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15  2:05 [dts] [PATCH V1] fix vf_kernel alt_session as false zhao,meijuan
2018-01-16 15:06 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).