[dts] [PATCH v1 0/3] Change "tx-offloads" configuration

[dts] [PATCH v1 0/3] Change "tx-offloads" configuration

[Lijuan Tu]

Current framework will enable all offloads ,but in some NIC don't support
all of them. Remove this setting from framework , and handle it in case 
script.

In our NICs ,jumboframe need enable multi segment send

Lijuan Tu (3):
  framework: Remove option "tx--offloads"
  tests: reset "tx-offloads" to defualt
  jumboframe & vf_jumboframe: set tx offloads

 framework/pmd_output.py                             |  3 ---
 tests/TestSuite_fortville_rss_granularity_config.py | 12 ++++++------
 tests/TestSuite_ipgre.py                            |  4 ++--
 tests/TestSuite_jumboframes.py                      | 10 +++++-----
 tests/TestSuite_nvgre.py                            |  8 ++++----
 tests/TestSuite_pmdrss_hash.py                      |  2 +-
 tests/TestSuite_qinq_filter.py                      | 16 ++++++++--------
 tests/TestSuite_sriov_kvm.py                        |  2 +-
 tests/TestSuite_tso.py                              |  6 +++---
 tests/TestSuite_uni_pkt.py                          |  2 +-
 tests/TestSuite_vf_jumboframe.py                    | 10 +++++-----
 tests/TestSuite_vf_offload.py                       |  4 ++--
 tests/TestSuite_vxlan.py                            | 20 ++++++++++----------
 13 files changed, 48 insertions(+), 51 deletions(-)

-- 
1.8.3.1

[dts] [PATCH v1 1/3] framework: Remove option "tx--offloads"

[Lijuan Tu]

Remove tx-offload configuration , use dpdk default.
"tx-offloads" no longer handled by framework but case by case.
if offload needed by a feature, it should be handled by itself.

Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
 framework/pmd_output.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index 0c1dfc6..aa9384d 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -101,9 +101,6 @@ class PmdOutput():
         return self.command
 
     def start_testpmd(self, cores, param='', eal_param='', socket=0):
-        # in dpdk18.02 need used --tx-offloads param to open hardware features
-        if "--tx-offloads" not in param:
-            param += " --tx-offloads=0x8fff"
 
         if type(cores) == list:
             core_list = cores
-- 
1.8.3.1

[dts] [PATCH v1 2/3] tests: reset "tx-offloads" to defualt

[Lijuan Tu]

No specific tx offloads need to be set.
remove the option ,use dpdk default value.

Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
 tests/TestSuite_fortville_rss_granularity_config.py | 12 ++++++------
 tests/TestSuite_ipgre.py                            |  4 ++--
 tests/TestSuite_nvgre.py                            |  8 ++++----
 tests/TestSuite_pmdrss_hash.py                      |  2 +-
 tests/TestSuite_qinq_filter.py                      | 16 ++++++++--------
 tests/TestSuite_sriov_kvm.py                        |  2 +-
 tests/TestSuite_tso.py                              |  6 +++---
 tests/TestSuite_uni_pkt.py                          |  2 +-
 tests/TestSuite_vf_offload.py                       |  4 ++--
 tests/TestSuite_vxlan.py                            | 20 ++++++++++----------
 10 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/tests/TestSuite_fortville_rss_granularity_config.py b/tests/TestSuite_fortville_rss_granularity_config.py
index c86a20f..58ae0ef 100644
--- a/tests/TestSuite_fortville_rss_granularity_config.py
+++ b/tests/TestSuite_fortville_rss_granularity_config.py
@@ -202,7 +202,7 @@ class TestFortvilleRssGranularityConfig(TestCase):
         # test with different rss queues
         for queue in testQueues:
             self.dut.send_expect(
-                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d --tx-offloads=0x8fff" %
+                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d" %
                 (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
             self.dut.send_expect("set verbose 8", "testpmd> ")
@@ -278,7 +278,7 @@ class TestFortvilleRssGranularityConfig(TestCase):
         # test with different rss queues
         for queue in testQueues:
             self.dut.send_expect(
-                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d --tx-offloads=0x8fff" %
+                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d" %
                 (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
             self.dut.send_expect("set verbose 8", "testpmd> ")
@@ -355,7 +355,7 @@ class TestFortvilleRssGranularityConfig(TestCase):
         # test with different rss queues
         for queue in testQueues:
             self.dut.send_expect(
-                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d --tx-offloads=0x8fff" %
+                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d" %
                 (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
             self.dut.send_expect("set verbose 8", "testpmd> ")
@@ -432,7 +432,7 @@ class TestFortvilleRssGranularityConfig(TestCase):
         # test with different rss queues
         for queue in testQueues:
             self.dut.send_expect(
-                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d --tx-offloads=0x8fff" %
+                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d" %
                 (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
             self.dut.send_expect("set verbose 8", "testpmd> ")
@@ -509,7 +509,7 @@ class TestFortvilleRssGranularityConfig(TestCase):
         # test with different rss queues
         for queue in testQueues:
             self.dut.send_expect(
-                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d --tx-offloads=0x8fff" %
+                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d" %
                 (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
             self.dut.send_expect("set verbose 8", "testpmd> ")
@@ -570,7 +570,7 @@ class TestFortvilleRssGranularityConfig(TestCase):
         # test with different rss queues
         for queue in testQueues:
             self.dut.send_expect(
-                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d --tx-offloads=0x8fff" %
+                "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --portmask=0x3 --rxq=%d --txq=%d" %
                 (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
             self.dut.send_expect("set verbose 8", "testpmd> ")
diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index c1d052e..91f9469 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -263,7 +263,7 @@ class TestIpgre(TestCase):
         inner_mac = "10:00:00:00:00:00"
         
         # Start testpmd with multi queues
-        #testpmd_cmd = "./%s/app/testpmd -c ff -n 3 -- -i  --rxq=4 --txq=4 --tx-offloads=0x8fff" % self.target
+        #testpmd_cmd = "./%s/app/testpmd -c ff -n 3 -- -i  --rxq=4 --txq=4" % self.target
         testpmd_cmd = "./%s/app/testpmd -c ff -n 3 -- -i --enable-rx-cksum  --rxq=4 --txq=4" % self.target
         self.dut.send_expect(testpmd_cmd, "testpmd>", 20)
         self.dut.send_expect("set fwd rxonly", "testpmd>")
@@ -307,7 +307,7 @@ class TestIpgre(TestCase):
         Send packet with wrong IP/TCP/UDP/SCTP checksum and check forwarded packet checksum 
         """
         # Start testpmd and enable rxonly forwarding mode
-        testpmd_cmd = "./%s/app/testpmd -c ff -n 3 -- -i --enable-rx-cksum --tx-offloads=0x8fff --port-topology=loop" % self.target
+        testpmd_cmd = "./%s/app/testpmd -c ff -n 3 -- -i --enable-rx-cksum --port-topology=loop" % self.target
         self.dut.send_expect(testpmd_cmd, "testpmd>", 20)
         self.dut.send_expect("set verbose 1", "testpmd>")
         self.dut.send_expect("set fwd csum", "testpmd>")
diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py
index 4cb3e8f..d64c3cb 100644
--- a/tests/TestSuite_nvgre.py
+++ b/tests/TestSuite_nvgre.py
@@ -438,7 +438,7 @@ class TestNvgre(TestCase):
         """
         send nvgre packet and check whether testpmd detect the correct packet type
         """
-        out = self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=4 --portmask=%s --tx-offloads=0x8fff"
+        out = self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=4 --portmask=%s"
                                    % (self.target, self.coremask, self.dut.get_memory_channels(), self.portmask), "testpmd>", 30)
         out = self.dut.send_expect("set fwd rxonly", "testpmd>", 10)
         self.dut.send_expect("set verbose 1", "testpmd>", 10)
@@ -467,7 +467,7 @@ class TestNvgre(TestCase):
         """
         send nvgre packet and check whether receive packet in assigned queue
         """
-        self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=4 --portmask=%s --tx-offloads=0x8fff"
+        self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=4 --portmask=%s"
                              % (self.target, self.coremask, self.dut.get_memory_channels(), self.portmask), "testpmd>", 30)
         self.dut.send_expect("set fwd rxonly", "testpmd>", 10)
         self.dut.send_expect("set verbose 1", "testpmd>", 10)
@@ -543,7 +543,7 @@ class TestNvgre(TestCase):
         self.logger.info("chksums_ref:" + str(chksums_default))
 
         # start testpmd with 2queue/1port
-        out = self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=4 --portmask=%s --enable-rx-cksum --tx-offloads=0x8fff"
+        out = self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=4 --portmask=%s --enable-rx-cksum"
                                    % (self.target, self.coremask, self.dut.get_memory_channels(), self.portmask), "testpmd>", 30)
         # disable vlan filter
         self.dut.send_expect('vlan set filter off %d' % self.dut_rx_port, "testpmd")
@@ -664,7 +664,7 @@ class TestNvgre(TestCase):
         self.nvgre_filter(filter_type="imac", remove=True)
         config = NvgreTestConfig(self)
         # config.outer_mac_dst = self.dut_port_mac
-        self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=4 --portmask=%s --tx-offloads=0x8fff"
+        self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=4 --portmask=%s"
                              % (self.target, self.coremask, self.dut.get_memory_channels(), self.portmask), "testpmd>", 30)
         out = self.dut.send_expect("tunnel_filter add %d %s %s %s %d nvgre %s %d %d"
                                    % (self.dut_rx_port, config.outer_mac_dst, self.invalid_mac, config.inner_ip_dst, vlan_id,
diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
index 227caaf..78e4075 100644
--- a/tests/TestSuite_pmdrss_hash.py
+++ b/tests/TestSuite_pmdrss_hash.py
@@ -655,7 +655,7 @@ class TestPmdrssHash(TestCase):
     def test_dynamic_rss_bond_config(self):
         
         # setup testpmd and finish bond config
-        self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i --tx-offloads=0x8fff" % self.target, "testpmd> ", 120)
+        self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i" % self.target, "testpmd> ", 120)
         out = self.dut.send_expect("create bonded device 3 0", "testpmd> ", 30)
         bond_device_id = int(re.search("port \d+", out).group().split(" ")[-1].strip())
 
diff --git a/tests/TestSuite_qinq_filter.py b/tests/TestSuite_qinq_filter.py
index ad3e7ea..3f9c1ac 100644
--- a/tests/TestSuite_qinq_filter.py
+++ b/tests/TestSuite_qinq_filter.py
@@ -147,7 +147,7 @@ class TestQinqFilter(TestCase):
         
         self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \
                                --portmask=%s --port-topology=loop \
-                               --rxq=4 --txq=4 --tx-offloads=0x8fff  --disable-rss' % (self.target, self.coreMask, self.portMask),
+                               --rxq=4 --txq=4  --disable-rss' % (self.target, self.coreMask, self.portMask),
                                "testpmd> ")
         self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, "testpmd> ")
         self.dut.send_expect("set fwd rxonly", "testpmd> ")
@@ -167,7 +167,7 @@ class TestQinqFilter(TestCase):
         """
         self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \
                                --portmask=%s --port-topology=loop \
-                               --rxq=4 --txq=4 --tx-offloads=0x8fff  --disable-rss' % (self.target, self.coreMask, self.portMask),
+                               --rxq=4 --txq=4  --disable-rss' % (self.target, self.coreMask, self.portMask),
                                "testpmd> ")
         self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, "testpmd> ")
         self.dut.send_expect("set fwd rxonly", "testpmd> ")
@@ -203,7 +203,7 @@ class TestQinqFilter(TestCase):
 
         self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4  \
                                --socket-mem=1024,1024 --file-prefix=pf -w %s -- -i --port-topology=loop \
-                               --rxq=4 --txq=4 --tx-offloads=0x8fff  --disable-rss' 
+                               --rxq=4 --txq=4  --disable-rss' 
                                % (self.target, self.coreMask, self.dut.ports_info[dutRxPortId]['pci']),
                                "testpmd> ")
         self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, "testpmd> ")
@@ -220,13 +220,13 @@ class TestQinqFilter(TestCase):
 
         vf0_session.send_expect(r'./%s/app/testpmd -c %s -n 4  \
                                --socket-mem=1024,1024 --file-prefix=vf0 -w %s -- -i --port-topology=loop \
-                               --rxq=4 --txq=4 --tx-offloads=0x8fff  --disable-rss' 
+                               --rxq=4 --txq=4  --disable-rss' 
                                % (self.target, self.coreMask, vf_list[0]),
                                "testpmd> ")
                                                               
         vf1_session.send_expect(r'./%s/app/testpmd -c %s -n 4 \
                                --socket-mem=1024,1024 --file-prefix=vf1 -w %s -- -i --port-topology=loop \
-                               --rxq=4 --txq=4 --tx-offloads=0x8fff  --disable-rss' 
+                               --rxq=4 --txq=4  --disable-rss' 
                                % (self.target, self.coreMask, vf_list[1]),
                                "testpmd>") 
         for session_name in [vf0_session, vf1_session]:
@@ -272,7 +272,7 @@ class TestQinqFilter(TestCase):
 
         self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 \
                                --socket-mem=1024,1024 --file-prefix=pf -w %s -- -i --port-topology=loop \
-                               --rxq=4 --txq=4 --tx-offloads=0x8fff  --disable-rss' 
+                               --rxq=4 --txq=4  --disable-rss' 
                                % (self.target, self.coreMask, self.dut.ports_info[dutRxPortId]['pci']),
                                "testpmd> ")
         self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, "testpmd> ")
@@ -292,13 +292,13 @@ class TestQinqFilter(TestCase):
         
         vf0_session.send_expect(r'./%s/app/testpmd -c %s -n 4 \
                                --socket-mem=1024,1024 --file-prefix=vf0 -w %s -- -i --port-topology=loop \
-                               --rxq=4 --txq=4 --tx-offloads=0x8fff  --disable-rss' 
+                               --rxq=4 --txq=4  --disable-rss' 
                                % (self.target, self.coreMask, vf_list[0]),
                                "testpmd> ")
                                                               
         vf1_session.send_expect(r'./%s/app/testpmd -c %s -n 4 \
                                --socket-mem=1024,1024 --file-prefix=vf1 -w %s -- -i --port-topology=loop \
-                               --rxq=4 --txq=4 --tx-offloads=0x8fff  --disable-rss' 
+                               --rxq=4 --txq=4  --disable-rss' 
                                % (self.target, self.coreMask, vf_list[1]),
                                "testpmd>") 
         for session_name in [vf0_session, vf1_session]:
diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
index bcf4ed8..ae97bef 100644
--- a/tests/TestSuite_sriov_kvm.py
+++ b/tests/TestSuite_sriov_kvm.py
@@ -350,7 +350,7 @@ class TestSriovKvm(TestCase):
                 eal_param = '-b %(vf0)s -b %(vf1)s' % {'vf0': self.sriov_vfs_port[0].pci,
                                                        'vf1': self.sriov_vfs_port[1].pci}
                 self.host_testpmd.start_testpmd(
-                    "1S/2C/2T", "--rxq=4 --txq=4 --tx-offloads=0x8fff", eal_param=eal_param)
+                    "1S/2C/2T", "--rxq=4 --txq=4", eal_param=eal_param)
                 self.host_testpmd.execute_cmd('set fwd rxonly')
                 self.host_testpmd.execute_cmd('start')
 
diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py
index 25b37a3..0a9d66c 100644
--- a/tests/TestSuite_tso.py
+++ b/tests/TestSuite_tso.py
@@ -157,7 +157,7 @@ class TestTSO(TestCase):
         self.tester.send_expect("ethtool -K %s rx off tx off tso off gso off gro off lro off" % tx_interface, "# ")
         self.tester.send_expect("ip l set %s up" % tx_interface, "# ")
 
-        cmd = "./%s/app/testpmd -c %s -n %d %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 --tx-offloads=0x8fff " % (self.target, self.coreMask, self.dut.get_memory_channels(), self.blacklist, self.portMask)
+        cmd = "./%s/app/testpmd -c %s -n %d %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.target, self.coreMask, self.dut.get_memory_channels(), self.blacklist, self.portMask)
         self.dut.send_expect(cmd, "testpmd> ", 120)
         self.dut.send_expect("set verbose 1", "testpmd> ", 120)
         self.dut.send_expect("csum set ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
@@ -223,7 +223,7 @@ class TestTSO(TestCase):
         self.tester.send_expect("ethtool -K %s rx off tx off tso off gso off gro off lro off" % tx_interface, "# ")
         self.tester.send_expect("ip l set %s up" % tx_interface, "# ")
 
-        cmd = "./%s/app/testpmd -c %s -n %d %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 --tx-offloads=0x8fff " % (self.target, self.coreMask, self.dut.get_memory_channels(), self.blacklist, self.portMask)
+        cmd = "./%s/app/testpmd -c %s -n %d %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.target, self.coreMask, self.dut.get_memory_channels(), self.blacklist, self.portMask)
         self.dut.send_expect(cmd, "testpmd> ", 120)
         self.dut.send_expect("set verbose 1", "testpmd> ", 120)
         self.dut.send_expect("csum set ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
@@ -287,7 +287,7 @@ class TestTSO(TestCase):
             else:
                 queues = 1
 
-            command_line = "./%s/app/testpmd -c %s -n %d %s -- -i --coremask=%s --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 --tx-offloads=0x8fff " % (self.target, self.all_cores_mask, self.dut.get_memory_channels(), self.blacklist, self.coreMask, self.portMask)
+            command_line = "./%s/app/testpmd -c %s -n %d %s -- -i --coremask=%s --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.target, self.all_cores_mask, self.dut.get_memory_channels(), self.blacklist, self.coreMask, self.portMask)
 
             info = "Executing PMD using %s\n" % test_cycle['cores']
             self.logger.info(info)
diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
index 945a51e..e11b482 100644
--- a/tests/TestSuite_uni_pkt.py
+++ b/tests/TestSuite_uni_pkt.py
@@ -64,7 +64,7 @@ class TestUniPacket(TestCase):
         tester_port = self.tester.get_local_port(self.dut_port)
         self.tester_iface = self.tester.get_interface(tester_port)
         self.dut.send_expect(
-            "./%s/app/testpmd -c f -n 4 -- -i --tx-offloads=0x8fff" % self.target, "testpmd>", 20)
+            "./%s/app/testpmd -c f -n 4 -- -i" % self.target, "testpmd>", 20)
         self.dut.send_expect("set fwd rxonly", "testpmd>")
         self.dut.send_expect("set verbose 1", "testpmd>")
         self.dut.send_expect("start", "testpmd>")
diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index 020207c..2dfc424 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -206,7 +206,7 @@ class TestVfOffload(TestCase):
         verify forwarded packets have correct checksum
         """
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=%s " %
-                                      (self.portMask) + "--disable-hw-vlan --enable-rx-cksum " + "--tx-offloads=0x8fff " +
+                                      (self.portMask) + "--disable-hw-vlan --enable-rx-cksum " + "" +
                                       "--port-topology=loop")
         self.vm0_testpmd.execute_cmd('set fwd csum')
 
@@ -348,7 +348,7 @@ class TestVfOffload(TestCase):
         self.portMask = utils.create_mask([self.vm0_dut_ports[0]])
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=%s " %
                                       (self.portMask) + "--enable-rx-cksum " +
-                                      "--tx-offloads=0x8fff " + 
+                                      "" + 
                                       "--port-topology=loop")
 
         mac = self.vm0_testpmd.get_port_mac(0)
diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index fe24b7e..2e971d1 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -547,7 +547,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
         
         pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
             "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" + \
-            " --nb-cores=4 --portmask=%(PORT)s --tx-offloads=0x8fff"
+            " --nb-cores=4 --portmask=%(PORT)s"
         pmd_cmd = pmd_temp % {'TARGET': self.target,
                               'COREMASK': self.coremask,
                               'CHANNEL': self.dut.get_memory_channels(),
@@ -597,7 +597,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
 
         pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
             "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" + \
-            " --nb-cores=4 --portmask=%(PORT)s --tx-offloads=0x8fff"
+            " --nb-cores=4 --portmask=%(PORT)s"
         pmd_cmd = pmd_temp % {'TARGET': self.target,
                               'COREMASK': self.coremask,
                               'CHANNEL': self.dut.get_memory_channels(),
@@ -644,7 +644,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
         # start testpmd with 2queue/1port
         pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
             "%(CHANNEL)d -- -i --portmask=%(PORT)s " + \
-            "--tx-offloads=0x8fff --enable-rx-cksum"
+            "--enable-rx-cksum"
         pmd_cmd = pmd_temp % {'TARGET': self.target,
                               'COREMASK': self.coremask,
                               'CHANNEL': self.dut.get_memory_channels(),
@@ -717,7 +717,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
         # start testpmd with 2queue/1port
         pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
             "%(CHANNEL)d -- -i --portmask=%(PORT)s " + \
-            "--tx-offloads=0x8fff --enable-rx-cksum"
+            "--enable-rx-cksum"
         pmd_cmd = pmd_temp % {'TARGET': self.target,
                               'COREMASK': self.coremask,
                               'CHANNEL': self.dut.get_memory_channels(),
@@ -792,7 +792,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
         """
         pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
             "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" + \
-            " --nb-cores=4 --portmask=%(PORT)s --tx-offloads=0x8fff"
+            " --nb-cores=4 --portmask=%(PORT)s"
         pmd_cmd = pmd_temp % {'TARGET': self.target,
                               'COREMASK': self.coremask,
                               'CHANNEL': self.dut.get_memory_channels(),
@@ -833,7 +833,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
 
         pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
             "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" + \
-            " --nb-cores=4 --portmask=%(PORT)s --tx-offloads=0x8fff"
+            " --nb-cores=4 --portmask=%(PORT)s"
         pmd_cmd = pmd_temp % {'TARGET': self.target,
                               'COREMASK': self.coremask,
                               'CHANNEL': self.dut.get_memory_channels(),
@@ -962,7 +962,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
 
         pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
             "%(CHANNEL)d -- -i --disable-rss --rxq=2 --txq=2" + \
-            " --nb-cores=4 --portmask=%(PORT)s --tx-offloads=0x8fff"
+            " --nb-cores=4 --portmask=%(PORT)s"
 
         for perf_config in self.tunnel_perf:
             tun_filter = perf_config['tunnel_filter']
@@ -973,7 +973,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
             if tun_filter == "None" and recv_queue == "Multi":
                 pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
                     "%(CHANNEL)d -- -i --rss-udp --rxq=2 --txq=2" + \
-                    " --nb-cores=4 --portmask=%(PORT)s --tx-offloads=0x8fff"
+                    " --nb-cores=4 --portmask=%(PORT)s"
 
             pmd_cmd = pmd_temp % {'TARGET': self.target,
                                   'COREMASK': core_mask,
@@ -1074,11 +1074,11 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
             if recv_queue == 'Multi':
                 pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
                     "%(CHANNEL)d -- -i --disable-rss --rxq=2 --txq=2" + \
-                    " --nb-cores=4 --portmask=%(PORT)s --tx-offloads=0x8fff"
+                    " --nb-cores=4 --portmask=%(PORT)s"
             else:
                 pmd_temp = "./%(TARGET)s/app/testpmd -c %(COREMASK)s -n " + \
                     "%(CHANNEL)d -- -i --nb-cores=2 --portmask=%(PORT)s" + \
-                    " --tx-offloads=0x8fff"
+                    ""
 
             pmd_cmd = pmd_temp % {'TARGET': self.target,
                                   'COREMASK': core_mask,
-- 
1.8.3.1

[dts] [PATCH v1 3/3] jumboframe & vf_jumboframe: set tx offloads

[Lijuan Tu]

to test jumboframe, you need enable multi segment send.
define DEV_TX_OFFLOAD_MULTI_SEGS       0x00008000
/**< Device supports multi segment send. */

Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
 tests/TestSuite_jumboframes.py   | 10 +++++-----
 tests/TestSuite_vf_jumboframe.py | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_jumboframes.py b/tests/TestSuite_jumboframes.py
index bc6e70d..0038c1b 100644
--- a/tests/TestSuite_jumboframes.py
+++ b/tests/TestSuite_jumboframes.py
@@ -144,7 +144,7 @@ class TestJumboframes(TestCase):
         This case aims to test transmitting normal size packet without jumbo
         f=rame on testpmd app.
         """
-        self.pmdout.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop" % (ETHER_STANDARD_MTU))
+        self.pmdout.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_STANDARD_MTU))
         self.dut.send_expect("set fwd mac", "testpmd> ")
         self.dut.send_expect("start", "testpmd> ")
 
@@ -163,7 +163,7 @@ class TestJumboframes(TestCase):
         if self.kdriver == "fm10k":
             print utils.RED("fm10k not support this case\n")
             return
-        self.pmdout.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop" % (ETHER_STANDARD_MTU))
+        self.pmdout.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_STANDARD_MTU))
         self.dut.send_expect("set fwd mac", "testpmd> ")
         self.dut.send_expect("start", "testpmd> ")
 
@@ -177,7 +177,7 @@ class TestJumboframes(TestCase):
         When jumbo frame supported, this case is to verify that the normal size
         packet forwrding should be support correct.
         """
-        self.pmdout.start_testpmd("Default", "--max-pkt-len=%s --port-topology=loop" % (ETHER_JUMBO_FRAME_MTU))
+        self.pmdout.start_testpmd("Default", "--max-pkt-len=%s --port-topology=loop --tx-offloads=0x8000" % (ETHER_JUMBO_FRAME_MTU))
         self.dut.send_expect("set fwd mac", "testpmd> ")
         self.dut.send_expect("start", "testpmd> ")
 
@@ -192,7 +192,7 @@ class TestJumboframes(TestCase):
         When jumbo frame supported, this case is to verify that jumbo frame
         packet can be forwarded correct.
         """
-        self.pmdout.start_testpmd("Default", "--max-pkt-len=%s --port-topology=loop" % (ETHER_JUMBO_FRAME_MTU))
+        self.pmdout.start_testpmd("Default", "--max-pkt-len=%s --port-topology=loop --tx-offloads=0x8000" % (ETHER_JUMBO_FRAME_MTU))
         self.dut.send_expect("set fwd mac", "testpmd> ")
         self.dut.send_expect("start", "testpmd> ")
 
@@ -208,7 +208,7 @@ class TestJumboframes(TestCase):
         When the jubmo frame MTU set as 9000, this case is to verify that the
         packet which the length bigger than MTU can not be forwarded.
         """
-        self.pmdout.start_testpmd("Default", "--max-pkt-len=%s --port-topology=loop" % (ETHER_JUMBO_FRAME_MTU))
+        self.pmdout.start_testpmd("Default", "--max-pkt-len=%s --port-topology=loop --tx-offloads=0x8000" % (ETHER_JUMBO_FRAME_MTU))
         self.dut.send_expect("set fwd mac", "testpmd> ")
         self.dut.send_expect("start", "testpmd> ")
         
diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index b711751..78a43cd 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -209,7 +209,7 @@ class TestVfJumboFrame(TestCase):
         self.dutobj = self.dut.ports_info[self.port]['port']
         self.dutobj.enable_jumbo(framesize=ETHER_STANDARD_MTU)
 
-        self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8fff" % (ETHER_STANDARD_MTU))
+        self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_STANDARD_MTU))
 
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("start")
@@ -229,7 +229,7 @@ class TestVfJumboFrame(TestCase):
         self.dutobj = self.dut.ports_info[self.port]['port']
         self.dutobj.enable_jumbo(framesize=ETHER_JUMBO_FRAME_MTU)
 
-        self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8fff" % (ETHER_JUMBO_FRAME_MTU))
+        self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_JUMBO_FRAME_MTU))
 
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("start")
@@ -249,7 +249,7 @@ class TestVfJumboFrame(TestCase):
         self.dutobj = self.dut.ports_info[self.port]['port']
         self.dutobj.enable_jumbo(framesize=ETHER_STANDARD_MTU)
 
-        self.vm_testpmd.start_testpmd("Default", "--port-topology=loop --tx-offloads=0x8fff" )
+        self.vm_testpmd.start_testpmd("Default", "--port-topology=loop --tx-offloads=0x8000" )
 
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("start")
@@ -277,7 +277,7 @@ class TestVfJumboFrame(TestCase):
         self.dutobj = self.dut.ports_info[self.port]['port']
         self.dutobj.enable_jumbo(framesize=ETHER_JUMBO_FRAME_MTU)
 
-        self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8fff" % (ETHER_JUMBO_FRAME_MTU))
+        self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_JUMBO_FRAME_MTU))
 
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("start")
@@ -298,7 +298,7 @@ class TestVfJumboFrame(TestCase):
         self.dutobj = self.dut.ports_info[self.port]['port']
         self.dutobj.enable_jumbo(framesize=ETHER_JUMBO_FRAME_MTU)
 
-        self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8fff" % (ETHER_JUMBO_FRAME_MTU))
+        self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_JUMBO_FRAME_MTU))
 
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("start")
-- 
1.8.3.1

Re: [dts] [PATCH v1 0/3] Change "tx-offloads" configuration

[Liu, Yong]

Thanks, Lijuan. Applied.

On 01/25/2018 11:43 PM, Lijuan Tu wrote:
> Current framework will enable all offloads ,but in some NIC don't support
> all of them. Remove this setting from framework , and handle it in case
> script.
>
> In our NICs ,jumboframe need enable multi segment send