test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: Herbert Guan <herbert.guan@arm.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH v2] framework: add virt_type option for virt type(kvm/libvirt) selection
Date: Tue, 30 Jan 2018 00:37:04 +0800	[thread overview]
Message-ID: <5A6F4DB0.3070300@intel.com> (raw)
In-Reply-To: <1516871859-29849-1-git-send-email-herbert.guan@arm.com>

Herbert,

I  think there i’s no need to add verb in the function name. This 
function just return the object represent for virtual machine.
How about use abbr. “"VM"”? It i’s short and widely-known by everyone.

Thanks,
Marvin

On 01/25/2018 05:17 PM, Herbert Guan wrote:
> +def CreateVirt(dut, vm_name, suite_name):
> +    conf = VirtConf(CONFIG_ROOT_PATH + os.sep + suite_name + '.cfg')
> +    conf.load_virt_config(vm_name)
> +    local_conf = conf.get_virt_config()
> +    # Default virt_type is 'KVM'

  reply	other threads:[~2018-01-29  8:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09  6:00 [dts] [PATCH] " Herbert Guan
2018-01-09  6:54 ` Liu, Yong
2018-01-09  7:11   ` Herbert Guan
2018-01-25  9:17 ` [dts] [PATCH v2] " Herbert Guan
2018-01-29 16:37   ` Liu, Yong [this message]
2018-01-30  5:28 ` [dts] [PATCH v3] " Herbert Guan
2018-01-30 14:33   ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A6F4DB0.3070300@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=herbert.guan@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).