From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 228981B37C for ; Mon, 29 Jan 2018 09:45:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 00:45:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,429,1511856000"; d="scan'208";a="25532942" Received: from dpdk-test32.sh.intel.com (HELO [10.67.119.109]) ([10.67.119.109]) by fmsmga004.fm.intel.com with ESMTP; 29 Jan 2018 00:45:53 -0800 Message-ID: <5A6F4DB0.3070300@intel.com> Date: Tue, 30 Jan 2018 00:37:04 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Herbert Guan , dts@dpdk.org References: <1515477655-19201-1-git-send-email-herbert.guan@arm.com> <1516871859-29849-1-git-send-email-herbert.guan@arm.com> In-Reply-To: <1516871859-29849-1-git-send-email-herbert.guan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dts] [PATCH v2] framework: add virt_type option for virt type(kvm/libvirt) selection X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 08:45:56 -0000 Herbert, I think there i’s no need to add verb in the function name. This function just return the object represent for virtual machine. How about use abbr. “"VM"”? It i’s short and widely-known by everyone. Thanks, Marvin On 01/25/2018 05:17 PM, Herbert Guan wrote: > +def CreateVirt(dut, vm_name, suite_name): > + conf = VirtConf(CONFIG_ROOT_PATH + os.sep + suite_name + '.cfg') > + conf.load_virt_config(vm_name) > + local_conf = conf.get_virt_config() > + # Default virt_type is 'KVM'