test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed issue
@ 2018-01-30  6:43 yufengx.mo
  2018-01-30  6:43 ` [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed yufengx.mo
  0 siblings, 1 reply; 3+ messages in thread
From: yufengx.mo @ 2018-01-30  6:43 UTC (permalink / raw)
  To: dts; +Cc: yufengmx

From: yufengmx <yufengx.mo@intel.com>

*.vlan filter failed issue is caused by pmd option offload change 

yufengmx (1):
  tests/userspace_ethtool: fix test_ethtool_vlan case failed

 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed
  2018-01-30  6:43 [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed issue yufengx.mo
@ 2018-01-30  6:43 ` yufengx.mo
  2018-01-30 14:46   ` Liu, Yong
  0 siblings, 1 reply; 3+ messages in thread
From: yufengx.mo @ 2018-01-30  6:43 UTC (permalink / raw)
  To: dts; +Cc: yufengmx

From: yufengmx <yufengx.mo@intel.com>


vlan filter failed issue is caused by pmd option offload change.
'cfg_port.rxmode.hw_vlan_filter' is abandoned after the commit
008ee817dfbe133e03717a37743f115d21e1a479. change sed command content
before
cfg_port.rxmode.hw_vlan_filter=1
current
cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index a901a47..84b1f1e 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -411,7 +411,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         """
         main_file = "examples/ethtool/ethtool-app/main.c"
         # enable vlan filter
-        self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.hw_vlan_filter=1;' %s" % main_file, "# ")
+        self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER;' %s" % main_file, "# ")
 
         # build sample app
         self.build_ethtool()
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed
  2018-01-30  6:43 ` [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed yufengx.mo
@ 2018-01-30 14:46   ` Liu, Yong
  0 siblings, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2018-01-30 14:46 UTC (permalink / raw)
  To: yufengx.mo, dts

Thanks Yufen, applied.

On 01/30/2018 02:43 PM, yufengx.mo@intel.com wrote:
> From: yufengmx<yufengx.mo@intel.com>
>
>
> vlan filter failed issue is caused by pmd option offload change.
> 'cfg_port.rxmode.hw_vlan_filter' is abandoned after the commit
> 008ee817dfbe133e03717a37743f115d21e1a479. change sed command content
> before
> cfg_port.rxmode.hw_vlan_filter=1
> current
> cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER
>
> Signed-off-by: yufengmx<yufengx.mo@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-30  6:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-30  6:43 [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed issue yufengx.mo
2018-01-30  6:43 ` [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed yufengx.mo
2018-01-30 14:46   ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).