test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] fix disable-hw-vlan issue
@ 2018-02-01  9:12 xu,gang
  2018-02-02 16:12 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,gang @ 2018-02-01  9:12 UTC (permalink / raw)
  To: dts; +Cc: xu,gang

"--disable-hw-vlan" testpmd parameter are dropped now because 
the vlan rx offload are default off, instead "--enable-hw-vlan"
new parameter is added. 

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_checksum_offload.py | 2 +-
 tests/TestSuite_pmd.py              | 2 +-
 tests/TestSuite_vlan.py             | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 4183ead..2ff5c2f 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -66,7 +66,7 @@ class TestChecksumOffload(TestCase):
         Run before each test case.
         """
         self.pmdout.start_testpmd("Default", "--portmask=%s " %
-                                  (self.portMask) + "--disable-hw-vlan --enable-rx-cksum " +
+                                  (self.portMask) + " --enable-rx-cksum " +
                                   "--port-topology=loop", socket=self.ports_socket)
         self.dut.send_expect("set verbose 1", "testpmd>")
         self.dut.send_expect("set fwd csum", "testpmd>")
diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py
index a159143..f5df8d5 100644
--- a/tests/TestSuite_pmd.py
+++ b/tests/TestSuite_pmd.py
@@ -329,7 +329,7 @@ class TestPmd(TestCase,IxiaPacketGenerator):
 
         for rxfreet_value in self.rxfreet_values:
 
-            self.pmdout.start_testpmd("1S/2C/1T", "--portmask=%s --enable-rx-cksum --disable-hw-vlan --disable-rss --rxd=1024 --txd=1024 --rxfreet=%d" % ( port_mask, rxfreet_value), socket=self.ports_socket)
+            self.pmdout.start_testpmd("1S/2C/1T", "--portmask=%s --enable-rx-cksum --disable-rss --rxd=1024 --txd=1024 --rxfreet=%d" % ( port_mask, rxfreet_value), socket=self.ports_socket)
             self.dut.send_expect("set fwd csum", "testpmd> ")
             self.dut.send_expect("start", "testpmd> ")
 
diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py
index 1e2076f..0f1833b 100644
--- a/tests/TestSuite_vlan.py
+++ b/tests/TestSuite_vlan.py
@@ -151,6 +151,7 @@ class TestVlan(TestCase):
         """
         Disable receipt of VLAN packets
         """
+        self.dut.send_expect("vlan set filter on %s" % dutRxPortId, "testpmd> ")
 
         self.dut.send_expect("rx_vlan rm %d %s" % (self.vlan, dutRxPortId), "testpmd> ")
         self.dut.send_expect("start", "testpmd> ", 120)
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] fix disable-hw-vlan issue
  2018-02-01  9:12 [dts] [PATCH V1] fix disable-hw-vlan issue xu,gang
@ 2018-02-02 16:12 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-02-02 16:12 UTC (permalink / raw)
  To: xu,gang, dts

Thanks, Gang. Applied.

On 02/01/2018 05:12 PM, xu,gang wrote:
> "--disable-hw-vlan" testpmd parameter are dropped now because
> the vlan rx offload are default off, instead "--enable-hw-vlan"
> new parameter is added.
>
> Signed-off-by: xu,gang<gangx.xu@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-02  8:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-01  9:12 [dts] [PATCH V1] fix disable-hw-vlan issue xu,gang
2018-02-02 16:12 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).