test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/pmdrss_hash: set the rss type of ipv6-sctp as sctp
@ 2018-02-07 23:22 michael.luo
  2018-02-08 13:26 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: michael.luo @ 2018-02-07 23:22 UTC (permalink / raw)
  To: dts

From: Luo Gaoliang <michael.luo@intel.com>

The rss type of the flow type ipv6-sctp should be set as sctp instead of ip.
And it need to explicitly set the next header nh=132 for scapy to send ipv6
sctp packets. Otherwise, the scapy below the version 2.3.2 will send ipv6
sctp packets with unknown next header(nh=59).

Signed-off-by: Luo Gaoliang <michael.luo@intel.com>
---
 tests/TestSuite_pmdrss_hash.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
index 78e4075..728c427 100644
--- a/tests/TestSuite_pmdrss_hash.py
+++ b/tests/TestSuite_pmdrss_hash.py
@@ -133,7 +133,7 @@ class TestPmdrssHash(TestCase):
                 time.sleep(.5)
         elif tran_type == "ipv6-sctp":
             for i in range(10):
-                packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d")/SCTP(sport=1024,dport=1024,tag=1)], iface="%s")' % (
+                packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d", nh=132)/SCTP(sport=1024,dport=1024,tag=1)], iface="%s")' % (
                     mac, itf, i + 1, i + 2, itf)
                 self.tester.scapy_append(packet)
                 self.tester.scapy_execute()
@@ -326,12 +326,12 @@ class TestPmdrssHash(TestCase):
                 time.sleep(.5)
         elif tran_type == "ipv6-sctp":
             for i in range(4):
-                packet = r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d")/SCTP(sport=1024,dport=1025,tag=1)], iface="%s")' % (
+                packet = r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d", nh=132)/SCTP(sport=1024,dport=1025,tag=1)], iface="%s")' % (
                     mac, i + 1, i + 2, itf)
                 self.tester.scapy_append(packet)
                 self.tester.scapy_execute()
                 time.sleep(.5)
-                packet = r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d")/SCTP(sport=1025,dport=1024,tag=1)], iface="%s")' % (
+                packet = r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d", dst="3ffe:2501:200:3::%d", nh=132)/SCTP(sport=1025,dport=1024,tag=1)], iface="%s")' % (
                     mac, i + 2, i + 1, itf)
                 self.tester.scapy_append(packet)
                 self.tester.scapy_execute()
@@ -451,7 +451,7 @@ class TestPmdrssHash(TestCase):
                    # this hash not support in dpdk2.0
                    # 'l2_payload':'ether',
                    'ipv6-other': 'ip',
-                   'ipv6-sctp': 'ip',
+                   'ipv6-sctp': 'sctp',
                    'ipv6-udp': 'udp',
                    'ipv6-tcp': 'tcp',
                    'ipv6-frag': 'ip'
@@ -502,7 +502,7 @@ class TestPmdrssHash(TestCase):
                    # this hash not support in dpdk2.0
                    # 'l2_payload':'ether',
                    'ipv6-other': 'ip',
-                   'ipv6-sctp': 'ip',
+                   'ipv6-sctp': 'sctp',
                    'ipv6-udp': 'udp',
                    'ipv6-tcp': 'tcp',
                    'ipv6-frag': 'ip'
@@ -555,7 +555,7 @@ class TestPmdrssHash(TestCase):
                    # this hass not support in dpdk 2.0
                    # 'l2_payload':'ether',
                    'ipv6-other': 'ip',
-                   'ipv6-sctp': 'ip',
+                   'ipv6-sctp': 'sctp',
                    'ipv6-udp': 'udp',
                    'ipv6-tcp': 'tcp',
                    'ipv6-frag': 'ip'
@@ -612,7 +612,7 @@ class TestPmdrssHash(TestCase):
                    # this hash not support in dpdk2.0
                    # 'l2_payload':'ether',
                    'ipv6-other': 'ip',
-                   'ipv6-sctp': 'ip',
+                   'ipv6-sctp': 'sctp',
                    'ipv6-udp': 'udp',
                    'ipv6-tcp': 'tcp',
                    'ipv6-frag': 'ip'
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests/pmdrss_hash: set the rss type of ipv6-sctp as sctp
  2018-02-07 23:22 [dts] [PATCH] tests/pmdrss_hash: set the rss type of ipv6-sctp as sctp michael.luo
@ 2018-02-08 13:26 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-02-08 13:26 UTC (permalink / raw)
  To: michael.luo, dts

Thanks Michael, it is a nice catch. Applied into master branch.

On 02/08/2018 07:22 AM, michael.luo@intel.com wrote:
> From: Luo Gaoliang<michael.luo@intel.com>
>
> The rss type of the flow type ipv6-sctp should be set as sctp instead of ip.
> And it need to explicitly set the next header nh=132 for scapy to send ipv6
> sctp packets. Otherwise, the scapy below the version 2.3.2 will send ipv6
> sctp packets with unknown next header(nh=59).
>
> Signed-off-by: Luo Gaoliang<michael.luo@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-08  5:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-07 23:22 [dts] [PATCH] tests/pmdrss_hash: set the rss type of ipv6-sctp as sctp michael.luo
2018-02-08 13:26 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).