test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] fix csum set issue
@ 2018-02-09  8:37 xu,gang
  2018-02-11 10:11 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,gang @ 2018-02-09  8:37 UTC (permalink / raw)
  To: dts; +Cc: xu,gang

When we run command "csum set ip/udp/tcp/sctp hw $port_id", need stop port first.
And we run command "csum set ip/udp/tcp/sctp sw $port_id", need too


Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_nvgre.py | 2 ++
 tests/TestSuite_vxlan.py | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py
index d64c3cb..99b8490 100644
--- a/tests/TestSuite_nvgre.py
+++ b/tests/TestSuite_nvgre.py
@@ -551,12 +551,14 @@ class TestNvgre(TestCase):
         # enable tx checksum offload
         self.dut.send_expect("set verbose 1", "testpmd>", 10)
         self.dut.send_expect("set fwd csum", "testpmd>", 10)
+        self.dut.send_expect("port stop all", "testpmd>")
         self.dut.send_expect("csum set ip hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set udp hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set tcp hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set sctp hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set outer-ip hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum parse_tunnel on %d" % (self.dut_tx_port), "testpmd>", 10)
+        self.dut.send_expect("port start all", "testpmd>")
 
         # log the nvgre format
         arg_str = ""
diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 2e971d1..17a34d4 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -1142,14 +1142,18 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
                              "testpmd>", 10)
 
     def csum_set_type(self, proto, port):
+        self.dut.send_expect("port stop all", "testpmd>")
         out = self.dut.send_expect("csum set %s hw %d" % (proto, port),
                                    "testpmd>", 10)
+        self.dut.send_expect("port start all", "testpmd>")
         self.verify("Bad arguments" not in out, "Failed to set vxlan csum")
         self.verify("error" not in out, "Failed to set vxlan csum")
 
     def csum_set_sw(self, proto, port):
+        self.dut.send_expect("port stop all", "testpmd>")
         out = self.dut.send_expect("csum set %s sw %d" % (proto, port),
                                    "testpmd>", 10)
+        self.dut.send_expect("port start all", "testpmd>")
         self.verify("Bad arguments" not in out, "Failed to set vxlan csum")
         self.verify("error" not in out, "Failed to set vxlan csum")
 
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] fix csum set issue
  2018-02-09  8:37 [dts] [PATCH V1] fix csum set issue xu,gang
@ 2018-02-11 10:11 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-02-11 10:11 UTC (permalink / raw)
  To: xu,gang, dts

Thanks, gang. Applied.

On 02/09/2018 04:37 PM, xu,gang wrote:
> When we run command "csum set ip/udp/tcp/sctp hw $port_id", need stop port first.
> And we run command "csum set ip/udp/tcp/sctp sw $port_id", need too
>
>
> Signed-off-by: xu,gang<gangx.xu@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-11  2:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-09  8:37 [dts] [PATCH V1] fix csum set issue xu,gang
2018-02-11 10:11 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).