From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 011C21B379 for ; Sun, 11 Feb 2018 03:34:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2018 18:34:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,493,1511856000"; d="scan'208";a="33737477" Received: from dpdk-test32.sh.intel.com (HELO [10.67.119.83]) ([10.67.119.83]) by orsmga002.jf.intel.com with ESMTP; 10 Feb 2018 18:34:23 -0800 Message-ID: <5A801A04.2010306@intel.com> Date: Sun, 11 Feb 2018 18:25:08 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "zhu,shuai" , dts@dpdk.org References: <1518077048-48849-1-git-send-email-shuaix.zhu@intel.com> In-Reply-To: <1518077048-48849-1-git-send-email-shuaix.zhu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V1] tests/TestSuite_vlan_ethertype_config.py :stop port before set tx_vlan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Feb 2018 02:34:26 -0000 Thanks, Shuai. Applied. On 02/08/2018 04:04 PM, zhu,shuai wrote: > diff --git a/tests/TestSuite_vlan_ethertype_config.py b/tests/TestSuite_vlan_ethertype_config.py > index 8e6dd49..1fb30fb 100644 > --- a/tests/TestSuite_vlan_ethertype_config.py > +++ b/tests/TestSuite_vlan_ethertype_config.py > @@ -286,8 +286,12 @@ class TestVlanEthertypeConfig(TestCase): > self.dut.send_expect("vlan set outer tpid 0x%x %s" % > (tpid, dutTxPortId), "testpmd> ") > for tx_vlan in tx_vlans: > + self.dut.send_expect("stop", "testpmd>") > + self.dut.send_expect("port stop all", "testpmd> ") > self.dut.send_expect( > "tx_vlan set %s 0x%x" % (dutTxPortId, tx_vlan), "testpmd> ") > + self.dut.send_expect("port start all", "testpmd> ") > + self.dut.send_expect("start", "testpmd>") > self.start_tcpdump(self.rxItf) > self.vlan_send_packet(-1) > out = self.get_tcpdump_packet(self.rxItf) > @@ -296,8 +300,12 @@ class TestVlanEthertypeConfig(TestCase): > self.verify(str("%x" % tpid) in out, "Wrong vlan:" + str(out)) > self.verify( > str("%x" % tx_vlan) in out, "Vlan not found:" + str(out)) > + self.dut.send_expect("stop", "testpmd>") > + self.dut.send_expect("port stop all", "testpmd> ") > self.dut.send_expect( > "tx_vlan reset %s" % dutTxPortId, "testpmd> ", 30) > + self.dut.send_expect("port start all", "testpmd> ") > + self.dut.send_expect("start", "testpmd>") > self.start_tcpdump(self.rxItf) > self.vlan_send_packet(-1) > out = self.get_tcpdump_packet(self.rxItf)