test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change
@ 2021-03-11  5:50 Zhou Jun
  2021-03-11  5:57 ` Zhou, JunX W
  2021-03-15  6:32 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Zhou Jun @ 2021-03-11  5:50 UTC (permalink / raw)
  To: dts; +Cc: Zhou Jun

v1: modify dts for adapt DPDK bad UDP checksum change from PKT_RX_L4_CKSUM_BAD 
     to PKT_RX_L4_CKSUM_UNKNOWN 

v2: add DPDK change UDP checksum version: 21.02 rc3

Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
---
 tests/TestSuite_checksum_offload.py | 7 ++-----
 tests/TestSuite_rxtx_offload.py     | 5 +----
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 37bb4ee..eee0910 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -193,10 +193,7 @@ class TestChecksumOffload(TestCase):
                             if (flag == 1):
                                 self.verify("PKT_RX_L4_CKSUM_GOOD" in line, "Packet Rx L4 checksum valid-flags error!")
                             elif (flag == 0):
-                                if self.nic == "cavium_a063":
-                                    self.verify("PKT_RX_L4_CKSUM_BAD" in line or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "Packet Rx L4 checksum valid-flags error!")
-                                else:
-                                    self.verify("PKT_RX_L4_CKSUM_BAD" in line, "Packet Rx L4 checksum valid-flags error!")
+                                self.verify("PKT_RX_L4_CKSUM_BAD" in line or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "Packet Rx L4 checksum valid-flags error!")
                     else:
                         if "PKT_RX_L4_CKSUM" not in line:
                             self.verify(0, "There is no L4 checksum flags appeared!")
@@ -207,7 +204,7 @@ class TestChecksumOffload(TestCase):
                                 self.verify("PKT_RX_L4_CKSUM_GOOD" in line, "Packet Rx L4 checksum valid-flags error!")
                                 self.verify("PKT_RX_IP_CKSUM_GOOD" in line, "Packet Rx IP checksum valid-flags error!")
                             elif (flag == 0):
-                                self.verify("PKT_RX_L4_CKSUM_BAD" in line, "Packet Rx L4 checksum valid-flags error!")
+                                self.verify("PKT_RX_L4_CKSUM_BAD" in line or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "Packet Rx L4 checksum valid-flags error!")
                                 self.verify("PKT_RX_IP_CKSUM_BAD" in line, "Packet Rx IP checksum valid-flags error!")
 
         self.dut.send_expect("stop", "testpmd>")
diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py
index d0331dc..0e70526 100644
--- a/tests/TestSuite_rxtx_offload.py
+++ b/tests/TestSuite_rxtx_offload.py
@@ -271,10 +271,7 @@ class TestRxTx_Offload(TestCase):
                     else:
                         self.verify("PKT_RX_IP_CKSUM_GOOD" in line, "ipv4 checksum flag is wrong!")
                     if ("udp" in flags) or ("tcp" in flags):
-                        if self.nic in ['cavium_a063', 'cavium_a064']:
-                            self.verify("PKT_RX_L4_CKSUM_BAD" or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "L4 checksum flag is wrong!")
-                        else:
-                            self.verify("PKT_RX_L4_CKSUM_BAD" in line, "L4 checksum flag is wrong!")
+                        self.verify("PKT_RX_L4_CKSUM_BAD" or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "L4 checksum flag is wrong!")
                     else:
                         self.verify(("PKT_RX_L4_CKSUM_GOOD" in line) or ("PKT_RX_L4_CKSUM_UNKNOWN" in line), "L4 checksum flag is wrong!")
         # collect the tx checksum result
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change
  2021-03-11  5:50 [dts] [PATCH V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change Zhou Jun
@ 2021-03-11  5:57 ` Zhou, JunX W
  2021-03-15  6:32 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhou, JunX W @ 2021-03-11  5:57 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

>-----Original Message-----
>From: Zhou, JunX W 
>Sent: Thursday, March 11, 2021 1:51 PM
>To: dts@dpdk.org
>Cc: Zhou, JunX W <junx.w.zhou@intel.com>
>Subject: [dts][PATCH V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change
>
>v1: modify dts for adapt DPDK bad UDP checksum change from PKT_RX_L4_CKSUM_BAD 
>     to PKT_RX_L4_CKSUM_UNKNOWN 
>
>v2: add DPDK change UDP checksum version: 21.02 rc3
>
>Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>

Tested-by: Zhou, Jun <junx.w.zhou@intel.com> 

[-- Attachment #2: TestChecksumOffload.log --]
[-- Type: application/octet-stream, Size: 481960 bytes --]

[-- Attachment #3: TestRxTx_Offload.log --]
[-- Type: application/octet-stream, Size: 6547661 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change
  2021-03-11  5:50 [dts] [PATCH V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change Zhou Jun
  2021-03-11  5:57 ` Zhou, JunX W
@ 2021-03-15  6:32 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-03-15  6:32 UTC (permalink / raw)
  To: Zhou, JunX W, dts; +Cc: Zhou, JunX W

> v1: modify dts for adapt DPDK bad UDP checksum change from
> PKT_RX_L4_CKSUM_BAD
>      to PKT_RX_L4_CKSUM_UNKNOWN
> 
> v2: add DPDK change UDP checksum version: 21.02 rc3
> 
> Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>

Applied with commit message changed.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-15  6:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11  5:50 [dts] [PATCH V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change Zhou Jun
2021-03-11  5:57 ` Zhou, JunX W
2021-03-15  6:32 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git