test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env
@ 2020-02-25  8:34 Haiyang Zhao
  2020-02-25  9:01 ` Tu, Lijuan
  2020-03-03  7:23 ` Tu, Lijuan
  0 siblings, 2 replies; 7+ messages in thread
From: Haiyang Zhao @ 2020-02-25  8:34 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

remove redundant parameter

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 tests/TestSuite_virtio_user_for_container_networking.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_virtio_user_for_container_networking.py b/tests/TestSuite_virtio_user_for_container_networking.py
index ba303b7..1f9a666 100644
--- a/tests/TestSuite_virtio_user_for_container_networking.py
+++ b/tests/TestSuite_virtio_user_for_container_networking.py
@@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase):
             command_line_user = 'docker run -i -t --privileged -v %s/vhost-net:/tmp/vhost-net ' + \
                             '-v /mnt/huge:/dev/hugepages ' + \
                             '-v %s:%s %s .%s/%s/app/testpmd -c %s -n %d ' + \
-                            '-m 1024 --no-pci --file-prefix=container --single-file-segments ' + \
+                            '-m 1024 --no-pci --file-prefix=container ' + \
                             '--vdev=virtio_user0,mac=00:11:22:33:44:10,path=/tmp/vhost-net,queues=%d ' + \
                             '-- -i --rxq=%d --txq=%d --nb-cores=%d'
         command_line_user = command_line_user % (self.container_base_dir,
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env
  2020-02-25  8:34 [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env Haiyang Zhao
@ 2020-02-25  9:01 ` Tu, Lijuan
  2020-02-28  2:36   ` Xiao, QimaiX
  2020-03-03  7:23 ` Tu, Lijuan
  1 sibling, 1 reply; 7+ messages in thread
From: Tu, Lijuan @ 2020-02-25  9:01 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Remove single-file-segments, so what will happen, if 2M env ?

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Tuesday, February 25, 2020 4:35 PM
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH
> V1]tests/TestSuite_virtio_user_for_container_networking: remove
> redundant parameter single-file-segments if not 2M env
> 
> remove redundant parameter
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  tests/TestSuite_virtio_user_for_container_networking.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_virtio_user_for_container_networking.py
> b/tests/TestSuite_virtio_user_for_container_networking.py
> index ba303b7..1f9a666 100644
> --- a/tests/TestSuite_virtio_user_for_container_networking.py
> +++ b/tests/TestSuite_virtio_user_for_container_networking.py
> @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase):
>              command_line_user = 'docker run -i -t --privileged -v %s/vhost-
> net:/tmp/vhost-net ' + \
>                              '-v /mnt/huge:/dev/hugepages ' + \
>                              '-v %s:%s %s .%s/%s/app/testpmd -c %s -n %d ' + \
> -                            '-m 1024 --no-pci --file-prefix=container --single-file-
> segments ' + \
> +                            '-m 1024 --no-pci --file-prefix=container ' + \
>                              '--
> vdev=virtio_user0,mac=00:11:22:33:44:10,path=/tmp/vhost-net,queues=%d '
> + \
>                              '-- -i --rxq=%d --txq=%d --nb-cores=%d'
>          command_line_user = command_line_user % (self.container_base_dir,
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env
  2020-02-25  9:01 ` Tu, Lijuan
@ 2020-02-28  2:36   ` Xiao, QimaiX
  2020-02-28  2:50     ` Tu, Lijuan
  0 siblings, 1 reply; 7+ messages in thread
From: Xiao, QimaiX @ 2020-02-28  2:36 UTC (permalink / raw)
  To: Tu, Lijuan, Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Hi, Lijuan

I consulted lihong that single-file-segments parameter only required on virtio side in 2M env, vhost side doesn't need, so it's ok to remove it. 

Regards,
Xiao Qimai


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> Sent: Tuesday, February 25, 2020 5:01 PM
> To: Zhao, HaiyangX <haiyangx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: Re: [dts] [PATCH
> V1]tests/TestSuite_virtio_user_for_container_networking: remove
> redundant parameter single-file-segments if not 2M env
> 
> Remove single-file-segments, so what will happen, if 2M env ?
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> > Sent: Tuesday, February 25, 2020 4:35 PM
> > To: dts@dpdk.org
> > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > Subject: [dts] [PATCH
> > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > redundant parameter single-file-segments if not 2M env
> >
> > remove redundant parameter
> >
> > Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> > ---
> >  tests/TestSuite_virtio_user_for_container_networking.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_virtio_user_for_container_networking.py
> > b/tests/TestSuite_virtio_user_for_container_networking.py
> > index ba303b7..1f9a666 100644
> > --- a/tests/TestSuite_virtio_user_for_container_networking.py
> > +++ b/tests/TestSuite_virtio_user_for_container_networking.py
> > @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase):
> >              command_line_user = 'docker run -i -t --privileged -v
> > %s/vhost- net:/tmp/vhost-net ' + \
> >                              '-v /mnt/huge:/dev/hugepages ' + \
> >                              '-v %s:%s %s .%s/%s/app/testpmd -c %s -n %d ' + \
> > -                            '-m 1024 --no-pci --file-prefix=container --single-file-
> > segments ' + \
> > +                            '-m 1024 --no-pci --file-prefix=container
> > + ' + \
> >                              '--
> > vdev=virtio_user0,mac=00:11:22:33:44:10,path=/tmp/vhost-
> net,queues=%d '
> > + \
> >                              '-- -i --rxq=%d --txq=%d --nb-cores=%d'
> >          command_line_user = command_line_user %
> > (self.container_base_dir,
> > --
> > 1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env
  2020-02-28  2:36   ` Xiao, QimaiX
@ 2020-02-28  2:50     ` Tu, Lijuan
  2020-02-28  3:04       ` Wang, Yinan
  0 siblings, 1 reply; 7+ messages in thread
From: Tu, Lijuan @ 2020-02-28  2:50 UTC (permalink / raw)
  To: Xiao, QimaiX, Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

As you said, it was required on 2M env, so it's not reasonable to remove it without any judgement.

> -----Original Message-----
> From: Xiao, QimaiX
> Sent: Friday, February 28, 2020 10:37 AM
> To: Tu, Lijuan <lijuan.tu@intel.com>; Zhao, HaiyangX
> <haiyangx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: RE: [dts] [PATCH
> V1]tests/TestSuite_virtio_user_for_container_networking: remove
> redundant parameter single-file-segments if not 2M env
> 
> Hi, Lijuan
> 
> I consulted lihong that single-file-segments parameter only required on virtio
> side in 2M env, vhost side doesn't need, so it's ok to remove it.
> 
> Regards,
> Xiao Qimai
> 
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> > Sent: Tuesday, February 25, 2020 5:01 PM
> > To: Zhao, HaiyangX <haiyangx.zhao@intel.com>; dts@dpdk.org
> > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > Subject: Re: [dts] [PATCH
> > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > redundant parameter single-file-segments if not 2M env
> >
> > Remove single-file-segments, so what will happen, if 2M env ?
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> > > Sent: Tuesday, February 25, 2020 4:35 PM
> > > To: dts@dpdk.org
> > > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > > Subject: [dts] [PATCH
> > > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > > redundant parameter single-file-segments if not 2M env
> > >
> > > remove redundant parameter
> > >
> > > Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> > > ---
> > >  tests/TestSuite_virtio_user_for_container_networking.py | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/TestSuite_virtio_user_for_container_networking.py
> > > b/tests/TestSuite_virtio_user_for_container_networking.py
> > > index ba303b7..1f9a666 100644
> > > --- a/tests/TestSuite_virtio_user_for_container_networking.py
> > > +++ b/tests/TestSuite_virtio_user_for_container_networking.py
> > > @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase):
> > >              command_line_user = 'docker run -i -t --privileged -v
> > > %s/vhost- net:/tmp/vhost-net ' + \
> > >                              '-v /mnt/huge:/dev/hugepages ' + \
> > >                              '-v %s:%s %s .%s/%s/app/testpmd -c %s -n %d ' + \
> > > -                            '-m 1024 --no-pci --file-prefix=container --single-file-
> > > segments ' + \
> > > +                            '-m 1024 --no-pci
> > > + --file-prefix=container ' + \
> > >                              '--
> > > vdev=virtio_user0,mac=00:11:22:33:44:10,path=/tmp/vhost-
> > net,queues=%d '
> > > + \
> > >                              '-- -i --rxq=%d --txq=%d --nb-cores=%d'
> > >          command_line_user = command_line_user %
> > > (self.container_base_dir,
> > > --
> > > 1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env
  2020-02-28  2:50     ` Tu, Lijuan
@ 2020-02-28  3:04       ` Wang, Yinan
  2020-02-28  3:20         ` Xiao, QimaiX
  0 siblings, 1 reply; 7+ messages in thread
From: Wang, Yinan @ 2020-02-28  3:04 UTC (permalink / raw)
  To: Tu, Lijuan, Xiao, QimaiX, Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Hi Lijuan,


Since 2M page smaller than 1G, so need more hug pages ,single-file-segments can help to create fewer files in hugetlbfs.
It only used in virtio-user side is ok.

BR,
Yinan

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Tu, Lijuan
> Sent: 2020年2月28日 10:51
> To: Xiao, QimaiX <qimaix.xiao@intel.com>; Zhao, HaiyangX
> <haiyangx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: Re: [dts] [PATCH
> V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant
> parameter single-file-segments if not 2M env
> 
> As you said, it was required on 2M env, so it's not reasonable to remove it
> without any judgement.
> 
> > -----Original Message-----
> > From: Xiao, QimaiX
> > Sent: Friday, February 28, 2020 10:37 AM
> > To: Tu, Lijuan <lijuan.tu@intel.com>; Zhao, HaiyangX
> > <haiyangx.zhao@intel.com>; dts@dpdk.org
> > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > Subject: RE: [dts] [PATCH
> > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > redundant parameter single-file-segments if not 2M env
> >
> > Hi, Lijuan
> >
> > I consulted lihong that single-file-segments parameter only required
> > on virtio side in 2M env, vhost side doesn't need, so it's ok to remove it.
> >
> > Regards,
> > Xiao Qimai
> >
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> > > Sent: Tuesday, February 25, 2020 5:01 PM
> > > To: Zhao, HaiyangX <haiyangx.zhao@intel.com>; dts@dpdk.org
> > > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > > Subject: Re: [dts] [PATCH
> > > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > > redundant parameter single-file-segments if not 2M env
> > >
> > > Remove single-file-segments, so what will happen, if 2M env ?
> > >
> > > > -----Original Message-----
> > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> > > > Sent: Tuesday, February 25, 2020 4:35 PM
> > > > To: dts@dpdk.org
> > > > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > > > Subject: [dts] [PATCH
> > > > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > > > redundant parameter single-file-segments if not 2M env
> > > >
> > > > remove redundant parameter
> > > >
> > > > Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> > > > ---
> > > >  tests/TestSuite_virtio_user_for_container_networking.py | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git
> > > > a/tests/TestSuite_virtio_user_for_container_networking.py
> > > > b/tests/TestSuite_virtio_user_for_container_networking.py
> > > > index ba303b7..1f9a666 100644
> > > > --- a/tests/TestSuite_virtio_user_for_container_networking.py
> > > > +++ b/tests/TestSuite_virtio_user_for_container_networking.py
> > > > @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase):
> > > >              command_line_user = 'docker run -i -t --privileged -v
> > > > %s/vhost- net:/tmp/vhost-net ' + \
> > > >                              '-v /mnt/huge:/dev/hugepages ' + \
> > > >                              '-v %s:%s %s .%s/%s/app/testpmd
> -c %s -n %d ' + \
> > > > -                            '-m 1024 --no-pci --file-prefix=container
> --single-file-
> > > > segments ' + \
> > > > +                            '-m 1024 --no-pci
> > > > + --file-prefix=container ' + \
> > > >                              '--
> > > > vdev=virtio_user0,mac=00:11:22:33:44:10,path=/tmp/vhost-
> > > net,queues=%d '
> > > > + \
> > > >                              '-- -i --rxq=%d --txq=%d
> --nb-cores=%d'
> > > >          command_line_user = command_line_user %
> > > > (self.container_base_dir,
> > > > --
> > > > 1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env
  2020-02-28  3:04       ` Wang, Yinan
@ 2020-02-28  3:20         ` Xiao, QimaiX
  0 siblings, 0 replies; 7+ messages in thread
From: Xiao, QimaiX @ 2020-02-28  3:20 UTC (permalink / raw)
  To: Wang, Yinan, Tu, Lijuan, Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Hi, Lijuan

This patch only remove unnecessary single-file-segments parameter for vhost side in 2M env.

Regards,
Xiao Qimai

> -----Original Message-----
> From: Wang, Yinan
> Sent: Friday, February 28, 2020 11:04 AM
> To: Tu, Lijuan <lijuan.tu@intel.com>; Xiao, QimaiX <qimaix.xiao@intel.com>;
> Zhao, HaiyangX <haiyangx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: RE: [dts] [PATCH
> V1]tests/TestSuite_virtio_user_for_container_networking: remove
> redundant parameter single-file-segments if not 2M env
> 
> Hi Lijuan,
> 
> 
> Since 2M page smaller than 1G, so need more hug pages ,single-file-
> segments can help to create fewer files in hugetlbfs.
> It only used in virtio-user side is ok.
> 
> BR,
> Yinan
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Tu, Lijuan
> > Sent: 2020年2月28日 10:51
> > To: Xiao, QimaiX <qimaix.xiao@intel.com>; Zhao, HaiyangX
> > <haiyangx.zhao@intel.com>; dts@dpdk.org
> > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > Subject: Re: [dts] [PATCH
> > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > redundant parameter single-file-segments if not 2M env
> >
> > As you said, it was required on 2M env, so it's not reasonable to
> > remove it without any judgement.
> >
> > > -----Original Message-----
> > > From: Xiao, QimaiX
> > > Sent: Friday, February 28, 2020 10:37 AM
> > > To: Tu, Lijuan <lijuan.tu@intel.com>; Zhao, HaiyangX
> > > <haiyangx.zhao@intel.com>; dts@dpdk.org
> > > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > > Subject: RE: [dts] [PATCH
> > > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > > redundant parameter single-file-segments if not 2M env
> > >
> > > Hi, Lijuan
> > >
> > > I consulted lihong that single-file-segments parameter only required
> > > on virtio side in 2M env, vhost side doesn't need, so it's ok to remove it.
> > >
> > > Regards,
> > > Xiao Qimai
> > >
> > >
> > > > -----Original Message-----
> > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> > > > Sent: Tuesday, February 25, 2020 5:01 PM
> > > > To: Zhao, HaiyangX <haiyangx.zhao@intel.com>; dts@dpdk.org
> > > > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > > > Subject: Re: [dts] [PATCH
> > > > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > > > redundant parameter single-file-segments if not 2M env
> > > >
> > > > Remove single-file-segments, so what will happen, if 2M env ?
> > > >
> > > > > -----Original Message-----
> > > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang
> > > > > Zhao
> > > > > Sent: Tuesday, February 25, 2020 4:35 PM
> > > > > To: dts@dpdk.org
> > > > > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > > > > Subject: [dts] [PATCH
> > > > > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > > > > redundant parameter single-file-segments if not 2M env
> > > > >
> > > > > remove redundant parameter
> > > > >
> > > > > Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> > > > > ---
> > > > >  tests/TestSuite_virtio_user_for_container_networking.py | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git
> > > > > a/tests/TestSuite_virtio_user_for_container_networking.py
> > > > > b/tests/TestSuite_virtio_user_for_container_networking.py
> > > > > index ba303b7..1f9a666 100644
> > > > > --- a/tests/TestSuite_virtio_user_for_container_networking.py
> > > > > +++ b/tests/TestSuite_virtio_user_for_container_networking.py
> > > > > @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase):
> > > > >              command_line_user = 'docker run -i -t --privileged
> > > > > -v
> > > > > %s/vhost- net:/tmp/vhost-net ' + \
> > > > >                              '-v /mnt/huge:/dev/hugepages ' + \
> > > > >                              '-v %s:%s %s .%s/%s/app/testpmd
> > -c %s -n %d ' + \
> > > > > -                            '-m 1024 --no-pci --file-prefix=container
> > --single-file-
> > > > > segments ' + \
> > > > > +                            '-m 1024 --no-pci
> > > > > + --file-prefix=container ' + \
> > > > >                              '--
> > > > > vdev=virtio_user0,mac=00:11:22:33:44:10,path=/tmp/vhost-
> > > > net,queues=%d '
> > > > > + \
> > > > >                              '-- -i --rxq=%d --txq=%d
> > --nb-cores=%d'
> > > > >          command_line_user = command_line_user %
> > > > > (self.container_base_dir,
> > > > > --
> > > > > 1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env
  2020-02-25  8:34 [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env Haiyang Zhao
  2020-02-25  9:01 ` Tu, Lijuan
@ 2020-03-03  7:23 ` Tu, Lijuan
  1 sibling, 0 replies; 7+ messages in thread
From: Tu, Lijuan @ 2020-03-03  7:23 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Applied with comments changed.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Tuesday, February 25, 2020 4:35 PM
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH
> V1]tests/TestSuite_virtio_user_for_container_networking: remove
> redundant parameter single-file-segments if not 2M env
> 
> remove redundant parameter
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  tests/TestSuite_virtio_user_for_container_networking.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_virtio_user_for_container_networking.py
> b/tests/TestSuite_virtio_user_for_container_networking.py
> index ba303b7..1f9a666 100644
> --- a/tests/TestSuite_virtio_user_for_container_networking.py
> +++ b/tests/TestSuite_virtio_user_for_container_networking.py
> @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase):
>              command_line_user = 'docker run -i -t --privileged -v %s/vhost-
> net:/tmp/vhost-net ' + \
>                              '-v /mnt/huge:/dev/hugepages ' + \
>                              '-v %s:%s %s .%s/%s/app/testpmd -c %s -n %d ' + \
> -                            '-m 1024 --no-pci --file-prefix=container --single-file-
> segments ' + \
> +                            '-m 1024 --no-pci --file-prefix=container ' + \
>                              '--
> vdev=virtio_user0,mac=00:11:22:33:44:10,path=/tmp/vhost-net,queues=%d '
> + \
>                              '-- -i --rxq=%d --txq=%d --nb-cores=%d'
>          command_line_user = command_line_user % (self.container_base_dir,
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-03-03  7:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-25  8:34 [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env Haiyang Zhao
2020-02-25  9:01 ` Tu, Lijuan
2020-02-28  2:36   ` Xiao, QimaiX
2020-02-28  2:50     ` Tu, Lijuan
2020-02-28  3:04       ` Wang, Yinan
2020-02-28  3:20         ` Xiao, QimaiX
2020-03-03  7:23 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).