test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter
@ 2020-04-07  2:00 Xiao Qimai
  2020-04-07  2:06 ` Xiao, QimaiX
  2020-04-17  9:04 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2020-04-07  2:00 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_vm2vm_virtio_pmd.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vm2vm_virtio_pmd.py b/tests/TestSuite_vm2vm_virtio_pmd.py
index 5bc0d01..62929e0 100644
--- a/tests/TestSuite_vm2vm_virtio_pmd.py
+++ b/tests/TestSuite_vm2vm_virtio_pmd.py
@@ -167,10 +167,16 @@ class TestVM2VMVirtioPMD(TestCase):
         bootup pdump in VM
         """
         self.pdump_session = client_dut.new_session(suite="pdump")
-        command_line = self.target + "/app/dpdk-pdump " + \
+        if hasattr(client_dut, "vm_name"):
+            command_line = self.target + "/app/dpdk-pdump " + \
                     "-v --file-prefix=virtio -- " + \
                     "--pdump  '%s,queue=*,rx-dev=%s,mbuf-size=8000'"
-        self.pdump_session.send_expect(command_line % (dump_port, self.dump_pcap), 'Port')
+            self.pdump_session.send_expect(command_line % (dump_port, self.dump_pcap), 'Port')
+        else:
+            command_line = self.target + "/app/dpdk-pdump " + \
+                    "-v --file-prefix=virtio_%s -- " + \
+                    "--pdump  '%s,queue=*,rx-dev=%s,mbuf-size=8000'"
+            self.pdump_session.send_expect(command_line % (self.dut.prefix_subfix, dump_port, self.dump_pcap), 'Port')
 
     def start_vms(self, mode=0, mergeable=True):
         """
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter
  2020-04-07  2:00 [dts] [PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter Xiao Qimai
@ 2020-04-07  2:06 ` Xiao, QimaiX
  2020-04-17  9:04 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Xiao, QimaiX @ 2020-04-07  2:06 UTC (permalink / raw)
  To: dts

Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>

Regards,
Xiao Qimai

> -----Original Message-----
> From: Xiao, QimaiX
> Sent: Tuesday, April 7, 2020 10:00 AM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts][PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_vm2vm_virtio_pmd.py | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_vm2vm_virtio_pmd.py
> b/tests/TestSuite_vm2vm_virtio_pmd.py
> index 5bc0d01..62929e0 100644
> --- a/tests/TestSuite_vm2vm_virtio_pmd.py
> +++ b/tests/TestSuite_vm2vm_virtio_pmd.py
> @@ -167,10 +167,16 @@ class TestVM2VMVirtioPMD(TestCase):
>          bootup pdump in VM
>          """
>          self.pdump_session = client_dut.new_session(suite="pdump")
> -        command_line = self.target + "/app/dpdk-pdump " + \
> +        if hasattr(client_dut, "vm_name"):
> +            command_line = self.target + "/app/dpdk-pdump " + \
>                      "-v --file-prefix=virtio -- " + \
>                      "--pdump  '%s,queue=*,rx-dev=%s,mbuf-size=8000'"
> -        self.pdump_session.send_expect(command_line % (dump_port,
> self.dump_pcap), 'Port')
> +            self.pdump_session.send_expect(command_line % (dump_port,
> self.dump_pcap), 'Port')
> +        else:
> +            command_line = self.target + "/app/dpdk-pdump " + \
> +                    "-v --file-prefix=virtio_%s -- " + \
> +                    "--pdump  '%s,queue=*,rx-dev=%s,mbuf-size=8000'"
> +            self.pdump_session.send_expect(command_line %
> (self.dut.prefix_subfix, dump_port, self.dump_pcap), 'Port')
> 
>      def start_vms(self, mode=0, mergeable=True):
>          """
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter
  2020-04-07  2:00 [dts] [PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter Xiao Qimai
  2020-04-07  2:06 ` Xiao, QimaiX
@ 2020-04-17  9:04 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-04-17  9:04 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Tuesday, April 7, 2020 10:00 AM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_vm2vm_virtio_pmd.py | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_vm2vm_virtio_pmd.py
> b/tests/TestSuite_vm2vm_virtio_pmd.py
> index 5bc0d01..62929e0 100644
> --- a/tests/TestSuite_vm2vm_virtio_pmd.py
> +++ b/tests/TestSuite_vm2vm_virtio_pmd.py
> @@ -167,10 +167,16 @@ class TestVM2VMVirtioPMD(TestCase):
>          bootup pdump in VM
>          """
>          self.pdump_session = client_dut.new_session(suite="pdump")
> -        command_line = self.target + "/app/dpdk-pdump " + \
> +        if hasattr(client_dut, "vm_name"):
> +            command_line = self.target + "/app/dpdk-pdump " + \
>                      "-v --file-prefix=virtio -- " + \
>                      "--pdump  '%s,queue=*,rx-dev=%s,mbuf-size=8000'"
> -        self.pdump_session.send_expect(command_line % (dump_port,
> self.dump_pcap), 'Port')
> +            self.pdump_session.send_expect(command_line % (dump_port,
> self.dump_pcap), 'Port')
> +        else:
> +            command_line = self.target + "/app/dpdk-pdump " + \
> +                    "-v --file-prefix=virtio_%s -- " + \
> +                    "--pdump  '%s,queue=*,rx-dev=%s,mbuf-size=8000'"
> +            self.pdump_session.send_expect(command_line %
> (self.dut.prefix_subfix, dump_port, self.dump_pcap), 'Port')
> 
>      def start_vms(self, mode=0, mergeable=True):
>          """
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-17  9:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07  2:00 [dts] [PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter Xiao Qimai
2020-04-07  2:06 ` Xiao, QimaiX
2020-04-17  9:04 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).