test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] update flow_classify_softnic to reduce runtime
@ 2019-04-28 10:12 xiao,qimai
  2019-04-29  5:30 ` Peng, Yuan
  2019-05-13  2:30 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: xiao,qimai @ 2019-04-28 10:12 UTC (permalink / raw)
  To: dts; +Cc: xiao,qimai

optimize function of send package with scapy

Signed-off-by: xiao,qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_flow_classify_softnic.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_flow_classify_softnic.py b/tests/TestSuite_flow_classify_softnic.py
index c98e8d0..9b339ca 100644
--- a/tests/TestSuite_flow_classify_softnic.py
+++ b/tests/TestSuite_flow_classify_softnic.py
@@ -275,7 +275,7 @@ class TestFlowClassifySoftnic(TestCase):
                     packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IP(src="%s.%d", dst="%s", proto=17)/UDP(sport=100, dport=200)], iface="%s")' % (
                         self.dut_p0_mac, itf, ipaddr, i, dst_addr, itf)
                     self.tester.scapy_append(packet)
-                    self.tester.scapy_execute()
+                self.tester.scapy_execute()
             elif ptype == "ipv6":
                 var = src_addr.split(":")
                 string = ":"
@@ -287,7 +287,7 @@ class TestFlowClassifySoftnic(TestCase):
                     packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IPv6(src="%s:%d", dst="%s", nh=17)/UDP(sport=100, dport=200)], iface="%s")' % (
                         self.dut_p0_mac, itf, ipaddr, i, dst_addr, itf)
                     self.tester.scapy_append(packet)
-                    self.tester.scapy_execute()
+                self.tester.scapy_execute()
 
         elif src_dst == "dst":
             if ptype == "ipv4":
@@ -298,7 +298,7 @@ class TestFlowClassifySoftnic(TestCase):
                     packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IP(src="%s", dst="%s.%d", proto=17)/UDP(sport=100, dport=100)], iface="%s")' % (
                         self.dut_p0_mac, itf, src_addr, ipaddr, i, itf)
                     self.tester.scapy_append(packet)
-                    self.tester.scapy_execute()
+                self.tester.scapy_execute()
             elif ptype == "ipv6":
                 var = dst_addr.split(":")
                 string = ":"
@@ -310,7 +310,7 @@ class TestFlowClassifySoftnic(TestCase):
                     packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IPv6(src="%s", dst="%s:%d", nh=17)/UDP(sport=100, dport=200)], iface="%s")' % (
                         self.dut_p0_mac, itf, src_addr, ipaddr, i, itf)
                     self.tester.scapy_append(packet)
-                    self.tester.scapy_execute()
+                self.tester.scapy_execute()
 
     def check_packet_queue(self, queues=[], out=""):
         """
-- 
2.17.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] update flow_classify_softnic to reduce runtime
  2019-04-28 10:12 [dts] [PATCH V1] update flow_classify_softnic to reduce runtime xiao,qimai
@ 2019-04-29  5:30 ` Peng, Yuan
  2019-05-13  2:30 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Peng, Yuan @ 2019-04-29  5:30 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Acked-by: Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xiao,qimai
Sent: Sunday, April 28, 2019 6:13 PM
To: dts@dpdk.org
Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1] update flow_classify_softnic to reduce runtime

optimize function of send package with scapy

Signed-off-by: xiao,qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_flow_classify_softnic.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_flow_classify_softnic.py b/tests/TestSuite_flow_classify_softnic.py
index c98e8d0..9b339ca 100644
--- a/tests/TestSuite_flow_classify_softnic.py
+++ b/tests/TestSuite_flow_classify_softnic.py
@@ -275,7 +275,7 @@ class TestFlowClassifySoftnic(TestCase):
                     packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IP(src="%s.%d", dst="%s", proto=17)/UDP(sport=100, dport=200)], iface="%s")' % (
                         self.dut_p0_mac, itf, ipaddr, i, dst_addr, itf)
                     self.tester.scapy_append(packet)
-                    self.tester.scapy_execute()
+                self.tester.scapy_execute()
             elif ptype == "ipv6":
                 var = src_addr.split(":")
                 string = ":"
@@ -287,7 +287,7 @@ class TestFlowClassifySoftnic(TestCase):
                     packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IPv6(src="%s:%d", dst="%s", nh=17)/UDP(sport=100, dport=200)], iface="%s")' % (
                         self.dut_p0_mac, itf, ipaddr, i, dst_addr, itf)
                     self.tester.scapy_append(packet)
-                    self.tester.scapy_execute()
+                self.tester.scapy_execute()
 
         elif src_dst == "dst":
             if ptype == "ipv4":
@@ -298,7 +298,7 @@ class TestFlowClassifySoftnic(TestCase):
                     packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IP(src="%s", dst="%s.%d", proto=17)/UDP(sport=100, dport=100)], iface="%s")' % (
                         self.dut_p0_mac, itf, src_addr, ipaddr, i, itf)
                     self.tester.scapy_append(packet)
-                    self.tester.scapy_execute()
+                self.tester.scapy_execute()
             elif ptype == "ipv6":
                 var = dst_addr.split(":")
                 string = ":"
@@ -310,7 +310,7 @@ class TestFlowClassifySoftnic(TestCase):
                     packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IPv6(src="%s", dst="%s:%d", nh=17)/UDP(sport=100, dport=200)], iface="%s")' % (
                         self.dut_p0_mac, itf, src_addr, ipaddr, i, itf)
                     self.tester.scapy_append(packet)
-                    self.tester.scapy_execute()
+                self.tester.scapy_execute()
 
     def check_packet_queue(self, queues=[], out=""):
         """
-- 
2.17.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] update flow_classify_softnic to reduce runtime
  2019-04-28 10:12 [dts] [PATCH V1] update flow_classify_softnic to reduce runtime xiao,qimai
  2019-04-29  5:30 ` Peng, Yuan
@ 2019-05-13  2:30 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-05-13  2:30 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xiao,qimai
> Sent: Sunday, April 28, 2019 6:13 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1] update flow_classify_softnic to reduce runtime
> 
> optimize function of send package with scapy
> 
> Signed-off-by: xiao,qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_flow_classify_softnic.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_flow_classify_softnic.py
> b/tests/TestSuite_flow_classify_softnic.py
> index c98e8d0..9b339ca 100644
> --- a/tests/TestSuite_flow_classify_softnic.py
> +++ b/tests/TestSuite_flow_classify_softnic.py
> @@ -275,7 +275,7 @@ class TestFlowClassifySoftnic(TestCase):
>                      packet = r'sendp([Ether(dst="%s",
> src=get_if_hwaddr("%s"))/IP(src="%s.%d", dst="%s",
> proto=17)/UDP(sport=100, dport=200)], iface="%s")' % (
>                          self.dut_p0_mac, itf, ipaddr, i, dst_addr, itf)
>                      self.tester.scapy_append(packet)
> -                    self.tester.scapy_execute()
> +                self.tester.scapy_execute()
>              elif ptype == "ipv6":
>                  var = src_addr.split(":")
>                  string = ":"
> @@ -287,7 +287,7 @@ class TestFlowClassifySoftnic(TestCase):
>                      packet = r'sendp([Ether(dst="%s",
> src=get_if_hwaddr("%s"))/IPv6(src="%s:%d", dst="%s", nh=17)/UDP(sport=100,
> dport=200)], iface="%s")' % (
>                          self.dut_p0_mac, itf, ipaddr, i, dst_addr, itf)
>                      self.tester.scapy_append(packet)
> -                    self.tester.scapy_execute()
> +                self.tester.scapy_execute()
> 
>          elif src_dst == "dst":
>              if ptype == "ipv4":
> @@ -298,7 +298,7 @@ class TestFlowClassifySoftnic(TestCase):
>                      packet = r'sendp([Ether(dst="%s",
> src=get_if_hwaddr("%s"))/IP(src="%s", dst="%s.%d",
> proto=17)/UDP(sport=100, dport=100)], iface="%s")' % (
>                          self.dut_p0_mac, itf, src_addr, ipaddr, i, itf)
>                      self.tester.scapy_append(packet)
> -                    self.tester.scapy_execute()
> +                self.tester.scapy_execute()
>              elif ptype == "ipv6":
>                  var = dst_addr.split(":")
>                  string = ":"
> @@ -310,7 +310,7 @@ class TestFlowClassifySoftnic(TestCase):
>                      packet = r'sendp([Ether(dst="%s",
> src=get_if_hwaddr("%s"))/IPv6(src="%s", dst="%s:%d", nh=17)/UDP(sport=100,
> dport=200)], iface="%s")' % (
>                          self.dut_p0_mac, itf, src_addr, ipaddr, i, itf)
>                      self.tester.scapy_append(packet)
> -                    self.tester.scapy_execute()
> +                self.tester.scapy_execute()
> 
>      def check_packet_queue(self, queues=[], out=""):
>          """
> --
> 2.17.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-13  2:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-28 10:12 [dts] [PATCH V1] update flow_classify_softnic to reduce runtime xiao,qimai
2019-04-29  5:30 ` Peng, Yuan
2019-05-13  2:30 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).