From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BB1BA00C3; Mon, 8 Jun 2020 05:00:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDD351B951; Mon, 8 Jun 2020 05:00:51 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1AC741B5E1 for ; Mon, 8 Jun 2020 05:00:49 +0200 (CEST) IronPort-SDR: Y/s9LLG8BCsF2jmSBYioJ4mgxvpAPjMqz3uc9w5/aq2YdaM9XutUHGWnLTlN9Yfzmp1dgI4GLn BDEAYyYIm8qg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2020 20:00:48 -0700 IronPort-SDR: 0xJFUJGw84i1HLviZ7wFtLyItmnviGGlpHii9IcQgKrLFEzIyuA+d14COiwpyGzkmAWqvzSjnf SpBLVG5koCdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,486,1583222400"; d="scan'208";a="270372014" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 07 Jun 2020 20:00:48 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 7 Jun 2020 20:00:48 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 8 Jun 2020 11:00:45 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Mon, 8 Jun 2020 11:00:45 +0800 From: "Lu, Nannan" To: "Zeng, XiaoxiaoX" , "dts@dpdk.org" CC: "Zeng, XiaoxiaoX" Thread-Topic: [dts] [PATCH V1]tests/cvl_switch_filter:optimization_cvl_switch_filter Thread-Index: AQHWOv9tV3PSoij96kuRJzCN2U/NcajOCh0A Date: Mon, 8 Jun 2020 03:00:45 +0000 Message-ID: <69fa936677e34758a218eafa6c9321ff@intel.com> References: <20200605144711.10375-1-xiaoxiaox.zeng@intel.com> In-Reply-To: <20200605144711.10375-1-xiaoxiaox.zeng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/cvl_switch_filter:optimization_cvl_switch_filter X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Comments in line. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zeng Xiaoxiao > Sent: Friday, June 5, 2020 10:47 PM > To: dts@dpdk.org > Cc: Zeng, XiaoxiaoX > Subject: [dts] [PATCH V1]tests/cvl_switch_filter:optimization_cvl_switch_= filter >=20 > *.Avoid that with different dpdk code, packet default queue same as queue= that > rule set, realize dynamic set rule in testpmd. >=20 > Signed-off-by: Zeng Xiaoxiao > --- > tests/TestSuite_cvl_switch_filter.py | 68 +++++++++++++++++++++++++++- > 1 file changed, 67 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_cvl_switch_filter.py > b/tests/TestSuite_cvl_switch_filter.py > index ffd9af4..9731c37 100644 > --- a/tests/TestSuite_cvl_switch_filter.py > +++ b/tests/TestSuite_cvl_switch_filter.py > @@ -34,6 +34,7 @@ import json > import time > import re > import copy > +import random >=20 > from test_case import TestCase > from pmd_output import PmdOutput > @@ -2571,6 +2572,35 @@ class SwitchFilterTest(TestCase): > result_flag, log_msg =3D dic["check_func"]["func"](out, > dic["check_func"]["param"], dic["expect_results"]) > return result_flag, log_msg >=20 > + def send_packet_get_queue(self, dic): > + """ > + general packets processing workflow. > + """ > + self.dut.send_expect("start", "testpmd> ") > + # send packets > + for per_packet in dic["scapy_str"]: > + pkt =3D Packet(pkt_str=3Dper_packet) > + pkt.send_pkt(self.tester, tx_port=3Dself.__tx_iface, count= =3D1) > + out =3D self.dut.send_expect("stop", "testpmd> ") > + p =3D re.compile(r"Forward Stats for RX Port=3D \d+/Queue=3D(\s?= \d+)") > + res =3D p.findall(out) > + default_queue =3D [int(i) for i in res] > + return default_queue > + > + def get_available_queue_num(self, default_queue): > + """ > + general packets processing workflow. > + """ > + queue_list =3D [1, 2, 3, 4, 5, 6] > + for q in default_queue: > + if q in queue_list: > + queue_list.remove(q) > + if (q - 1) in queue_list: > + queue_list.remove(q - 1) > + > + set_queue =3D random.choice(queue_list) > + return int(set_queue) > + Need a more flexible way to get available queues, need to support queue num= ber 4, 8, etc. > def save_results(self, pattern_name, flag, result_flag, log_msg, > overall_result): > """ > save results to dictionary: test_results. > @@ -2598,10 +2628,46 @@ class SwitchFilterTest(TestCase): > overall_result =3D True > test_results.clear() > for tv in test_vectors: > + # get packet default_queue number > + mismatched_dic =3D tv["mismatched"] > + default_queue =3D self.send_packet_get_queue(mismatched_dic) > + > + # check if default_queue same with expect_queue > + expect_queue =3D > tv["mismatched"]["check_func"]["param"]["expect_queues"] > + if expect_queue !=3D "null": > + if isinstance(expect_queue, int): > + eq_list =3D [] > + eq_list.append(expect_queue) > + elif isinstance(expect_queue, list): > + eq_list =3D expect_queue > + recover_flag =3D list(set(eq_list) & set(default_queue)) > + else: > + recover_flag =3D None > + > + # if default_queue has same one with expect_queue, recover r= ule > + if recover_flag: > + # exclude defult_queue number and get set_queue > + set_queue_num =3D self.get_available_queue_num(default_q= ueue) > + # recover rule command and check queue > + if isinstance(expect_queue, int): > + rule_command =3D tv["rte_flow_pattern"].replace("/ e= nd actions > queue index %s" % str(expect_queue), > + "/ end= actions queue index %s" % > str(set_queue_num)) > + tv["matched"]["check_func"]["param"]["expect_queues"= ] =3D > set_queue_num > + tv["mismatched"]["check_func"]["param"]["expect_queu= es"] =3D > set_queue_num > + elif isinstance(expect_queue, list): > + q =3D [str(i) for i in expect_queue] > + expect_queue_str =3D " ".join(q) > + rule_command =3D tv["rte_flow_pattern"].replace("/ e= nd actions rss > queues %s" % expect_queue_str, > + "/ end= actions rss queues %s" % > (str(set_queue_num) + " " + str(set_queue_num + 1))) Not only need to support 2 queues, but also need to be able to support more= queue numbers in rule. > + tv["matched"]["check_func"]["param"]["expect_queues"= ] =3D > [set_queue_num, set_queue_num + 1] > + tv["mismatched"]["check_func"]["param"]["expect_queu= es"] =3D > [set_queue_num, set_queue_num + 1] > + else: > + rule_command =3D tv["rte_flow_pattern"] > + > pattern_name =3D tv["name"] > test_results[pattern_name] =3D OrderedDict() >=20 > - out =3D self.dut.send_expect(tv["rte_flow_pattern"], "testpm= d> ", 15) > #create a rule > + out =3D self.dut.send_expect(rule_command, "testpmd> ", 15) > + #create a rule > #get the rule number > rule_num =3D self.get_rule_number(out) >=20 > -- > 2.17.1