test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Xie, WeiX" <weix.xie@intel.com>
To: "Mei, JianweiX" <jianweix.mei@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Mei, JianweiX" <jianweix.mei@intel.com>
Subject: Re: [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code
Date: Tue, 11 Aug 2020 06:44:41 +0000	[thread overview]
Message-ID: <6FD6A7610D20924F885A4ECF34E8AC91046523FD@CDSMSX102.ccr.corp.intel.com> (raw)
In-Reply-To: <20200811151108.26158-1-jianweix.mei@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianwei Mei
Sent: Tuesday, August 11, 2020 11:11 PM
To: dts@dpdk.org
Cc: Mei, JianweiX <jianweix.mei@intel.com>
Subject: [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code

Same command in tear down, and if it is executed before the quit command, an error will occur, so delete them from test case.

Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 733d72f..f8fa94f 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -335,8 +335,6 @@ class TestKernelpfIavf(TestCase):
         out = self.vm_dut.get_session_output()
         self.verify(self.wrong_mac in out, 'vf receive pkt fail with wrong mac')
 
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
-
     def test_vf_multicast(self):
         """
         enable kernel trust mode
@@ -363,7 +361,6 @@ class TestKernelpfIavf(TestCase):
         self.send_random_pkt(multicast_mac, count=1)
         out = self.vm_dut.get_session_output()
         self.verify(multicast_mac in out, 'vf receive pkt fail with multicast mac')
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
 
     def test_vf_broadcast(self):
         """
--
2.17.1


[-- Attachment #2: TestKernelpfIavf.log --]
[-- Type: application/octet-stream, Size: 711312 bytes --]

  reply	other threads:[~2020-08-11  6:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 15:11 Jianwei Mei
2020-08-11  6:44 ` Xie, WeiX [this message]
2020-08-13  5:39 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6FD6A7610D20924F885A4ECF34E8AC91046523FD@CDSMSX102.ccr.corp.intel.com \
    --to=weix.xie@intel.com \
    --cc=dts@dpdk.org \
    --cc=jianweix.mei@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).