From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 426D0A0096 for ; Fri, 12 Apr 2019 03:36:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E03434CA7; Fri, 12 Apr 2019 03:36:15 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E57B344C3 for ; Fri, 12 Apr 2019 03:36:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 18:36:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,339,1549958400"; d="scan'208";a="222794004" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 11 Apr 2019 18:36:12 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 18:36:12 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 18:36:12 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by shsmsx102.ccr.corp.intel.com ([169.254.2.206]) with mapi id 14.03.0415.000; Fri, 12 Apr 2019 09:36:09 +0800 From: "Wu, ChangqingX" To: "Tu, Lijuan" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid Thread-Index: AQHU8Iuy3MBmiiXRc02vx7DlOHUZVaY3vlqQ Date: Fri, 12 Apr 2019 01:36:09 +0000 Message-ID: <7F81DD3887C58F49A6B2EFEC3C28E22E0B6CD085@SHSMSX101.ccr.corp.intel.com> References: <1554794115-14839-1-git-send-email-changqingx.wu@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA60548@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA60548@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Dpdk made some code changes in the commit:53324971a14e02f5f710d6e73fe475650= e9a9802, which effects method that tests the number of "Bad-l4csum", contin= uously sends 2 or more packets between start and stop, the number of "Bad-l= 4csum" Will accumulate, if stop, the number of "Bad-l4csum" will be reset, = you can check: dpdk-11148, Yigit, Ferruh comments=20 Thanks changqingx -----Original Message----- From: Tu, Lijuan=20 Sent: Friday, April 12, 2019 1:26 AM To: Wu, ChangqingX ; dts@dpdk.org Cc: Wu, ChangqingX Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid I am not quit catch your reason, I think when it catch "Bad-l4csum", and th= e number increases. So what is your consideration that remove the statement= . > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu > Sent: Tuesday, April 9, 2019 12:15 AM > To: dts@dpdk.org > Cc: Wu, ChangqingX > Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid >=20 > Signed-off-by: changqingxwu > --- > tests/TestSuite_vxlan.py | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index > 8de8384..34297e0 100644 > --- a/tests/TestSuite_vxlan.py > +++ b/tests/TestSuite_vxlan.py > @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator): > if "inner_l4_invalid" in kwargs: > self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out) > =3D=3D self.l4err_num + 1, "Failed to count inne= r l4 chksum error") > - self.l4err_num +=3D 1 >=20 > # verify detected l3 invalid checksum > if "ip_invalid" in kwargs: > -- > 2.17.2