From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24E5CA0471 for ; Wed, 17 Jul 2019 08:28:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 052222BA8; Wed, 17 Jul 2019 08:28:48 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id DB77223D for ; Wed, 17 Jul 2019 08:28:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2019 23:28:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,273,1559545200"; d="scan'208";a="319221094" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 16 Jul 2019 23:28:45 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jul 2019 23:28:44 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jul 2019 23:28:44 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.240]) with mapi id 14.03.0439.000; Wed, 17 Jul 2019 14:28:43 +0800 From: "Wu, ChangqingX" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V1] tests/generic_filter: optimize 128_queues Thread-Index: AQHVPGiBhPCaRjhls0uZQEowRhQIQqbN0lwAgACGirA= Date: Wed, 17 Jul 2019 06:28:42 +0000 Message-ID: <7F81DD3887C58F49A6B2EFEC3C28E22E0B72B351@SHSMSX101.ccr.corp.intel.com> References: <1563376870-42385-1-git-send-email-wenjiex.a.li@intel.com> <8688172CD5C0B74590FAE19D9579F94B53743864@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <8688172CD5C0B74590FAE19D9579F94B53743864@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/generic_filter: optimize 128_queues X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Tested-by: Wu, ChangqingX -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Li, WenjieX A Sent: Wednesday, July 17, 2019 2:27 PM To: dts@dpdk.org Cc: Li, WenjieX A Subject: Re: [dts] [PATCH V1] tests/generic_filter: optimize 128_queues Tested-by: Li, WenjieX A > -----Original Message----- > From: Li, WenjieX A > Sent: Wednesday, July 17, 2019 11:21 PM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts][PATCH V1] tests/generic_filter: optimize 128_queues >=20 > 1. recover dpdk in test case 128_queues, instead of in tear_down. > 2. verify test result after recover and rebuild dpdk. > 3. change tab to space. >=20 > Signed-off-by: Wenjie Li > --- > tests/TestSuite_generic_filter.py | 30 ++++++++++++++++++++---------- > 1 file changed, 20 insertions(+), 10 deletions(-) >=20 > diff --git a/tests/TestSuite_generic_filter.py=20 > b/tests/TestSuite_generic_filter.py > index e7f480b..461db95 100644 > --- a/tests/TestSuite_generic_filter.py > +++ b/tests/TestSuite_generic_filter.py > @@ -704,9 +704,11 @@ class TestGeneric_filter(TestCase): >=20 > def test_128_queues(self): > # testpmd can't support assign queue to received packet, so=20 > can't test > + set_filter_flag =3D 1 > + packet_flag =3D 1 > if self.kdriver =3D=3D "ixgbe": > - self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES=20 > 128/' drivers/net/ixgbe/ixgbe_ethdev.h", > "# ",30) > - self.dut.build_install_dpdk(self.target) > + self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES=20 > 128/' drivers/net/ixgbe/ixgbe_ethdev.h", > "# ",30) > + self.dut.build_install_dpdk(self.target) > global valports > total_mbufs =3D self.request_mbufs(128) * len(valports) > self.pmdout.start_testpmd( @@ -730,11 +732,14 @@ class=20 > TestGeneric_filter(TestCase): > if i =3D=3D 2: > out =3D self.dut.send_expect( > "set stat_qmap rx %s %s %s" % (valports[0],=20 > queue[i], (i + 1)), "testpmd> ") > - self.verify('Invalid RX queue %s' % > - (queue[i]) in out, "set filters error") > + if 'Invalid RX queue %s' % (queue[i]) not in out: > + set_filter_flag =3D 0 > + break > out =3D self.dut.send_expect( > "5tuple_filter %s add dst_ip 2.2.2.5 src_ip=20 > 2.2.2.4 dst_port %s src_port 1 protocol 0x06 mask 0x1f tcp_flags 0x0=20 > priority 3 queue %s " % (valports[0], (i + 1), queue[i]), "testpmd> ") > - self.verify('error' in out, "set filters error") > + if 'error' not in out: > + set_filter_flag =3D 0 > + break > continue > else: > self.dut.send_expect("set stat_qmap rx %s %s %s"=20 > % @@ -753,10 > +758,14 @@ class TestGeneric_filter(TestCase): > scanner =3D re.compile(result_scanner, re.DOTALL) > m =3D scanner.search(out) > cur_pkt =3D m.group(1) > - self.verify( > - int(cur_pkt) =3D=3D frames_to_send, "packet pass ass= ert error") > - > + if int(cur_pkt) !=3D frames_to_send: > + packet_flag =3D 0 > + break > self.dut.send_expect("quit", "#") > + self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES=20 > 64/' drivers/net/ixgbe/ixgbe_ethdev.h", > "# ",30) > + self.dut.build_install_dpdk(self.target) > + self.verify(set_filter_flag =3D=3D 1, "set filters error") > + self.verify(packet_flag =3D=3D 1, "packet pass assert error"= ) > else: > self.verify(False, "%s not support this test" % self.nic) >=20 > @@ -840,5 +849,6 @@ class TestGeneric_filter(TestCase): > Run after each test case. > """ > self.dut.kill_all() > - self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES=20 > 128/' drivers/net/ixgbe/ixgbe_ethdev.h", > "# ",30) > - self.dut.build_install_dpdk(self.target) > + > + def tear_down_all(self): > + pass > -- > 2.17.1