From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A88FA0613 for ; Mon, 26 Aug 2019 08:31:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFDA61BF3E; Mon, 26 Aug 2019 08:30:59 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 704DA1BF3D for ; Mon, 26 Aug 2019 08:30:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Aug 2019 23:30:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,431,1559545200"; d="scan'208";a="181286068" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 25 Aug 2019 23:30:55 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 25 Aug 2019 23:30:55 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Mon, 26 Aug 2019 14:30:53 +0800 From: "Wu, ChangqingX" To: "Mo, YufengX" , "dts@dpdk.org" Thread-Topic: [dts][PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status Thread-Index: AQHVW89L33QwPrGW1kudDEufN1n7RqcM9/jg Date: Mon, 26 Aug 2019 06:30:52 +0000 Message-ID: <7F81DD3887C58F49A6B2EFEC3C28E22E0B746E53@SHSMSX101.ccr.corp.intel.com> References: <1566797447-122407-1-git-send-email-yufengx.mo@intel.com> <1566797447-122407-2-git-send-email-yufengx.mo@intel.com> In-Reply-To: <1566797447-122407-2-git-send-email-yufengx.mo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Tested-by: Wu, ChangqingX -----Original Message----- From: Mo, YufengX=20 Sent: Monday, August 26, 2019 1:31 PM To: Wu, ChangqingX ; dts@dpdk.org Cc: Mo, YufengX Subject: [dts][PATCH V1]tests/pmd_stacked_bonded: set slave ports in right = status port start all action implies the race condition. The right way is to start= top level bond port only, and let it propagate the start action to slave b= onded ports and its the real nics. Signed-off-by: yufengmx --- tests/TestSuite_pmd_stacked_bonded.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/TestSuite_pmd_stacked_bonded.py b/tests/TestSuite_pmd_st= acked_bonded.py index e1ce01a..de126b9 100644 --- a/tests/TestSuite_pmd_stacked_bonded.py +++ b/tests/TestSuite_pmd_stacked_bonded.py @@ -138,7 +138,10 @@ class TestBondingStacked(TestCase): cmds =3D [ ["port stop all", ''], ["set portlist " + ",".join([str(port) for port in portList]),= ''], - ["port start all", ' ', 15]] + # start top level bond port only, and let it propagate the sta= rt + # action to slave bond ports and its the real nics. + ["port start {}".format(master_bond_port), ' ', 15] + ] self.bond_inst.d_console(cmds) # blank space command is used to skip LSC event to avoid core dump= ed issue time.sleep(5) -- 1.9.3