Re: [PATCH 1/1] tests/cryptodev_common.py Supporting vfio denylist for QAT

["Juraj Linkeš" <juraj.linkes@pantheon.tech>]

On 17. 9. 2024 6:21, Patrick Robb wrote:
> On Mon, Sep 16, 2024 at 5:30 AM David Marchand
> <david.marchand@redhat.com> wrote:
>>
>> On Mon, Sep 16, 2024 at 6:15 AM Patrick Robb <probb@iol.unh.edu> wrote:
>>>
>>>
>>> diff --git a/tests/cryptodev_common.py b/tests/cryptodev_common.py
>>> index b550b46869df..37483c51e3e7 100644
>>> --- a/tests/cryptodev_common.py
>>> +++ b/tests/cryptodev_common.py
>>> @@ -15,6 +15,10 @@ def bind_qat_device(test_case, driver="igb_uio"):
>>>
>>>       if "crypto_dev_id" in conf.suite_cfg:
>>>           dev_id = conf.suite_cfg["crypto_dev_id"]
>>> +        if dev_id in ["37c8", "435", "19e2"]:
>>
>> Usually, PCI ids are represented on 4 chars, leading 0 included, so I
>> would expect 0435.
>> Do you have such hw and did you test with it?
> 
> I agree that 3 char id is strange.
> 
> This was some months ago, but I believe I grabbed the dev ids from
> https://doc.dpdk.org/guides/cryptodevs/qat.html#available-kernel-drivers
> based on the kernel commit you posted above.
> 
> This website, which I usually use when adding a new PCI device to
> legacy dts, https://devicehunt.com/view/type/pci/vendor/8086/device/0435
> suggests that the correct id is 0435. If this sounds right to you, I
> can submit a new version of this series with the 0 added, and a
> dpdk/doc patch for the page I included above (presuming that the id in
> the table is actually wrong).
> 
> In terms of testing, yes we do have a c62x / 37c8 card (qat 8970), and
> this commit did "fix" the testsuite for that card. I included the
> other two cards because even though I didn't have the hardware to test
> the change, I felt that my reading of the linux kernel commit above
> indicated it was appropriate to sumit this change, even without having
> run it on the specific hardware. Please let me know if this is
> inappropriate.
> 

The best is to check the device itself. These ID's can be found under:
/sys/bus/pci/devices/<pci>/

The four IDs are:
device
vendor
subsystem_device
subsystem_vendor

and I believe you're looking for device, but it seems you don't actually 
have the hardware. In that case, you can also consult 
https://pci-ids.ucw.cz/v2.2/pci.ids, which says:
     0435  DH895XCC Series QAT

And that it is from:
8086  Intel Corporation

So that seems to match the device. You should definitely add the 0, I'd 
say DTS is looking in /sys/bus/pci/devices/<pci>/device and it's going 
to be there.