From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE585459C3; Wed, 18 Sep 2024 11:57:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AD00427DB; Wed, 18 Sep 2024 11:57:08 +0200 (CEST) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mails.dpdk.org (Postfix) with ESMTP id E70234025C for ; Wed, 18 Sep 2024 11:57:07 +0200 (CEST) Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-374c7d14191so384540f8f.0 for ; Wed, 18 Sep 2024 02:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1726653427; x=1727258227; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oxOsprptag4JARWHGhpSL7hQnjVvrYnOM9Qm/WNZEoc=; b=dAaVMgz2LMAmy5gnvrvttxSoxF5pGhzwB4A9ia97jIqN7aWu+L8fXEuIIlCs0ctIYy OKBzwbPie/dg0qtWBHxheu2z+VqSczYz6GZCuxwYojQFdJezSUyJxGEtK82K6ot/TzaK ZCG2L6nu652WEqUdwOBQEX+DT0ADAz0Hndq6qQqWO06ugP2b+/2JpbvJN5j30xPOTvB6 EaB980dI8W2yj9U9mxYnwm69ZEo811cmVprxE8zmHyxhvVOjyvTegYc3xgzr2hsqDQpN 8H5Up3/Gzfs528V1DkmdUHzwfsefn0GjAgEGlxnJQBUN5Rm9FdbJSJ6Gt8CN2eWNVZnZ aPAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726653427; x=1727258227; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oxOsprptag4JARWHGhpSL7hQnjVvrYnOM9Qm/WNZEoc=; b=ZN1/e1/eqdK0njFF4TGHRDe2ZdPtjXw4YpoQHZrkb5JuZJKilH/KmR6DtuZvODD8Y/ D7/Bnff64mRTkyHm9nfFGsHiOXyRwNqfKAaMJvk357j4QLAEHSFfb0xXNUkgtIrE2LZM /Ik2N60Xb108pj86dHmVC8XoK3LQ/lSsdKFmBbgcZpk2MZHVWrv8khjOXxEf1k4FqCz7 aJaOZ06ykkhv5xNu3uQCCh0GjyEXZjgtUMZwxEPtCccjw3qmcMzWX6t1n3uHV10JKo5V v/QY+aPqHRrt3G9nOAmcjXmvoRUDRwQCw0XXA+kvc2zgglRdm85eLcYTdNMgxtbNH555 nkYQ== X-Gm-Message-State: AOJu0Ywiko5ARnPw4S6UKOCyKTsrAmLRRR51hH9mkaCDSG7vDXPrt7Vd Cyam+lCm7oFeInx2zuNJfofrLXXWsXw+k6Hv64tPZ1iELrZBl7RfiRmelksLhio= X-Google-Smtp-Source: AGHT+IEKAtAjgpVPZjKPWdf67sbJRG3mb2tvuIe1/7VUUu38GRLAIorSrI1jZQqg170p8gE8hhuNCQ== X-Received: by 2002:adf:edce:0:b0:374:cb28:b3f8 with SMTP id ffacd0b85a97d-378c27a268bmr13072358f8f.1.1726653426415; Wed, 18 Sep 2024 02:57:06 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e72e4abfsm11958669f8f.16.2024.09.18.02.57.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Sep 2024 02:57:06 -0700 (PDT) Message-ID: <801660d3-705e-420b-b228-281a614ebff8@pantheon.tech> Date: Wed, 18 Sep 2024 11:57:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] tests/cryptodev_common.py Supporting vfio denylist for QAT To: Patrick Robb , David Marchand Cc: dts@dpdk.org, Dharmik Jayesh Thakkar References: <20240916041409.181259-1-probb@iol.unh.edu> <20240916041409.181259-2-probb@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org On 17. 9. 2024 6:21, Patrick Robb wrote: > On Mon, Sep 16, 2024 at 5:30 AM David Marchand > wrote: >> >> On Mon, Sep 16, 2024 at 6:15 AM Patrick Robb wrote: >>> >>> >>> diff --git a/tests/cryptodev_common.py b/tests/cryptodev_common.py >>> index b550b46869df..37483c51e3e7 100644 >>> --- a/tests/cryptodev_common.py >>> +++ b/tests/cryptodev_common.py >>> @@ -15,6 +15,10 @@ def bind_qat_device(test_case, driver="igb_uio"): >>> >>> if "crypto_dev_id" in conf.suite_cfg: >>> dev_id = conf.suite_cfg["crypto_dev_id"] >>> + if dev_id in ["37c8", "435", "19e2"]: >> >> Usually, PCI ids are represented on 4 chars, leading 0 included, so I >> would expect 0435. >> Do you have such hw and did you test with it? > > I agree that 3 char id is strange. > > This was some months ago, but I believe I grabbed the dev ids from > https://doc.dpdk.org/guides/cryptodevs/qat.html#available-kernel-drivers > based on the kernel commit you posted above. > > This website, which I usually use when adding a new PCI device to > legacy dts, https://devicehunt.com/view/type/pci/vendor/8086/device/0435 > suggests that the correct id is 0435. If this sounds right to you, I > can submit a new version of this series with the 0 added, and a > dpdk/doc patch for the page I included above (presuming that the id in > the table is actually wrong). > > In terms of testing, yes we do have a c62x / 37c8 card (qat 8970), and > this commit did "fix" the testsuite for that card. I included the > other two cards because even though I didn't have the hardware to test > the change, I felt that my reading of the linux kernel commit above > indicated it was appropriate to sumit this change, even without having > run it on the specific hardware. Please let me know if this is > inappropriate. > The best is to check the device itself. These ID's can be found under: /sys/bus/pci/devices// The four IDs are: device vendor subsystem_device subsystem_vendor and I believe you're looking for device, but it seems you don't actually have the hardware. In that case, you can also consult https://pci-ids.ucw.cz/v2.2/pci.ids, which says: 0435 DH895XCC Series QAT And that it is from: 8086 Intel Corporation So that seems to match the device. You should definitely add the 0, I'd say DTS is looking in /sys/bus/pci/devices//device and it's going to be there.