From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Chen, LingliX" <linglix.chen@intel.com>,
"Ma, LihongX" <lihongx.ma@intel.com>,
"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_shutdown_api:fixed differences brought about by speed units
Date: Tue, 13 Oct 2020 02:13:21 +0000 [thread overview]
Message-ID: <808cebc7ccb847db947c2eb3232e6d36@intel.com> (raw)
In-Reply-To: <e6ede3f3781442f8b56c1c228415cc14@intel.com>
> > Can you write clearly why do we need to do this change ?
>
> if change Link speed is1000 or 10000,the DUT's Link speed is 1 Gbps or 10 Gbps,
> if change Link speed is100, the DUT's Link speed is 100 Mbps
It's not a good idea to get unit by value, if the speed is 1000Gbps(although we don't have it now, but soon in future), it can't know it is Gbps or Mbps.
Generally speaking, get unit first and then verify value.
prev parent reply other threads:[~2020-10-13 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 7:13 Chen Linglix
2020-09-28 7:21 ` Chen, LingliX
2020-10-12 6:39 ` Ma, LihongX
2020-10-12 6:54 ` Chen, LingliX
2020-10-13 2:13 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=808cebc7ccb847db947c2eb3232e6d36@intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=lihongx.ma@intel.com \
--cc=linglix.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).