test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Xu, Qian Q" <qian.q.xu@intel.com>
To: "Pei, Yulong" <yulong.pei@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] use get_port_mac() to get vf mac in testpmd
Date: Wed, 30 Dec 2015 02:46:01 +0000	[thread overview]
Message-ID: <82F45D86ADE5454A95A89742C8D1410E031A490F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1451033772-22540-1-git-send-email-yulong.pei@intel.com>

+        self.vm0_testpmd.execute_cmd('show port info all')
+        pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
In fact, self.vm0_testpmd.execute_cmd('show port info all') is not needed, get_port_mac has called the function to show port info port_id

Thanks
Qian

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yulong Pei
Sent: Friday, December 25, 2015 4:56 PM
To: dts@dpdk.org
Subject: [dts] [PATCH] use get_port_mac() to get vf mac in testpmd

use get_port_mac() to get vf mac in testpmd

Signed-off-by: Yulong Pei <yulong.pei@intel.com>
---
 tests/TestSuite_vf_packet_rxtx.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_vf_packet_rxtx.py b/tests/TestSuite_vf_packet_rxtx.py
index e5a9aca..19bc331 100644
--- a/tests/TestSuite_vf_packet_rxtx.py
+++ b/tests/TestSuite_vf_packet_rxtx.py
@@ -106,8 +106,12 @@ class TestVfPacketRxtx(TestCase):
 
         self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
 
+        port_id_0 = 0
+
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
+        self.vm0_testpmd.execute_cmd('show port info all')
+        pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
         self.vm0_testpmd.execute_cmd('set fwd mac')
         self.vm0_testpmd.execute_cmd('start')
 
@@ -118,7 +122,7 @@ class TestVfPacketRxtx(TestCase):
         rx_port = self.tester.get_local_port(self.dut_ports[1])
         tgen_ports.append((tx_port, rx_port))
 
-        dst_mac = self.vm_dut_0.get_mac_address(self.vm0_dut_ports[0])
+        dst_mac = pmd_vf0_mac
         src_mac = self.tester.get_mac(tx_port)
 
         pkt_param=[("ether", {'dst': dst_mac, 'src': src_mac})]
-- 
2.1.0

  reply	other threads:[~2015-12-30  2:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-25  8:56 Yulong Pei
2015-12-30  2:46 ` Xu, Qian Q [this message]
2015-12-30  3:36   ` Pei, Yulong
2016-01-05 13:40 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82F45D86ADE5454A95A89742C8D1410E031A490F@shsmsx102.ccr.corp.intel.com \
    --to=qian.q.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yulong.pei@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).