From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 169162BA0 for ; Fri, 26 Feb 2016 07:35:28 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 25 Feb 2016 22:35:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="895138265" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 25 Feb 2016 22:35:27 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 22:35:27 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 22:35:27 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.24]) with mapi id 14.03.0248.002; Fri, 26 Feb 2016 14:35:25 +0800 From: "Xu, Qian Q" To: "Tu, LijuanX A" , "Pei, Yulong" , "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts][PATCH]tests vf_port_start_stop: update test case Thread-Index: AQHRcFUJ8POcrDO6+0CrqHngJJzz8p89U2gAgAAB3ICAAIlfcA== Date: Fri, 26 Feb 2016 06:35:25 +0000 Message-ID: <82F45D86ADE5454A95A89742C8D1410E031EEE67@shsmsx102.ccr.corp.intel.com> References: <1456463602-14595-1-git-send-email-lijuanx.a.tu@intel.com> <188971FCDA171749BED5DA74ABF3E6F00353ACAF@shsmsx102.ccr.corp.intel.com> <38D041F150D4184C8114E499040E62340727F61D@shsmsx102.ccr.corp.intel.com> In-Reply-To: <38D041F150D4184C8114E499040E62340727F61D@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODJjZmE2OTUtOWY5MC00NTNjLWIwNTgtZDc0ZWVhYWEwYzM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOHUxQzAwVU9nV3FHNGoyYWlWMFBHcktlRGRIZHNFNjRKQXpcL0YzMFRiSTg9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH]tests vf_port_start_stop: update test case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 06:35:30 -0000 In fact, maybe we can't call it as an issue, it's a DPDK behavior. Because = DPDK has a state that port is ready to RX/TX but not start Polling, so it's= a state that Linux driver don't have, then we can't take Linux driver's be= havior as reference.=20 Thanks Qian -----Original Message----- From: Tu, LijuanX A=20 Sent: Friday, February 26, 2016 2:22 PM To: Pei, Yulong; Liu, Yong; dts@dpdk.org; Xu, Qian Q Subject: RE: [dts][PATCH]tests vf_port_start_stop: update test case OK ,I Will verify Rx-errors, except fortville > -----Original Message----- > From: Pei, Yulong > Sent: Friday, February 26, 2016 2:16 PM > To: Tu, LijuanX A; Liu, Yong; dts@dpdk.org; Xu, Qian Q > Subject: RE: [dts][PATCH]tests vf_port_start_stop: update test case >=20 > Hi Lijuan, >=20 > I think that maybe we keep checking Rx-errors and ignore this issue=20 > for Fortville NIC and regard it as a known issue is better. >=20 > Best Regards > Yulong Pei >=20 > -----Original Message----- > From: Tu, LijuanX A > Sent: Friday, February 26, 2016 1:13 PM > To: Liu, Yong ; dts@dpdk.org; Pei, Yulong=20 > ; Xu, Qian Q > Cc: Tu, LijuanX A > Subject: [dts][PATCH]tests vf_port_start_stop: update test case >=20 > Forwarding checking RX-packets, RX-Bytes, Tx-packets, Tx-bytes, Do not=20 > checking Rx-errors fortville NIC: > when not start, the port is ready to RX but NOT RX packets, > if you send 119 packets at 64B, then it will be RXed at the NIC's=20 > hardware buffer > if the buffer is full, it will show in RX-errors > so we do not verify Rx-errors. >=20 > Signed-off-by: Lijuan Tu > --- > tests/TestSuite_vf_port_start_stop.py | 48=20 > ++++++++++++++++++++++----- > -------- > 1 file changed, 30 insertions(+), 18 deletions(-) >=20 > diff --git a/tests/TestSuite_vf_port_start_stop.py > b/tests/TestSuite_vf_port_start_stop.py > index 0cc7ffd..17aa589 100644 > --- a/tests/TestSuite_vf_port_start_stop.py > +++ b/tests/TestSuite_vf_port_start_stop.py > @@ -114,11 +114,19 @@ class TestVfPortStartStop(TestCase): > testpmd.execute_cmd('port stop all') > testpmd.execute_cmd('clear port stats all') >=20 > - def check_port_start_stop(self, testpmd, times=3D10): > + def check_port_start_stop(self, testpmd, times=3D1000): > """ > VF port start/stop several times , check if it work well. > """ > + port_id_0 =3D 0 > + port_id_1 =3D 1 > + > for i in range(times): > + vf0_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_0) > + b_vf0_rx_pkts, b_vf0_rx_bytes =3D vf0_stats['RX-packets'], > vf0_stats['RX-bytes'] > + vf1_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_1) > + b_vf1_tx_pkts, b_vf1_tx_bytes =3D vf1_stats['TX-packets'],=20 > + vf1_stats['TX-bytes'] > + > out =3D testpmd.execute_cmd('port start all') > self.verify("Checking link statuses" in out, "ERROR: port=20 > start all") > testpmd.execute_cmd('start') @@ -127,22 +135,20 @@ class > TestVfPortStartStop(TestCase): > out =3D testpmd.execute_cmd('port stop all') > self.verify("Checking link statuses" in out, "ERROR: port=20 > stop all") >=20 > - port_id_0 =3D 0 > - port_id_1 =3D 1 > - vf0_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_0) > - vf1_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_1) > - > - vf0_rx_cnt =3D vf0_stats['RX-packets'] > - self.verify(vf0_rx_cnt !=3D 0, "no packet was received by > vm0_VF0") > - > - vf0_rx_err =3D vf0_stats['RX-errors'] > - self.verify(vf0_rx_err =3D=3D 0, "vm0_VF0 rx-errors") > - > - vf1_tx_cnt =3D vf1_stats['TX-packets'] > - self.verify(vf1_tx_cnt !=3D 0, "no packet was transmitted by > vm0_VF1") > - > - vf1_tx_err =3D vf1_stats['TX-errors'] > - self.verify(vf1_tx_err =3D=3D 0, "vm0_VF0 tx-errors") > + vf0_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_0) > + c_vf0_rx_pkts, c_vf0_rx_bytes =3D vf0_stats['RX-packets'], > vf0_stats['RX-bytes'] > + vf1_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_1) > + c_vf1_tx_pkts, c_vf1_tx_bytes =3D vf1_stats['TX-packets'],=20 > + vf1_stats['TX-bytes'] > + > + #Fortville NIC :when not start, the port is ready to RX > but NOT RX packets, > + #if you send packets , then it will be RXed at the NIC's > hardware buffer > + #if buffer is full ,it will show RX-errors > + #so, we do not check RX-errors > + #compare vf0 RX-packets RX-bytes ,vf1 Tx-packets TX-bytes > + self.verify(c_vf0_rx_pkts > b_vf0_rx_pkts, "Packets > received error") > + self.verify(c_vf0_rx_bytes > b_vf0_rx_bytes, "Bytes > received error") > + self.verify(c_vf1_tx_pkts > b_vf1_tx_pkts, "Packets > forwarding error") > + self.verify(c_vf1_tx_bytes > b_vf1_tx_bytes, "Bytes=20 > + forvwarding error") >=20 > def setup_1pf_2vf_1vm_env(self, driver=3D'default'): >=20 > @@ -215,11 +221,17 @@ class TestVfPortStartStop(TestCase): >=20 > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + > + self.vm0_testpmd.execute_cmd('port stop all') > + self.vm0_testpmd.execute_cmd('port config all crc-strip on') > + self.vm0_testpmd.execute_cmd('port start all') > self.vm0_testpmd.execute_cmd('set fwd mac') > +# self.vm0_testpmd.execute_cmd('start') >=20 > time.sleep(2) >=20 > - dst_mac =3D self.vm_dut_0.get_mac_address(self.vm0_dut_ports[0]) > + port_id_0 =3D 0 > + dst_mac =3D self.vm0_testpmd.get_port_mac(port_id_0) > self.send_and_verify(dst_mac, self.vm0_testpmd) >=20 > def tear_down(self): > -- > 1.9.3