test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Xu, Qian Q" <qian.q.xu@intel.com>
To: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>,
	"Liu, Yong" <yong.liu@intel.com>,
	"Pei, Yulong" <yulong.pei@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH]tests vf_packet_rxtx: turn on crc-strip
Date: Mon, 29 Feb 2016 06:49:58 +0000	[thread overview]
Message-ID: <82F45D86ADE5454A95A89742C8D1410E031F1DC6@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <38D041F150D4184C8114E499040E623407280240@shsmsx102.ccr.corp.intel.com>

Yes

Thanks
Qian

-----Original Message-----
From: Tu, LijuanX A 
Sent: Monday, February 29, 2016 2:50 PM
To: Liu, Yong; Pei, Yulong; dts@dpdk.org; Xu, Qian Q
Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip

Hi Yong,
	I have talk about crc-strip with Qian , and we think "set crc-strip on" is no harm.

> -----Original Message-----
> From: Liu, Yong
> Sent: Sunday, February 28, 2016 8:45 PM
> To: Pei, Yulong; Tu, LijuanX A; dts@dpdk.org; Xu, Qian Q
> Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> 
> Hi Lijuan, I remember only FVL PF driver enable crc-strip by default.
> Please correct if I'm wrong.
> 
> > -----Original Message-----
> > From: Pei, Yulong
> > Sent: Friday, February 26, 2016 3:37 PM
> > To: Tu, LijuanX A; Liu, Yong; dts@dpdk.org; Xu, Qian Q
> > Subject: RE: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> >
> > Ack+
> >
> > -----Original Message-----
> > From: Tu, LijuanX A
> > Sent: Friday, February 26, 2016 2:58 PM
> > To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org; Pei, Yulong 
> > <yulong.pei@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>
> > Cc: Tu, LijuanX A <lijuanx.a.tu@intel.com>
> > Subject: [dts][PATCH]tests vf_packet_rxtx: turn on crc-strip
> >
> > kernel driver turn on crc-strip as default
> >
> > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> > ---
> >  tests/TestSuite_vf_packet_rxtx.py | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/TestSuite_vf_packet_rxtx.py
> > b/tests/TestSuite_vf_packet_rxtx.py
> > index def7816..a632a44 100644
> > --- a/tests/TestSuite_vf_packet_rxtx.py
> > +++ b/tests/TestSuite_vf_packet_rxtx.py
> > @@ -110,6 +110,9 @@ class TestVfPacketRxtx(TestCase):
> >          port_id_0 = 0
> >          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
> >          self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> > +        self.vm0_testpmd.execute_cmd('port stop all')
> > +        self.vm0_testpmd.execute_cmd('port config all crc-strip on')
> > +        self.vm0_testpmd.execute_cmd('port start all')
> >          self.vm0_testpmd.execute_cmd('show port info all')
> >          pmd_vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
> >          self.vm0_testpmd.execute_cmd('set fwd mac')
> > --
> > 2.5.0

  reply	other threads:[~2016-02-29  6:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26  6:57 Lijuan Tu
2016-02-26  7:37 ` Pei, Yulong
2016-02-28 12:45   ` Liu, Yong
2016-02-28 14:12     ` Xu, Qian Q
2016-02-29  6:49     ` Tu, LijuanX A
2016-02-29  6:49       ` Xu, Qian Q [this message]
2016-03-02  5:24         ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82F45D86ADE5454A95A89742C8D1410E031F1DC6@shsmsx102.ccr.corp.intel.com \
    --to=qian.q.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    --cc=yong.liu@intel.com \
    --cc=yulong.pei@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).