From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1D6062956 for ; Fri, 22 Apr 2016 03:30:41 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 21 Apr 2016 18:30:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,515,1455004800"; d="scan'208";a="960223766" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 21 Apr 2016 18:30:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 21 Apr 2016 18:30:19 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.10]) with mapi id 14.03.0248.002; Fri, 22 Apr 2016 09:30:17 +0800 From: "Xu, Qian Q" To: "Liu, Yong" , "Ding, HengX" , "dts@dpdk.org" CC: "Ding, HengX" Thread-Topic: [dts] [PATCH] l3fwd/testpmd performance: optimize command for testpmd and comment some cases no need to run. Thread-Index: AQHRnDNnQczuOXE1wUyOaYZSQZmuQJ+VMGdw Date: Fri, 22 Apr 2016 01:30:16 +0000 Message-ID: <82F45D86ADE5454A95A89742C8D1410E0324F19E@shsmsx102.ccr.corp.intel.com> References: <1461118603-10248-1-git-send-email-hengx.ding@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E14F0643A@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E14F0643A@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjhlZmI0Y2EtYTE4YS00ODIxLWE3NDctNzAxOTQ1YzUwNzA3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ilg1d3g5Vnk3d3ZGaXNkVHF2Q1dLcXZEc2M1SGZFWFNiclRmWTB6cGhuUms9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] l3fwd/testpmd performance: optimize command for testpmd and comment some cases no need to run. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 01:30:42 -0000 See below comments.=20 Thanks Qian -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong Sent: Friday, April 22, 2016 9:07 AM To: Ding, HengX; dts@dpdk.org Cc: Ding, HengX Subject: Re: [dts] [PATCH] l3fwd/testpmd performance: optimize command for = testpmd and comment some cases no need to run. Hi Heng, some comments below. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Ding Heng > Sent: Wednesday, April 20, 2016 10:17 AM > To: dts@dpdk.org > Cc: Ding, HengX > Subject: [dts] [PATCH] l3fwd/testpmd performance: optimize command for=20 > testpmd and comment some cases no need to run. >=20 > l3fwd: comment 2 cases no need to run in nightly performance test. Fix=20 > issues for run rfc2544 case with different nic. Add 72 byte for=20 > performance test. >=20 > testpmd: change report format for generate nightly performance test.=20 > Use core mask instead of all cores for performance test. >=20 > framework/pmd_output: optimize command for performance, run testpmd in=20 > vector mode instead of Xmit mode. Optimize core configuration for=20 > testpmd because run testpmd with all cores will get a bad performance=20 > result. >=20 > Signed-off-by: Ding Heng >=20 > diff --git a/framework/pmd_output.py b/framework/pmd_output.py index=20 > df8db12..05e4e04 100644 > --- a/framework/pmd_output.py > +++ b/framework/pmd_output.py > @@ -101,14 +101,18 @@ class PmdOutput(): >=20 > def start_testpmd(self, cores, param=3D'', eal_param=3D'', socket=3D= 0): > # in dpdk2.0 need used --txqflags param to open hardware=20 > features > + # use 0xf01 to enable vector mode and get better performance. > if "--txqflags" not in param: > - param +=3D " --txqflags=3D0" Please not changed this default value for other suites depend on this. You = can appoint this value in performance suite. > + param +=3D " --txqflags=3D0xf01" >=20 > if type(cores) =3D=3D list: > core_list =3D cores > elif cores =3D=3D "Default": > core_list =3D self.dut.get_core_list(self.default_cores) > else: > + # testpmd could not run with single core, at least 2=20 > + cores > are needed. > + if cores =3D=3D "1S/1C/1T": > + cores =3D "1S/2C/1T" That's strange logic, please change input core setting as required.=20 [Qian] Yes, I am also confused first to see it, I know the cores setting ab= out 2C is testpmd used cores since testpmd will have a master core will is = not used in packet fwd. So, you can name different, such as testpmd_cores a= nd fwd_cores.=20