test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Wan, Zhe" <zhe.wan@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] test_plans/distributor: test plan revise
Date: Mon, 25 Mar 2019 08:31:33 +0000	[thread overview]
Message-ID: <861C16A15685B44AA870C0D2A97B60458976CE94@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA458EB@SHSMSX101.ccr.corp.intel.com>

Hi Lijuan,
Thanks for your review.
In the removed test cases, will start one and two workers, they have already get covered. 
And in now existing test cases, will start 1, 2, 3, 4, 8, 16, 32 workers. 
Also we didn't have these test cases in TestSuite_distributor.py.
So I removed these redundant test cases.

Thanks!
BR,
Wan,Zhe

-----Original Message-----
From: Tu, Lijuan 
Sent: Sunday, March 24, 2019 4:03 PM
To: Wan, Zhe <zhe.wan@intel.com>; dts@dpdk.org
Cc: Wan, Zhe <zhe.wan@intel.com>
Subject: RE: [dts] [PATCH V1] test_plans/distributor: test plan revise

Hi zhe,

1, There is a typo: ./test/tes/test -c f -n 4  should be ./test/test/test -c f -n 4 2, And confused by your directory, the actually test application directory should be  ./app/test/test or ./x86_64-native-linuxapp-gcc/app/test.
3, what do you think about remove several cases.


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhe
> Sent: Tuesday, March 19, 2019 4:04 AM
> To: dts@dpdk.org
> Cc: Wan, Zhe <zhe.wan@intel.com>
> Subject: [dts] [PATCH V1] test_plans/distributor: test plan revise
> 
> From: Zhe Wan <zhe.wan@intel.com>
> 
> Signed-off-by: Zhe Wan <zhe.wan@intel.com>
> ---
>  test_plans/distributor_test_plan.rst | 42 
> +++---------------------------------
>  1 file changed, 3 insertions(+), 39 deletions(-)
> 
> diff --git a/test_plans/distributor_test_plan.rst
> b/test_plans/distributor_test_plan.rst
> index 106936d..db64a54 100644
> --- a/test_plans/distributor_test_plan.rst
> +++ b/test_plans/distributor_test_plan.rst
> @@ -53,7 +53,7 @@ Test Case: Distributor unit test 
> ================================  Start test application and run 
> distributor unit test::
> 
> -	   test -c f -n 4 -- -i
> +	   ./test/test/test -c f -n 4
>  	   RTE>>distributor_autotest
> 
>  Verify burst distributor API unit test passed @@ -62,47 +62,13 @@ Test Case:
> Distributor performance unit test
> ============================================
>  Start test application and run distributor unit test::
> 
> -	   test -c f -n 4 -- -i
> +	   ./test/tes/test -c f -n 4
>  	   RTE>>distributor_perf_autotest
> 
>  Compared CPU cycles for normal distributor and burst API
> 
>  Verify burst distributor API cost much less cycles then normal 
> version
> 
> -Test Case: Distributor packet check
> -===================================
> -Start distributor sample with one worker::
> -
> -	distributor_app -c 0x7c  -n 4 -- -p 0x1
> -
> -Send few packets (less then burst size) with sequence index which 
> indicated in - ip dst address
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Send packets equal to burst size with sequence index
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Send packets over burst size with sequence index
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Test Case: Distributor with workers
> -===================================
> -Start distributor sample with two workers::
> -
> -	distributor_app -c 0xfc  -n 4 -- -p 0x1
> -
> -Send several packets with ip address increasing
> -
> -Check packets distributed to different workers
> -
> -Check all packets have been sent back from tx lcore
> -
> -Repeat step 1 to step4 with 
> 4(3fc)/8(3ffc)/16(0x3ffffc)/32(0xffff0003ffffc)
> -workers
> -
>  Test case: Distribute with maximum workers 
> ==========================================
>  Start distributor sample with 63(0xeffffffffffffffff0) workers @@ 
> -117,7 +83,7 @@ Test Case: Distributor with multiple input ports 
> ================================================
>  Start distributor sample with two workers and two ports::
> 
> -	distributor_app -c 0x7c -n 4 -- -p 0x3
> +	./examples/distributor/build/distributor_app -c 0x7c -n 4 -- -p 0x3
> 
>  Send packets with sequence indicated in udp port id
> 
> @@ -151,5 +117,3 @@ for each action in lcores as listed in the table below::
>  	
> +----+---------+--------+---------+--------+---------+--------+-------
> --+--------+-
> --------+--------+---------+--------+---------+
>  	| 7  |    32   |        |         |        |         |        |         |        |         |        |         |
> |         |
>  	
> +----+---------+--------+---------+--------+---------+--------+-------
> --+--------+-
> --------+--------+---------+--------+---------+
> -	| 8  |    63   |        |         |        |         |        |         |        |         |        |         |
> |         |
> -	+----+---------+--------+---------+--------+---------+--------+---------+--------+-
> --------+--------+---------+--------+---------+
> --
> 1.8.3.1


      reply	other threads:[~2019-03-25  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 11:03 Zhe
2019-03-19  3:21 ` Li, WenjieX A
2019-03-24  8:03 ` Tu, Lijuan
2019-03-25  8:31   ` Wan, Zhe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=861C16A15685B44AA870C0D2A97B60458976CE94@SHSMSX101.ccr.corp.intel.com \
    --to=zhe.wan@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).