From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AF224A0096 for ; Thu, 11 Apr 2019 08:38:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 67A245F16; Thu, 11 Apr 2019 08:38:33 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EE2E45F0F for ; Thu, 11 Apr 2019 08:38:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 23:38:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,336,1549958400"; d="scan'208";a="148269241" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 10 Apr 2019 23:38:30 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 23:38:29 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 23:38:29 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.25]) with mapi id 14.03.0415.000; Thu, 11 Apr 2019 14:38:27 +0800 From: "Wan, Zhe" To: "Tu, Lijuan" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] test_plans/scatter: test plan revise Thread-Index: AQHU6kLWLofBAQnc6Uu2p2oCsMI3iaY2hqBg Date: Thu, 11 Apr 2019 06:38:27 +0000 Message-ID: <861C16A15685B44AA870C0D2A97B60458978FE5A@SHSMSX101.ccr.corp.intel.com> References: <1553877003-190139-1-git-send-email-zhe.wan@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA5B7F3@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA5B7F3@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmRiNzg2NWUtNmFiZi00MGRlLWI3OTYtN2ZlMTgxOTVkNDhmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUnhMc1VERURPcVl6OTZPSHlzUFlZY1NxUmxhY3NrUUF0R2w0TnhmT3Mxc3FpSzMyOTJBXC8zMWVjdHkwQlwvY1c1In0= dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] test_plans/scatter: test plan revise X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi Lijuan, About the addition of '--tx-offloads=3D0x00008000', the background is DPDK-= 5618 (https://jira.devtools.intel.com/browse/DPDK-5618). The test plan didn't updated accordingly. commit 3743153fac89b821959fbb882058bf81177b07e7. Author: xu,gang Date: Tue Jul 10 10:49:58 2018 +0800 tests/scatter: fix selected wrong vector path on ixgbe When no tx offload enabled, ixgbe will chose vector path which can not support scatter. After enabling DEV_TX_OFFLOAD_MULTI_SEGS options, can avoid this problem. Signed-off-by: xu,gang https://mails.dpdk.org/archives/dts/2018-July/004208.html This TX offload capability defined in DPDK code 'dpdk/lib/librte_ethdev/rte= _ethdev.h' #define DEV_TX_OFFLOAD_MULTI_SEGS 0x00008000 /**< Device supports multi = segment send. */ Thanks! BR, Wan,Zhe -----Original Message----- From: Tu, Lijuan=20 Sent: Thursday, April 04, 2019 1:30 AM To: Wan, Zhe ; dts@dpdk.org Cc: Wan, Zhe Subject: RE: [dts] [PATCH V1] test_plans/scatter: test plan revise Hi zhe,=20 Could you please kindly add some interpretation about why is --tx-offloads= =3D0x00008000 ? thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhe > Sent: Friday, March 29, 2019 9:30 AM > To: dts@dpdk.org > Cc: Wan, Zhe > Subject: [dts] [PATCH V1] test_plans/scatter: test plan revise >=20 > From: Zhe Wan >=20 > Signed-off-by: Zhe Wan > --- > test_plans/scatter_test_plan.rst | 27 ++++++++++++--------------- > 1 file changed, 12 insertions(+), 15 deletions(-) >=20 > diff --git a/test_plans/scatter_test_plan.rst > b/test_plans/scatter_test_plan.rst > index cf5e1e5..ed1aaaa 100644 > --- a/test_plans/scatter_test_plan.rst > +++ b/test_plans/scatter_test_plan.rst > @@ -72,15 +72,15 @@ the CRC from the packet before returning it. > As a whole, the following packet lengths (CRC included) must be=20 > tested to check all packet memory configurations: >=20 > -#. packet length < mbuf data buffer size > +1) packet length < mbuf data buffer size >=20 > -#. packet length =3D mbuf data buffer size > +2) packet length =3D mbuf data buffer size >=20 > -#. packet length =3D mbuf data buffer size + 1 > +3) packet length =3D mbuf data buffer size + 1 >=20 > -#. packet length =3D mbuf data buffer size + 4 > +4) packet length =3D mbuf data buffer size + 4 >=20 > -#. packet length =3D mbuf data buffer size + 5 > +5) packet length =3D mbuf data buffer size + 5 >=20 > In cases 1) and 2), the hardware RX engine stores the packet data and=20 > the CRC in a single buffer. > @@ -101,21 +101,18 @@ Assuming that ports ``0`` and ``1`` of the test=20 > target are directly connected to a Traffic Generator, launch the=20 > ``testpmd`` application with the following > arguments:: >=20 > - ./build/app/testpmd -cffffff -n 3 -- -i --rxd=3D1024 --txd=3D1024 \ > - --burst=3D144 --txpt=3D32 --txht=3D8 --txwt=3D8 --txfreet=3D0 --rxfree= t=3D64 \ > - --mbcache=3D200 --portmask=3D0x3 --mbuf-size=3D1024 > + ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4 \ > + -- -i --mbcache=3D200 --mbuf-size=3D2048 --portmask=3D0x1 \ > + --max-pkt-len=3D9000 --port-topology=3Dloop --tx-offloads=3D0x00008000 >=20 > The -n command is used to select the number of memory channels. It=20 > should match the number of memory channels on that setup. >=20 > -Setting the size of the mbuf data buffer to 1024 makes 1025-bytes=20 > input packets -(CRC included) and larger packets to be stored in two=20 > buffers by the hardware -RX engine. > - > -Test Case: Mbuf 1024 traffic > +Test Case: Scatter Mbuf 2048 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >=20 > Start packet forwarding in the ``testpmd`` application with the=20 > ``start`` command. > -Send 5 packets of lengths (CRC included) 1023, 1024, 1025, 1028, and 102= 9. > +Send 5 packets,the lengths are mbuf-size + offset (CRC included). > +The offset are -1, 0, 1, 4, 5 respectively. > Check that the same amount of frames and bytes are received back by=20 > the Traffic -Generator from its port connected to the target's port 1. > +Generator from it's port connected to the target's port 1. > -- > 1.8.3.1