From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yong.liu@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id B7BCF58F3
 for <dts@dpdk.org>; Sun, 25 Jan 2015 02:07:47 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP; 24 Jan 2015 17:01:50 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,462,1418112000"; d="scan'208";a="517157178"
Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98])
 by orsmga003.jf.intel.com with ESMTP; 24 Jan 2015 17:00:50 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 PGSMSX106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Sun, 25 Jan 2015 09:07:43 +0800
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.192]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.92]) with mapi id 14.03.0195.001;
 Sun, 25 Jan 2015 09:07:41 +0800
From: "Liu, Yong" <yong.liu@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Thread-Topic: [PATCH 2/6] framework/crbs: Info clean up of crbs
Thread-Index: AQHQLzbPXTUmtpKQvUitbHnXhWWq/ZzQGDJA
Date: Sun, 25 Jan 2015 01:07:41 +0000
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10D5337F@SHSMSX103.ccr.corp.intel.com>
References: <1421156540-25810-1-git-send-email-michael.qiu@intel.com>
 <1421156540-25810-3-git-send-email-michael.qiu@intel.com>
In-Reply-To: <1421156540-25810-3-git-send-email-michael.qiu@intel.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dts] [PATCH 2/6] framework/crbs: Info clean up of crbs
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Jan 2015 01:07:48 -0000

Applied. Thanks.

> -----Original Message-----
> From: Qiu, Michael
> Sent: Tuesday, January 13, 2015 9:42 PM
> To: dts@dpdk.org
> Cc: Liu, Yong; Qiu, Michael
> Subject: [PATCH 2/6] framework/crbs: Info clean up of crbs
>=20
> It is not a good idea to add exactly IP and other details of
> one machine inside a company.
>=20
> Make it more clean and more general.
>=20
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
>  framework/crbs.py | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>=20
> diff --git a/framework/crbs.py b/framework/crbs.py
> index 98821ea..77446c3 100644
> --- a/framework/crbs.py
> +++ b/framework/crbs.py
> @@ -3,12 +3,13 @@ Static configuration data for any CRBs that can be used=
.
>  """
>  from settings import IXIA
>=20
> +# Todo: modify this script to a config file, like crbs.cfg
>  crbs =3D [
> -    {'IP': '10.239.128.117',
> +    {'IP': '',
>       'name': 'CrownPassCRB1',
> -     'user': 'root',
> -     'pass': 'tester',
> -     'tester IP': '10.239.128.116',
> +     'user': '',
> +     'pass': '',
> +     'tester IP': '',
>       IXIA: None,
>       'memory channels': 4,
>       'bypass core0': True},
> --
> 1.9.3