test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Zhang, XiaonanX" <xiaonanx.zhang@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework support get oversize for performance
Date: Tue, 27 Jan 2015 03:06:06 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10D541F4@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <63FB47D6C0357E428AA804B2C89068BA012905ED@SHSMSX104.ccr.corp.intel.com>

Applied and thanks for your explain. 

> -----Original Message-----
> From: Zhang, XiaonanX
> Sent: Tuesday, January 27, 2015 10:45 AM
> To: Liu, Yong; dts@dpdk.org
> Subject: RE: [dts] [PATCH] framework support get oversize for performance
> 
> Hi Yong,
>    I modified it for l3fwd performance about jumbo frame case as follows,
>    if frame_size > 1518,
>    l3fwd cmdline should add --enable-jumbo --max-pkt-len frame_size.
>    If we use ixia while rate return 0, We should focus on oversize at the
> same time.
> 
> 
> Best Regards
> Thanks
> 
> -----Original Message-----
> From: Liu, Yong
> Sent: Tuesday, January 27, 2015 9:35 AM
> To: Zhang, XiaonanX; dts@dpdk.org
> Subject: RE: [dts] [PATCH] framework support get oversize for performance
> 
> Hi xiaonan,
> Can you give use more detail information? Like that in which suite we
> should use oversize in replace of bitrate?
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaonan Zhang
> > Sent: Monday, January 26, 2015 5:19 PM
> > To: dts@dpdk.org
> > Subject: [dts] [PATCH] framework support get oversize for performance
> >
> > From: "xiaonanx.zhang" <xiaonanx.zhang@intel.com>
> >
> > modify get_transmission_results function in framework etgen.py
> > use ixia api stat cget -oversize to get Oversize and CRC Errors
> >
> > add return get oversize condition
> >
> > Signed-off-by: xiaonanx.zhang <xiaonanx.zhang@intel.com>
> > ---
> >  framework/etgen.py | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/framework/etgen.py b/framework/etgen.py
> > index 2f2e975..f2da4ab 100644
> > --- a/framework/etgen.py
> > +++ b/framework/etgen.py
> > @@ -581,13 +581,18 @@ class IxiaPacketGenerator(SSHConnection):
> >              out = self.send_expect("stat cget -bitsReceived", '% ', 10)
> >              self.logger.debug("port %d bits rate:" % (port) + out)
> >              bpsRate += int(out.strip())
> > +            out = self.send_expect("stat cget -oversize", '%', 10)
> > +            oversize += int(out.strip())
> >
> >          self.logger.info("Rate: %f Mpps" % (rate * 1.0 / 1000000))
> >          self.logger.info("Mbps rate: %f Mbps" % (bpsRate * 1.0 /
> 1000000))
> >
> >          self.send_expect("ixStopTransmit portList", "%", 30)
> >
> > -        return (bpsRate, rate)
> > +        if rate == 0 and oversize > 0:
> > +            return (bpsRate, oversize)
> > +        else:
> > +            return (bpsRate, rate)
> >
> >      def config_ixia_dcb_init(self, rxPort, txPort):
> >          """
> > --
> > 1.9.3

      reply	other threads:[~2015-01-27  3:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26  9:19 Xiaonan Zhang
2015-01-27  1:34 ` Liu, Yong
2015-01-27  2:45   ` Zhang, XiaonanX
2015-01-27  3:06     ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10D541F4@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xiaonanx.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).