From: "Liu, Yong" <yong.liu@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework/ssh: enable command status checkable for crb
Date: Sun, 15 Feb 2015 05:35:26 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10D7CD5C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1423978023-5381-1-git-send-email-michael.qiu@intel.com>
Applied, thx.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Michael Qiu
> Sent: Sunday, February 15, 2015 1:27 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH] framework/ssh: enable command status checkable for
> crb
>
> command status is not checkable now for crb.
> It is useful for crb.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
> framework/crb.py | 8 +++++---
> framework/ssh_pexpect.py | 2 +-
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/framework/crb.py b/framework/crb.py
> index fa03757..317be15 100644
> --- a/framework/crb.py
> +++ b/framework/crb.py
> @@ -55,7 +55,8 @@ class Crb(object):
> self.serializer = serializer
> self.ports_info = None
>
> - def send_expect(self, cmds, expected, timeout=TIMEOUT,
> alt_session=False):
> + def send_expect(self, cmds, expected, timeout=TIMEOUT,
> + alt_session=False, verify=False):
> """
> Send commands to crb and return string before expected string. If
> there's no expected string found before timeout, TimeoutException
> will
> @@ -63,9 +64,10 @@ class Crb(object):
> """
>
> if alt_session:
> - return self.alt_session.session.send_expect(cmds, expected,
> timeout)
> + return self.alt_session.session.send_expect(cmds, expected,
> + timeout, verify)
>
> - return self.session.send_expect(cmds, expected, timeout)
> + return self.session.send_expect(cmds, expected, timeout, verify)
>
> def set_test_types(self, func_tests, perf_tests):
> """
> diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py
> index 7e5c8fc..d293fe2 100644
> --- a/framework/ssh_pexpect.py
> +++ b/framework/ssh_pexpect.py
> @@ -42,7 +42,7 @@ class SSHPexpect(object):
> if not int(ret_status):
> return ret
> else:
> - self.logger.error("Command: %s failure!" % command)
> + self.logger.error("Command: %s failure!" % command)
> return -1
> else:
> return ret
> --
> 1.9.3
prev parent reply other threads:[~2015-02-15 5:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 5:27 Michael Qiu
2015-02-15 5:35 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10D7CD5C@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).