test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] update checksum offload cmd line
Date: Wed, 4 Mar 2015 06:11:59 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10D84469@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E10D84435@SHSMSX103.ccr.corp.intel.com>

Huilong,
Please add more detail information in git log, such as in which patch these commands changed.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong
> Sent: Wednesday, March 04, 2015 2:09 PM
> To: Xu, HuilongX; dts@dpdk.org
> Cc: root
> Subject: Re: [dts] update checksum offload cmd line
> 
> Applied, thanks. Do not forget to configure your git username and email
> correctly:)
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of huilongx.xu
> > Sent: Wednesday, March 04, 2015 10:33 AM
> > To: dts@dpdk.org
> > Cc: root
> > Subject: [dts] update checksum offload cmd line
> >
> > From: root <root@localhost.localdomain>
> >
> >
> > Signed-off-by: root <root@localhost.localdomain>
> > ---
> >  tests/TestSuite_checksum_offload.py |   18 +++++++++---------
> >  1 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/tests/TestSuite_checksum_offload.py
> > b/tests/TestSuite_checksum_offload.py
> > index 1ebac0f..6277f50 100644
> > --- a/tests/TestSuite_checksum_offload.py
> > +++ b/tests/TestSuite_checksum_offload.py
> > @@ -74,21 +74,21 @@ class TestChecksumOffload(TestCase):
> >          Run before each test case.
> >          """
> >          if self.dut.want_func_tests:
> > -            self.pmdout.start_testpmd("1S/2C/2T", "--portmask=%s " %
> > (self.portMask) + "--disable-hw-vlan --enable-rx-cksum --crc-strip")
> > +            self.pmdout.start_testpmd("1S/2C/2T", "--portmask=%s " %
> > (self.portMask) + "--disable-hw-vlan --enable-rx-cksum --crc-strip --
> > txqflags=0")
> >              self.dut.send_expect("set verbose 1", "testpmd>")
> >              self.dut.send_expect("set fwd csum", "testpmd>")
> >
> >      def checksum_enablehw(self, port):
> > -            self.dut.send_expect("tx_checksum set ip hw %d" % port,
> > "testpmd>")
> > -            self.dut.send_expect("tx_checksum set udp hw %d" % port,
> > "testpmd>")
> > -            self.dut.send_expect("tx_checksum set tcp hw %d" % port,
> > "testpmd>")
> > -            self.dut.send_expect("tx_checksum set sctp hw %d" % port,
> > "testpmd>")
> > +            self.dut.send_expect("csum set ip hw %d" % port, "testpmd>")
> > +            self.dut.send_expect("csum set udp hw %d" % port,
> "testpmd>")
> > +            self.dut.send_expect("csum set tcp hw %d" % port,
> "testpmd>")
> > +            self.dut.send_expect("csum set sctp hw %d" % port,
> "testpmd>")
> >
> >      def checksum_enablesw(self, port):
> > -            self.dut.send_expect("tx_checksum set ip sw %d" % port,
> > "testpmd>")
> > -            self.dut.send_expect("tx_checksum set udp sw %d" % port,
> > "testpmd>")
> > -            self.dut.send_expect("tx_checksum set tcp sw %d" % port,
> > "testpmd>")
> > -            self.dut.send_expect("tx_checksum set sctp sw %d" % port,
> > "testpmd>")
> > +            self.dut.send_expect("csum set ip sw %d" % port, "testpmd>")
> > +            self.dut.send_expect("csum set udp sw %d" % port,
> "testpmd>")
> > +            self.dut.send_expect("csum set tcp sw %d" % port,
> "testpmd>")
> > +            self.dut.send_expect("csum set sctp sw %d" % port,
> "testpmd>")
> >
> >      def checksum_validate(self, packets_sent, packets_expected):
> >          """
> > --
> > 1.7.4.4

      reply	other threads:[~2015-03-04  6:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04  2:33 huilongx.xu
2015-03-04  6:09 ` Liu, Yong
2015-03-04  6:11   ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10D84469@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).