test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [dts v1] support dpdk2.0 code
Date: Wed, 20 May 2015 08:00:01 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10E1DBB0@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1432103524-7743-1-git-send-email-huilongx.xu@intel.com>

Huilong,

"default_cores" should be moved to test_case.py. All suite shared variable should be defined there.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of huilongx xu
> Sent: Wednesday, May 20, 2015 2:32 PM
> To: dts@dpdk.org
> Subject: [dts] [dts v1] support dpdk2.0 code
> 
> From: huilong xu <huilongx.xu@intel.com>
> 
> changed list:
> 1. when start testpmd by pmd_output model, if testpmd parameter not
> include
>    "--txqflags=0", add it. because in dpdk2.0 testpmd must used txqflags
> for
>    open hardware features, egg: checsum offload, vlan
> 2. dut add a function set_default_corelist, if the server cores number
> more then   4, the default cores is 4. In test case you can used
> self.dut.default_cores
>    to start app.
> 
> Signed-off-by: huilong xu <huilongx.xu@intel.com>
> ---
>  framework/dut.py        |   11 +++++++++++
>  framework/pmd_output.py |    3 +++
>  2 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py
> index 5b7aba2..656fc78 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -140,6 +140,16 @@ class Dut(Crb):
>          """
>          return self.crb['pass']
> 
> +    def set_default_corelist(self):
> +        """
> +        set default cors list
> +        """
> +        core_num = len(self.cores)
> +        if core_num <= 4:
> +            self.default_cores = "1S/%dC/1T" % core_num
> +        else:
> +            self.default_cores = "1S/4C/1T"
> +
>      def dut_prerequisites(self):
>          """
>          Prerequest function should be called before execute any test case.
> @@ -155,6 +165,7 @@ class Dut(Crb):
>              self.send_expect('alias sed=gsed', '# ')
> 
>          self.init_core_list()
> +        self.set_default_corelist()
>          self.pci_devices_information()
>          # scan ports before restore interface
>          self.scan_ports()
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index 97274a5..78b4e4f 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -87,6 +87,9 @@ class PmdOutput():
>          return self.command
> 
>      def start_testpmd(self, cores, param='', eal_param='', socket=0):
> +        if "--txqflags" not in param:
> +            param += "  --txqflags=0"
> +
>          core_list = self.dut.get_core_list(cores, socket)
>          self.coremask = dts.create_mask(core_list)
>          command = "./%s/app/testpmd -c %s -n %d %s -- -i %s" \
> --
> 1.7.4.4

  reply	other threads:[~2015-05-20  8:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20  6:32 huilongx xu
2015-05-20  8:00 ` Liu, Yong [this message]
2015-05-20  8:10   ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10E1DBB0@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).