test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] fix test case can't get ports
Date: Fri, 19 Jun 2015 00:44:23 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10E4E703@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1434598413-17893-1-git-send-email-huilongx.xu@intel.com>

Thanks, applied into master branch.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of huilong,xu
> Sent: Thursday, June 18, 2015 11:34 AM
> To: dts@dpdk.org
> Subject: [dts] [PATCH V1] fix test case can't get ports
> 
> From: huilong xu <huilongx.xu@intel.com>
> 
> issue:
>    test case can't get ports when used port config replace port map
> fix:
>     not check dut port ipv6 connect stats
> 
>    # Please enter the commit message for your changes. Lines starting
> 
> Signed-off-by: huilong xu <huilongx.xu@intel.com>
> ---
>  framework/dut.py |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py
> index a9b4ed0..7762958 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -394,9 +394,8 @@ class Dut(Crb):
>                      if (socket is None or
>                          port_info['numa'] == -1 or
>                              socket == port_info['numa']):
> -                        # port has link
> -                        if (port_info['ipv6'] != "Not connected" and
> -                                self.tester.get_local_port(portid) != -1):
> +                        # port has link,
> +                        if self.tester.get_local_port(portid) != -1:
>                              ports.append(portid)
>              return ports
> 
> --
> 1.7.4.4

      reply	other threads:[~2015-06-19  0:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18  3:33 huilong,xu
2015-06-19  0:44 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10E4E703@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).