From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 69F2ACE7 for ; Wed, 8 Jul 2015 02:57:12 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 07 Jul 2015 17:57:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,427,1432623600"; d="scan'208";a="760207480" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by orsmga002.jf.intel.com with ESMTP; 07 Jul 2015 17:57:10 -0700 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 8 Jul 2015 08:57:09 +0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 8 Jul 2015 08:57:08 +0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.46]) by shsmsx102.ccr.corp.intel.com ([169.254.2.165]) with mapi id 14.03.0224.002; Wed, 8 Jul 2015 08:57:07 +0800 From: "Liu, Yong" To: "Qiu, Michael" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH 2/3] tests: Add RRC support in suit scatter Thread-Index: AQHQuJi3o1LHYERSDU2irC8kzI6am53QwEFQ Date: Wed, 8 Jul 2015 00:57:07 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10E5AD6A@SHSMSX103.ccr.corp.intel.com> References: <1436261880-22395-1-git-send-email-michael.qiu@intel.com> <1436261880-22395-3-git-send-email-michael.qiu@intel.com> In-Reply-To: <1436261880-22395-3-git-send-email-michael.qiu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH 2/3] tests: Add RRC support in suit scatter X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 00:57:13 -0000 Michael, Look like scatter feature only validated on Niantic, Fortville, RRC these t= hree types of card. We can check NIC type in set_up_all function and not need these duplicated = checking code.=20 > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Michael Qiu > Sent: Tuesday, July 07, 2015 5:38 PM > To: dts@dpdk.org > Subject: [dts] [PATCH 2/3] tests: Add RRC support in suit scatter >=20 > Add RRC support in suit scatter >=20 > Signed-off-by: Michael Qiu > --- > tests/TestSuite_scatter.py | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) >=20 > diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py > index 643fe4a..130898f 100644 > --- a/tests/TestSuite_scatter.py > +++ b/tests/TestSuite_scatter.py > @@ -62,10 +62,11 @@ class TestScatter(TestCase): > """ > sport =3D self.tester.get_local_port(sPortid) > sintf =3D self.tester.get_interface(sport) > - smac =3D self.dut.get_mac_address(sPortid) > + smac =3D self.tester.get_mac(sport) > + dmac =3D self.dut.get_mac_address(sPortid) > rport =3D self.tester.get_local_port(rPortid) > rintf =3D self.tester.get_interface(rport) > - if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single"]: > + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single", "redrockcanyou"]: > self.tester.send_expect("ifconfig %s mtu 9000" % sintf, "#") > self.tester.send_expect("ifconfig %s mtu 9000" % rintf, "#") >=20 > @@ -79,10 +80,10 @@ class TestScatter(TestCase): >=20 > self.tester.scapy_foreground() > self.tester.scapy_append( > - 'sendp([Ether(dst=3D"%s")/IP(len=3D%s)/Raw(load=3D"\x50"*%s)= ], > iface=3D"%s")' % (smac, pktlen, padding, sintf)) > + > 'sendp([Ether(src=3D"%s",dst=3D"%s")/IP(len=3D%s)/Raw(load=3D"\x50"*%s)], > iface=3D"%s")' % (smac, dmac,pktlen, padding, sintf)) > self.tester.scapy_execute() > res =3D self.tester.scapy_get_result() > - if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single"]: > + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single", "redrockcanyou"]: > self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#") > self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#") > return res > @@ -103,7 +104,7 @@ class TestScatter(TestCase): > portMask =3D dts.create_mask(dutPorts[:2]) >=20 > # set the mbuf size to 1024 > - if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single"]: > + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single", "redrockcanyou"]: > out =3D self.pmdout.start_testpmd( > "1S/2C/2T", "--mbcache=3D200 --mbuf-size=3D2048 --portma= sk=3D%s > --max-pkt-len=3D9000" % portMask) > else: > @@ -111,12 +112,12 @@ class TestScatter(TestCase): > "1S/2C/2T", "--mbcache=3D200 --mbuf-size=3D1024 -- > portmask=3D%s" % portMask) > self.verify("Error" not in out, "launch error 1") >=20 > - if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single"]: > + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit"= , > "fortville_spirit_single", "redrockcanyou"]: > self.dut.send_expect("set fwd mac", "testpmd> ", 120) > self.dut.send_expect("start", "testpmd> ") >=20 > for offset in [-1, 0, 1, 4, 5]: > - if self.nic in ["niantic", "fortville_eagle", > "fortville_spirit", "fortville_spirit_single"]: > + if self.nic in ["niantic", "fortville_eagle", > "fortville_spirit", "fortville_spirit_single", "redrockcanyou"]: > ret =3D self.scatter_pktgen_send_packet( > dutPorts[0], dutPorts[1], 2048 + offset) > else: > -- > 1.9.3